[char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long

[char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
head:   b3de8e3719e582f3182bb504295e4a8e43c8c96f
commit: 96c1d0581d00f7abe033350edb021a9d947d8d81 [25/45] Drivers: hv: vmbus: Add support for VMBus panic notifier handler
reproduce:
  # apt-get install sparse
  git checkout 96c1d0581d00f7abe033350edb021a9d947d8d81
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long
>> drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long
>> drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
>> drivers/hv/vmbus_drv.c:67:9: sparse: cast truncates bits from constant value (8000000000000000 becomes 0)

Please review and possibly fold the followup patch.

vim +67 drivers/hv/vmbus_drv.c

    45	
    46	static struct tasklet_struct msg_dpc;
    47	static struct completion probe_event;
    48	static int irq;
    49	
    50	
  > 51	int hyperv_panic_event(struct notifier_block *nb,
    52				unsigned long event, void *ptr)
    53	{
    54		struct pt_regs *regs;
    55	
    56		regs = current_pt_regs();
    57	
    58		wrmsrl(HV_X64_MSR_CRASH_P0, regs->ip);
    59		wrmsrl(HV_X64_MSR_CRASH_P1, regs->ax);
    60		wrmsrl(HV_X64_MSR_CRASH_P2, regs->bx);
    61		wrmsrl(HV_X64_MSR_CRASH_P3, regs->cx);
    62		wrmsrl(HV_X64_MSR_CRASH_P4, regs->dx);
    63	
    64		/*
    65		 * Let Hyper-V know there is crash data available
    66		 */
  > 67		wrmsrl(HV_X64_MSR_CRASH_CTL, HV_CRASH_CTL_CRASH_NOTIFY);
    68		return NOTIFY_DONE;
    69	}
    70	

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH char-misc] mei: bus: () can be static

[kbuild test robot]

drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 vmbus_drv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 526fa8b..8313e25 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -48,7 +48,7 @@ static struct completion probe_event;
 static int irq;
 
 
-int hyperv_panic_event(struct notifier_block *nb,
+static int hyperv_panic_event(struct notifier_block *nb,
 			unsigned long event, void *ptr)
 {
 	struct pt_regs *regs;

Re: [PATCH char-misc] mei: bus: () can be static

[Dan Carpenter]

On Mon, Mar 02, 2015 at 11:49:23AM +0800, kbuild test robot wrote:
> drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
> drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
> drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
> drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?

The subject and the patch don't match.

regards,
dan carpenter

RE: [PATCH char-misc] mei: bus: () can be static

[Winkler, Tomas]

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Monday, March 02, 2015 11:41
> To: Wu, Fengguang
> Cc: Winkler, Tomas; Greg Kroah-Hartman; Haiyang Zhang; linux-
> kernel@vger.kernel.org; Nick Meier; kbuild-all@01.org;
> devel@linuxdriverproject.org
> Subject: Re: [PATCH char-misc] mei: bus: () can be static
> 
> On Mon, Mar 02, 2015 at 11:49:23AM +0800, kbuild test robot wrote:
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not
> declared. Should it be static?
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not
> declared. Should it be static?
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not
> declared. Should it be static?
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not
> declared. Should it be static?
> 
> The subject and the patch don't match.
Exactly 

Thanks
Tomas

Re: [PATCH char-misc] mei: bus: () can be static

[Fengguang Wu]

On Mon, Mar 02, 2015 at 12:41:05PM +0300, Dan Carpenter wrote:
> On Mon, Mar 02, 2015 at 11:49:23AM +0800, kbuild test robot wrote:
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
> > drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
> 
> The subject and the patch don't match.

Sorry it's a bug. Root cause is, char-misc is a non-rebaseable tree,
so the script checks out the branch HEAD before generating the patch.
Then it gets the wrong title (which is based on the HEAD commit's subject).
Fixed now.

Thanks,
Fengguang

RE: [PATCH char-misc] mei: bus: () can be static

[Nick Meier]

Yes - the function should have been static.  This change correctly corrects the oversight.

thanks,

-Nick

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com] 
Sent: Sunday, March 1, 2015 8:49 PM
To: Tomas Winkler
Cc: kbuild-all@01.org; Greg Kroah-Hartman; Nick Meier; KY Srinivasan; Haiyang Zhang; devel@linuxdriverproject.org; linux-kernel@vger.kernel.org
Subject: [PATCH char-misc] mei: bus: () can be static

drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 vmbus_drv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 526fa8b..8313e25 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -48,7 +48,7 @@ static struct completion probe_event;  static int irq;
 
 
-int hyperv_panic_event(struct notifier_block *nb,
+static int hyperv_panic_event(struct notifier_block *nb,
 			unsigned long event, void *ptr)
 {
 	struct pt_regs *regs;

RE: [char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long

[Nick Meier]

I will correct this constant definition and resubmit.

-Nick Meier

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com] 
Sent: Sunday, March 1, 2015 8:49 PM
To: Nick Meier
Cc: kbuild-all@01.org; Greg Kroah-Hartman; KY Srinivasan; Haiyang Zhang; devel@linuxdriverproject.org; linux-kernel@vger.kernel.org
Subject: [char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
head:   b3de8e3719e582f3182bb504295e4a8e43c8c96f
commit: 96c1d0581d00f7abe033350edb021a9d947d8d81 [25/45] Drivers: hv: vmbus: Add support for VMBus panic notifier handler
reproduce:
  # apt-get install sparse
  git checkout 96c1d0581d00f7abe033350edb021a9d947d8d81
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long
>> drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long
>> drivers/hv/vmbus_drv.c:51:5: sparse: symbol 'hyperv_panic_event' was not declared. Should it be static?
>> drivers/hv/vmbus_drv.c:67:9: sparse: cast truncates bits from constant value (8000000000000000 becomes 0)

Please review and possibly fold the followup patch.

vim +67 drivers/hv/vmbus_drv.c

    45	
    46	static struct tasklet_struct msg_dpc;
    47	static struct completion probe_event;
    48	static int irq;
    49	
    50	
  > 51	int hyperv_panic_event(struct notifier_block *nb,
    52				unsigned long event, void *ptr)
    53	{
    54		struct pt_regs *regs;
    55	
    56		regs = current_pt_regs();
    57	
    58		wrmsrl(HV_X64_MSR_CRASH_P0, regs->ip);
    59		wrmsrl(HV_X64_MSR_CRASH_P1, regs->ax);
    60		wrmsrl(HV_X64_MSR_CRASH_P2, regs->bx);
    61		wrmsrl(HV_X64_MSR_CRASH_P3, regs->cx);
    62		wrmsrl(HV_X64_MSR_CRASH_P4, regs->dx);
    63	
    64		/*
    65		 * Let Hyper-V know there is crash data available
    66		 */
  > 67		wrmsrl(HV_X64_MSR_CRASH_CTL, HV_CRASH_CTL_CRASH_NOTIFY);
    68		return NOTIFY_DONE;
    69	}
    70	

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation