From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Dan Williams <dan.j.williams@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
dmaengine@vger.kernel.org, linux-pm@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] dmaengine: shdma: Move DMA stop to (runtime) suspend callbacks
Date: Mon, 2 Mar 2015 22:11:23 +0530 [thread overview]
Message-ID: <20150302164123.GB2613@intel.com> (raw)
In-Reply-To: <1424946394-6784-1-git-send-email-geert+renesas@glider.be>
On Thu, Feb 26, 2015 at 11:26:34AM +0100, Geert Uytterhoeven wrote:
> During system reboot, the sh-dma-engine device may be runtime-suspended,
> causing a crash:
>
> Unhandled fault: imprecise external abort (0x1406) at 0x0002c02c
> Internal error: : 1406 [#1] SMP ARM
> ...
> PC is at sh_dmae_ctl_stop+0x28/0x64
> LR is at sh_dmae_ctl_stop+0x24/0x64
>
> If the sh-dma-engine is runtime-suspended, its module clock is turned
> off, and its registers cannot be accessed.
>
> To fix this, move the call to sh_dmae_ctl_stop(), which touches the
> DMAOR register, to the sh_dmae_suspend() and sh_dmae_runtime_suspend()
> callbacks. This makes PM operations more symmetric, as both
> sh_dmae_resume() and sh_dmae_runtime_resume() already call sh_dmae_rst()
> to re-initialize the DMAOR register.
>
> Remove sh_dmae_shutdown(), as it became empty.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Dan Williams <dan.j.williams@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
dmaengine@vger.kernel.org, linux-pm@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] dmaengine: shdma: Move DMA stop to (runtime) suspend callbacks
Date: Mon, 02 Mar 2015 16:53:23 +0000 [thread overview]
Message-ID: <20150302164123.GB2613@intel.com> (raw)
In-Reply-To: <1424946394-6784-1-git-send-email-geert+renesas@glider.be>
On Thu, Feb 26, 2015 at 11:26:34AM +0100, Geert Uytterhoeven wrote:
> During system reboot, the sh-dma-engine device may be runtime-suspended,
> causing a crash:
>
> Unhandled fault: imprecise external abort (0x1406) at 0x0002c02c
> Internal error: : 1406 [#1] SMP ARM
> ...
> PC is at sh_dmae_ctl_stop+0x28/0x64
> LR is at sh_dmae_ctl_stop+0x24/0x64
>
> If the sh-dma-engine is runtime-suspended, its module clock is turned
> off, and its registers cannot be accessed.
>
> To fix this, move the call to sh_dmae_ctl_stop(), which touches the
> DMAOR register, to the sh_dmae_suspend() and sh_dmae_runtime_suspend()
> callbacks. This makes PM operations more symmetric, as both
> sh_dmae_resume() and sh_dmae_runtime_resume() already call sh_dmae_rst()
> to re-initialize the DMAOR register.
>
> Remove sh_dmae_shutdown(), as it became empty.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2015-03-02 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 10:26 [PATCH] dmaengine: shdma: Move DMA stop to (runtime) suspend callbacks Geert Uytterhoeven
2015-02-26 10:26 ` Geert Uytterhoeven
2015-02-26 13:21 ` Sergei Shtylyov
2015-02-26 13:21 ` Sergei Shtylyov
2015-02-26 13:30 ` Geert Uytterhoeven
2015-02-26 13:30 ` Geert Uytterhoeven
2015-03-02 11:56 ` Ulf Hansson
2015-03-02 11:56 ` Ulf Hansson
2015-03-02 16:41 ` Vinod Koul [this message]
2015-03-02 16:53 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302164123.GB2613@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.