From: Dan Carpenter <dan.carpenter@oracle.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [alsa-devel] [patch v2] ALSA: opl3: small array underflow
Date: Wed, 4 Mar 2015 00:06:30 +0300 [thread overview]
Message-ID: <20150303210630.GF5437@mwanda> (raw)
In-Reply-To: <54F620A5.900@ladisch.de>
On Tue, Mar 03, 2015 at 09:59:17PM +0100, Clemens Ladisch wrote:
> Dan Carpenter wrote:
> > We don't check for negatives so "pitchbend" can be SHRT_MIN here. It
> > means that we can read up to 6 elements before the start of the
> > opl3_note_table[] array.
> >
> > There are several ways we could fix this. I have gone with what is
> > maybe the lazier approach of just changing negative values to zero.
>
> The lower bound is not zero but -8192.
Oh. I should have understood that from your previous email. Sorry for
that. Third time is lucky, I suppose.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [alsa-devel] [patch v2] ALSA: opl3: small array underflow
Date: Tue, 03 Mar 2015 21:06:30 +0000 [thread overview]
Message-ID: <20150303210630.GF5437@mwanda> (raw)
In-Reply-To: <54F620A5.900@ladisch.de>
On Tue, Mar 03, 2015 at 09:59:17PM +0100, Clemens Ladisch wrote:
> Dan Carpenter wrote:
> > We don't check for negatives so "pitchbend" can be SHRT_MIN here. It
> > means that we can read up to 6 elements before the start of the
> > opl3_note_table[] array.
> >
> > There are several ways we could fix this. I have gone with what is
> > maybe the lazier approach of just changing negative values to zero.
>
> The lower bound is not zero but -8192.
Oh. I should have understood that from your previous email. Sorry for
that. Third time is lucky, I suppose.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-03 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 9:38 [patch] ALSA: seq_midi_emul: small array underflow Dan Carpenter
2015-03-03 9:38 ` Dan Carpenter
2015-03-03 11:21 ` [alsa-devel] " Clemens Ladisch
2015-03-03 11:21 ` Clemens Ladisch
2015-03-03 11:38 ` Dan Carpenter
2015-03-03 11:38 ` Dan Carpenter
2015-03-03 19:13 ` [patch v2] ALSA: opl3: " Dan Carpenter
2015-03-03 19:13 ` Dan Carpenter
2015-03-03 20:59 ` [alsa-devel] " Clemens Ladisch
2015-03-03 20:59 ` Clemens Ladisch
2015-03-03 21:06 ` Dan Carpenter [this message]
2015-03-03 21:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303210630.GF5437@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.