Re: [Outreachy kernel] [PATCH] Staging: fwserial: Replace NULL comparison with !foo

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 03, 2015 at 10:13:51AM -0800, Katie Dunne wrote:
> Addresses checkpatch.pl check
> CHECK: Comparison to NULL could be written "!fifi->data"
> 
> Makes the indicated replacements
> 
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
>  drivers/staging/fwserial/dma_fifo.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c
> index 0279062..4c50e08 100644
> --- a/drivers/staging/fwserial/dma_fifo.c
> +++ b/drivers/staging/fwserial/dma_fifo.c
> @@ -106,7 +106,7 @@ void dma_fifo_free(struct dma_fifo *fifo)
>  {
>  	struct dma_pending *pending, *next;
>  
> -	if (fifo->data == NULL)
> +	if (!fifo->data)

I really don't like this type of change, as you now loose the typesafe
check for NULL and not 0, and it makes it a tiny bit harder to read.

So just please ignore that checkpatch warning, it's not that good.

thanks,

greg k-h