[PATCH] Staging: fwserial: Replace NULL comparison with !foo

[PATCH] Staging: fwserial: Replace NULL comparison with !foo

[Katie Dunne]

Addresses checkpatch.pl check
CHECK: Comparison to NULL could be written "!fifi->data"

Makes the indicated replacements

Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
---
 drivers/staging/fwserial/dma_fifo.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c
index 0279062..4c50e08 100644
--- a/drivers/staging/fwserial/dma_fifo.c
+++ b/drivers/staging/fwserial/dma_fifo.c
@@ -106,7 +106,7 @@ void dma_fifo_free(struct dma_fifo *fifo)
 {
 	struct dma_pending *pending, *next;
 
-	if (fifo->data == NULL)
+	if (!fifo->data)
 		return;
 
 	list_for_each_entry_safe(pending, next, &fifo->pending, link)
@@ -123,7 +123,7 @@ void dma_fifo_reset(struct dma_fifo *fifo)
 {
 	struct dma_pending *pending, *next;
 
-	if (fifo->data == NULL)
+	if (!fifo->data)
 		return;
 
 	list_for_each_entry_safe(pending, next, &fifo->pending, link)
@@ -149,7 +149,7 @@ int dma_fifo_in(struct dma_fifo *fifo, const void *src, int n)
 {
 	int ofs, l;
 
-	if (fifo->data == NULL)
+	if (!fifo->data)
 		return -ENOENT;
 	if (fifo->corrupt)
 		return -ENXIO;
@@ -192,7 +192,7 @@ int dma_fifo_out_pend(struct dma_fifo *fifo, struct dma_pending *pended)
 {
 	unsigned len, n, ofs, l, limit;
 
-	if (fifo->data == NULL)
+	if (!fifo->data)
 		return -ENOENT;
 	if (fifo->corrupt)
 		return -ENXIO;
@@ -252,7 +252,7 @@ int dma_fifo_out_complete(struct dma_fifo *fifo, struct dma_pending *complete)
 {
 	struct dma_pending *pending, *next, *tmp;
 
-	if (fifo->data == NULL)
+	if (!fifo->data)
 		return -ENOENT;
 	if (fifo->corrupt)
 		return -ENXIO;
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: fwserial: Replace NULL comparison with !foo

[Greg KH]

On Tue, Mar 03, 2015 at 10:13:51AM -0800, Katie Dunne wrote:
> Addresses checkpatch.pl check
> CHECK: Comparison to NULL could be written "!fifi->data"
> 
> Makes the indicated replacements
> 
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
>  drivers/staging/fwserial/dma_fifo.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c
> index 0279062..4c50e08 100644
> --- a/drivers/staging/fwserial/dma_fifo.c
> +++ b/drivers/staging/fwserial/dma_fifo.c
> @@ -106,7 +106,7 @@ void dma_fifo_free(struct dma_fifo *fifo)
>  {
>  	struct dma_pending *pending, *next;
>  
> -	if (fifo->data == NULL)
> +	if (!fifo->data)

I really don't like this type of change, as you now loose the typesafe
check for NULL and not 0, and it makes it a tiny bit harder to read.

So just please ignore that checkpatch warning, it's not that good.

thanks,

greg k-h