From: Wolfram Sang <wsa@the-dreams.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
"Sébastien SZYMANSKI" <sebastien.szymanski@armadeus.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-i2c@vger.kernel.org
Subject: Re: Bug in i2c-core?
Date: Wed, 4 Mar 2015 07:47:21 +0100 [thread overview]
Message-ID: <20150304064721.GA883@katana> (raw)
In-Reply-To: <3574616.qzNqihiGp7@avalon>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
> > Yes, this commit breaks all drivers using devm* for IRQ management on
> > OF-based systemsi because devm* cleanup happens in device code, after
> > bus's remove() method returns. I'd recommend reverting and finding a
> > better way (making cleanup a custom devm action as well?).
>
> Ouch, my bad.
>
> Wolfram, any opinion ? The original patch fixes a real bug, so we shouldn't
> just revert it.
I guess the usual rules apply. Let's try to fix it for v4.0, otherwise I
have to revert it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: Bug in i2c-core?
Date: Wed, 4 Mar 2015 07:47:21 +0100 [thread overview]
Message-ID: <20150304064721.GA883@katana> (raw)
In-Reply-To: <3574616.qzNqihiGp7@avalon>
> > Yes, this commit breaks all drivers using devm* for IRQ management on
> > OF-based systemsi because devm* cleanup happens in device code, after
> > bus's remove() method returns. I'd recommend reverting and finding a
> > better way (making cleanup a custom devm action as well?).
>
> Ouch, my bad.
>
> Wolfram, any opinion ? The original patch fixes a real bug, so we shouldn't
> just revert it.
I guess the usual rules apply. Let's try to fix it for v4.0, otherwise I
have to revert it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150304/3ee92e4f/attachment.sig>
next prev parent reply other threads:[~2015-03-04 6:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 11:09 Bug in i2c-core? Sébastien SZYMANSKI
2015-02-27 11:09 ` Sébastien SZYMANSKI
2015-02-27 14:37 ` Thomas Petazzoni
2015-02-27 14:37 ` Thomas Petazzoni
2015-02-27 15:29 ` Dmitry Torokhov
2015-02-27 15:29 ` Dmitry Torokhov
2015-02-27 17:05 ` Uwe Kleine-König
2015-02-27 17:05 ` Uwe Kleine-König
2015-02-27 17:46 ` Dmitry Torokhov
2015-02-27 17:46 ` Dmitry Torokhov
2015-02-27 18:39 ` Uwe Kleine-König
2015-02-27 18:39 ` Uwe Kleine-König
2015-02-28 10:00 ` Thomas Petazzoni
2015-02-28 10:00 ` Thomas Petazzoni
[not found] ` <54F0507F.6030804-d2DlULPkwbNWk0Htik3J/w@public.gmane.org>
2015-02-27 16:59 ` Dmitry Torokhov
2015-02-27 16:59 ` Dmitry Torokhov
2015-02-27 17:01 ` Dmitry Torokhov
2015-02-27 17:01 ` Dmitry Torokhov
2015-03-03 22:03 ` Laurent Pinchart
2015-03-03 22:03 ` Laurent Pinchart
2015-03-04 6:47 ` Wolfram Sang [this message]
2015-03-04 6:47 ` Wolfram Sang
2015-03-04 8:22 ` Wolfram Sang
2015-03-04 8:22 ` Wolfram Sang
2015-03-08 8:26 ` Wolfram Sang
2015-03-08 8:26 ` Wolfram Sang
2015-03-10 0:21 ` Laurent Pinchart
2015-03-10 0:21 ` Laurent Pinchart
2015-03-12 9:35 ` Wolfram Sang
2015-03-12 9:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304064721.GA883@katana \
--to=wsa@the-dreams.de \
--cc=dmitry.torokhov@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=sebastien.szymanski@armadeus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.