From: Borislav Petkov <bp@alien8.de>
To: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
josh@joshtriplett.org
Subject: Re: [PATCH 05/16] arch: x86: kernel: Make internal functions static in cpu/intel_cacheinfo.c
Date: Wed, 4 Mar 2015 19:46:34 +0100 [thread overview]
Message-ID: <20150304184634.GA3526@pd.tnic> (raw)
In-Reply-To: <63cb1aefe4d19b7526fe1ae2fb8066152eba1c8b.1425473428.git.darshanapadmadas@gmail.com>
On Wed, Mar 04, 2015 at 07:02:07PM +0530, Darshana Padmadas wrote:
> cpu/intel_cacheinfo.c defines two functions amd_get_l3_disable_slot
> and amd_set_l3_disable_slot. No other file uses these functions.
> So make these static.
>
> This eliminates the following warnings:
>
> arch/x86/kernel/cpu/intel_cacheinfo.c:349:5: warning: no previous prototype for ‘amd_get_l3_disable_slot’ [-Wmissing-prototypes]
> arch/x86/kernel/cpu/intel_cacheinfo.c:427:5: warning: no previous prototype for ‘amd_set_l3_disable_slot’ [-Wmissing-prototypes]
Please correct your commit message - this patch is making functions
static and not fixing -Wmissing-prototypes warnings. Also, go through
the rest of the patchset as I see other cases of this too.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-03-04 18:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 13:32 [PATCH 00/16] Eliminate GCC -Wmissing-prototype warnings Darshana Padmadas
2015-03-04 13:32 ` [PATCH 01/16] arch: x86: boot: Make function static and add function prototype Darshana Padmadas
2015-03-04 18:50 ` Ingo Molnar
2015-03-04 13:32 ` [PATCH 02/16] arch: x86: boot: Add prototype for decompress_kernel Darshana Padmadas
2015-03-04 13:32 ` [PATCH 03/16] arch: x86: boot: Include header string.h for function prototypes Darshana Padmadas
2015-03-04 13:32 ` [PATCH 04/16] arch: x86: ia32: Add prototype for compat_ni_syscall Darshana Padmadas
2015-03-04 13:32 ` [PATCH 05/16] arch: x86: kernel: Make internal functions static in cpu/intel_cacheinfo.c Darshana Padmadas
2015-03-04 18:46 ` Borislav Petkov [this message]
2015-03-04 18:54 ` Ingo Molnar
2015-03-04 13:32 ` [PATCH 06/16] arch: x86: kernel: cpu: Mark function mce_chrdev_write static Darshana Padmadas
2015-03-04 13:32 ` [PATCH 07/16] arch: x86: kernel: Mark internal function EVT_TO_HPET_DEV static Darshana Padmadas
2015-03-04 13:32 ` [PATCH 08/16] arch: x86: kernel: Mark internal functions static in kvm.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 09/16] arch: x86: kernel: Include <asm/switch_to.h> for function prototype Darshana Padmadas
2015-03-04 13:32 ` [PATCH 10/16] arch: x86: kernel: Add prototype for function sys32_x32_rt_sigreturn Darshana Padmadas
2015-03-04 13:32 ` [PATCH 11/16] arch: x86: kernel: Add prototype for smp_reboot_interrupt Darshana Padmadas
2015-03-04 13:32 ` [PATCH 12/16] arch: x86: kernel: Add prototype for fixup_bad_iret in traps.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 13/16] arch: x86: xen: Add prototype for xen_start_kernel in enlighten.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 14/16] arch: x86: xen: Mark internal function xen_flush_tlb_all static Darshana Padmadas
2015-03-04 13:32 ` [PATCH 15/16] arch: x86: xen: Add prototypes for functions defined in mmu.c Darshana Padmadas
2015-03-04 13:32 ` [PATCH 16/16] arch: x86: xen: Mark internal functions static in setup.c Darshana Padmadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304184634.GA3526@pd.tnic \
--to=bp@alien8.de \
--cc=darshanapadmadas@gmail.com \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.