All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Juneho Choi <juno.choi@lge.com>, Gunho Lee <gunho.lee@lge.com>,
	Luigi Semenzato <semenzato@google.com>,
	Dan Streetman <ddstreet@ieee.org>,
	Seth Jennings <sjennings@variantweb.net>,
	Nitin Gupta <ngupta@vflare.org>,
	Jerome Marchand <jmarchan@redhat.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	opensource.ganesh@gmail.com
Subject: Re: [PATCH v2 7/7] zsmalloc: add fullness into stat
Date: Thu, 5 Mar 2015 09:43:31 +0900	[thread overview]
Message-ID: <20150305004330.GB2592@blaptop> (raw)
In-Reply-To: <20150304140202.905f566b7107e2735d075b27@linux-foundation.org>

Hello Andrew,

On Wed, Mar 04, 2015 at 02:02:02PM -0800, Andrew Morton wrote:
> On Wed,  4 Mar 2015 14:01:32 +0900 Minchan Kim <minchan@kernel.org> wrote:
> 
> > +static int zs_stats_size_show(struct seq_file *s, void *v)
> > +{
> > +	int i;
> > +	struct zs_pool *pool = s->private;
> > +	struct size_class *class;
> > +	int objs_per_zspage;
> > +	unsigned long class_almost_full, class_almost_empty;
> > +	unsigned long obj_allocated, obj_used, pages_used;
> > +	unsigned long total_class_almost_full = 0, total_class_almost_empty = 0;
> > +	unsigned long total_objs = 0, total_used_objs = 0, total_pages = 0;
> > +
> > +	seq_printf(s, " %5s %5s %11s %12s %13s %10s %10s %16s\n",
> > +			"class", "size", "almost_full", "almost_empty",
> > +			"obj_allocated", "obj_used", "pages_used",
> > +			"pages_per_zspage");
> 
> Documentation?

It should been since [0f050d9, mm/zsmalloc: add statistics support].
Anyway, I will try it.
Where is right place to put only this statistics in Documentation?

Documentation/zsmalloc.txt?
Documentation/vm/zsmalloc.txt?
Documentation/blockdev/zram.txt?
Documentation/ABI/testing/sysfs-block-zram?

I hope you suggest.

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Juneho Choi <juno.choi@lge.com>, Gunho Lee <gunho.lee@lge.com>,
	Luigi Semenzato <semenzato@google.com>,
	Dan Streetman <ddstreet@ieee.org>,
	Seth Jennings <sjennings@variantweb.net>,
	Nitin Gupta <ngupta@vflare.org>,
	Jerome Marchand <jmarchan@redhat.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	opensource.ganesh@gmail.com
Subject: Re: [PATCH v2 7/7] zsmalloc: add fullness into stat
Date: Thu, 5 Mar 2015 09:43:31 +0900	[thread overview]
Message-ID: <20150305004330.GB2592@blaptop> (raw)
In-Reply-To: <20150304140202.905f566b7107e2735d075b27@linux-foundation.org>

Hello Andrew,

On Wed, Mar 04, 2015 at 02:02:02PM -0800, Andrew Morton wrote:
> On Wed,  4 Mar 2015 14:01:32 +0900 Minchan Kim <minchan@kernel.org> wrote:
> 
> > +static int zs_stats_size_show(struct seq_file *s, void *v)
> > +{
> > +	int i;
> > +	struct zs_pool *pool = s->private;
> > +	struct size_class *class;
> > +	int objs_per_zspage;
> > +	unsigned long class_almost_full, class_almost_empty;
> > +	unsigned long obj_allocated, obj_used, pages_used;
> > +	unsigned long total_class_almost_full = 0, total_class_almost_empty = 0;
> > +	unsigned long total_objs = 0, total_used_objs = 0, total_pages = 0;
> > +
> > +	seq_printf(s, " %5s %5s %11s %12s %13s %10s %10s %16s\n",
> > +			"class", "size", "almost_full", "almost_empty",
> > +			"obj_allocated", "obj_used", "pages_used",
> > +			"pages_per_zspage");
> 
> Documentation?

It should been since [0f050d9, mm/zsmalloc: add statistics support].
Anyway, I will try it.
Where is right place to put only this statistics in Documentation?

Documentation/zsmalloc.txt?
Documentation/vm/zsmalloc.txt?
Documentation/blockdev/zram.txt?
Documentation/ABI/testing/sysfs-block-zram?

I hope you suggest.

-- 
Kind regards,
Minchan Kim

  reply	other threads:[~2015-03-05  0:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  5:01 [PATCH v2 0/7] zsmalloc: compaction support Minchan Kim
2015-03-04  5:01 ` Minchan Kim
2015-03-04  5:01 ` [PATCH v2 1/7] zsmalloc: decouple handle and object Minchan Kim
2015-03-04  5:01   ` Minchan Kim
2015-03-04  5:07   ` Minchan Kim
2015-03-04  5:07     ` Minchan Kim
2015-03-04  5:01 ` [PATCH v2 2/7] zsmalloc: factor out obj_[malloc|free] Minchan Kim
2015-03-04  5:01   ` Minchan Kim
2015-03-04  5:01 ` [PATCH v2 3/7] zsmalloc: support compaction Minchan Kim
2015-03-04  5:01   ` Minchan Kim
2015-03-05  5:18   ` Heesub Shin
2015-03-05  5:18     ` Heesub Shin
2015-03-09  0:05     ` Minchan Kim
2015-03-09  0:05       ` Minchan Kim
2015-03-04  5:01 ` [PATCH v2 4/7] zsmalloc: adjust ZS_ALMOST_FULL Minchan Kim
2015-03-04  5:01   ` Minchan Kim
2015-03-04  5:01 ` [PATCH v2 5/7] zram: support compaction Minchan Kim
2015-03-04  5:01   ` Minchan Kim
2015-03-04  5:01 ` [PATCH v2 6/7] zsmalloc: record handle in page->private for huge object Minchan Kim
2015-03-04  5:01   ` Minchan Kim
2015-03-04  5:01 ` [PATCH v2 7/7] zsmalloc: add fullness into stat Minchan Kim
2015-03-04  5:01   ` Minchan Kim
2015-03-04 22:02   ` Andrew Morton
2015-03-04 22:02     ` Andrew Morton
2015-03-05  0:43     ` Minchan Kim [this message]
2015-03-05  0:43       ` Minchan Kim
2015-03-05  0:56       ` Andrew Morton
2015-03-05  0:56         ` Andrew Morton
2015-03-04  5:09 ` [PATCH v2 0/7] zsmalloc: compaction support Minchan Kim
2015-03-04  5:09   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150305004330.GB2592@blaptop \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ddstreet@ieee.org \
    --cc=gunho.lee@lge.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jmarchan@redhat.com \
    --cc=juno.choi@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=opensource.ganesh@gmail.com \
    --cc=semenzato@google.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sjennings@variantweb.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.