* [patch] m68k: remove a superflous KERN_ERR
@ 2015-03-05 11:27 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-05 11:27 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-m68k, kernel-janitors
pr_err() has a KERN_ERR built in. Smatch complains about these nowadays.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
index 931a31f..8520250 100644
--- a/arch/m68k/kernel/pcibios.c
+++ b/arch/m68k/kernel/pcibios.c
@@ -62,7 +62,7 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
r = dev->resource + idx;
if (!r->start && r->end) {
- pr_err(KERN_ERR "PCI: Device %s not available because of resource collisions\n",
+ pr_err("PCI: Device %s not available because of resource collisions\n",
pci_name(dev));
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] m68k: remove a superflous KERN_ERR
@ 2015-03-05 11:27 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-05 11:27 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-m68k, kernel-janitors
pr_err() has a KERN_ERR built in. Smatch complains about these nowadays.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c
index 931a31f..8520250 100644
--- a/arch/m68k/kernel/pcibios.c
+++ b/arch/m68k/kernel/pcibios.c
@@ -62,7 +62,7 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
r = dev->resource + idx;
if (!r->start && r->end) {
- pr_err(KERN_ERR "PCI: Device %s not available because of resource collisions\n",
+ pr_err("PCI: Device %s not available because of resource collisions\n",
pci_name(dev));
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] m68k: remove a superflous KERN_ERR
2015-03-05 11:27 ` Dan Carpenter
@ 2015-03-05 11:46 ` Geert Uytterhoeven
-1 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2015-03-05 11:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Linux/m68k, kernel-janitors@vger.kernel.org, Greg Ungerer
On Thu, Mar 5, 2015 at 12:27 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> pr_err() has a KERN_ERR built in. Smatch complains about these nowadays.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks! Will apply and queue for v4.1.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] m68k: remove a superflous KERN_ERR
@ 2015-03-05 11:46 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2015-03-05 11:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Linux/m68k, kernel-janitors@vger.kernel.org, Greg Ungerer
On Thu, Mar 5, 2015 at 12:27 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> pr_err() has a KERN_ERR built in. Smatch complains about these nowadays.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks! Will apply and queue for v4.1.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-05 11:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-05 11:27 [patch] m68k: remove a superflous KERN_ERR Dan Carpenter
2015-03-05 11:27 ` Dan Carpenter
2015-03-05 11:46 ` Geert Uytterhoeven
2015-03-05 11:46 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.