All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] genirq: describe IRQF_COND_SUSPEND
Date: Thu, 5 Mar 2015 12:33:06 +0100	[thread overview]
Message-ID: <20150305113306.GP3989@piout.net> (raw)
In-Reply-To: <20150305110411.GC13617@leverpostej>

On 05/03/2015 at 11:04:11 +0000, Mark Rutland wrote :
> > > +In rare cases an IRQ can be shared between a wakeup device driver and an
> > > +IRQF_NO_SUSPEND user. In order for this to be safe, the wakeup device driver
> > > +must be able to discern spurious IRQs from genuine wakeup events (signalling
> > 
> > And genuine question, should we use British English or American English
> > or we don't care ?
> 
> Have I written something that isn't valid American English there? I read
> over this a few times and failed to spot anything obvious.
> 
> I'm happy to change for consistency, I generally assume that's the most
> important thing.

I'd say signalling vs signaling. I actually had to look up which one was
correct. I'm personally using Incorrect/Broken English so I'm definitely
not here to give lessons.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] genirq: describe IRQF_COND_SUSPEND
Date: Thu, 5 Mar 2015 12:33:06 +0100	[thread overview]
Message-ID: <20150305113306.GP3989@piout.net> (raw)
In-Reply-To: <20150305110411.GC13617@leverpostej>

On 05/03/2015 at 11:04:11 +0000, Mark Rutland wrote :
> > > +In rare cases an IRQ can be shared between a wakeup device driver and an
> > > +IRQF_NO_SUSPEND user. In order for this to be safe, the wakeup device driver
> > > +must be able to discern spurious IRQs from genuine wakeup events (signalling
> > 
> > And genuine question, should we use British English or American English
> > or we don't care ?
> 
> Have I written something that isn't valid American English there? I read
> over this a few times and failed to spot anything obvious.
> 
> I'm happy to change for consistency, I generally assume that's the most
> important thing.

I'd say signalling vs signaling. I actually had to look up which one was
correct. I'm personally using Incorrect/Broken English so I'm definitely
not here to give lessons.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-05 11:33 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24  9:55 [RFC PATCH 0/3] genirq: mixing IRQF_NO_SUSPEND and wakeup sources on shared IRQs Boris Brezillon
2015-02-24  9:55 ` Boris Brezillon
2015-02-24  9:56 ` [RFC PATCH 1/3] genirq: prevent system wakeup when dealing with IRQF_NO_SUSPEND IRQs Boris Brezillon
2015-02-24  9:56   ` Boris Brezillon
2015-02-25 22:01   ` Rafael J. Wysocki
2015-02-25 22:01     ` Rafael J. Wysocki
2015-02-26  8:06     ` Boris Brezillon
2015-02-26  8:06       ` Boris Brezillon
2015-02-24  9:56 ` [RFC PATCH 2/3] genirq: add helper functions to deal with wakeup on shared " Boris Brezillon
2015-02-24  9:56   ` Boris Brezillon
2015-02-25 22:03   ` Rafael J. Wysocki
2015-02-25 22:03     ` Rafael J. Wysocki
2015-02-26  8:09     ` Boris Brezillon
2015-02-26  8:09       ` Boris Brezillon
2015-02-24  9:56 ` [RFC PATCH 3/3] rtc: at91sam9: properly act when IRQ handler is called in suspended state Boris Brezillon
2015-02-24  9:56   ` Boris Brezillon
2015-02-25 22:05   ` Rafael J. Wysocki
2015-02-25 22:05     ` Rafael J. Wysocki
2015-02-26  8:12     ` Boris Brezillon
2015-02-26  8:12       ` Boris Brezillon
2015-02-25 21:59 ` [RFC PATCH 0/3] genirq: mixing IRQF_NO_SUSPEND and wakeup sources on shared IRQs Rafael J. Wysocki
2015-02-25 21:59   ` Rafael J. Wysocki
2015-02-26  8:03   ` Boris Brezillon
2015-02-26  8:03     ` Boris Brezillon
2015-02-26 15:44     ` Rafael J. Wysocki
2015-02-26 15:44       ` Rafael J. Wysocki
2015-02-26 15:47       ` Boris Brezillon
2015-02-26 15:47         ` Boris Brezillon
2015-02-26 18:17         ` Rafael J. Wysocki
2015-02-26 18:17           ` Rafael J. Wysocki
2015-02-26 18:17           ` Boris Brezillon
2015-02-26 18:17             ` Boris Brezillon
2015-02-26 21:55             ` Rafael J. Wysocki
2015-02-26 21:55               ` Rafael J. Wysocki
2015-02-26 23:07             ` [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines Rafael J. Wysocki
2015-02-26 23:07               ` Rafael J. Wysocki
2015-02-27  8:38               ` Peter Zijlstra
2015-02-27  8:38                 ` Peter Zijlstra
2015-02-27 22:13                 ` Rafael J. Wysocki
2015-02-27 22:13                   ` Rafael J. Wysocki
2015-02-27 22:11                   ` Peter Zijlstra
2015-02-27 22:11                     ` Peter Zijlstra
2015-03-04 19:42               ` Mark Rutland
2015-03-04 19:42                 ` Mark Rutland
2015-03-04 20:00                 ` [PATCH] genirq: describe IRQF_COND_SUSPEND Mark Rutland
2015-03-04 20:00                   ` Mark Rutland
2015-03-04 21:55                   ` Rafael J. Wysocki
2015-03-04 21:55                     ` Rafael J. Wysocki
2015-03-04 22:17                   ` Alexandre Belloni
2015-03-04 22:17                     ` Alexandre Belloni
2015-03-04 22:27                     ` Arnd Bergmann
2015-03-04 22:27                       ` Arnd Bergmann
2015-03-05 11:04                     ` Mark Rutland
2015-03-05 11:04                       ` Mark Rutland
2015-03-05 11:33                       ` Alexandre Belloni [this message]
2015-03-05 11:33                         ` Alexandre Belloni
2015-03-05 12:07                         ` Mark Rutland
2015-03-05 12:07                           ` Mark Rutland
2015-03-06  0:54                       ` Rafael J. Wysocki
2015-03-06  0:54                         ` Rafael J. Wysocki
2015-03-04 21:30                 ` [PATCH] genirq / PM: Add flag for shared NO_SUSPEND interrupt lines Rafael J. Wysocki
2015-03-04 21:30                   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150305113306.GP3989@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=peterz@infradead.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.