From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: James Bottomley <jbottomley@parallels.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Hannes Reinecke <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH for kernel 4.1] Split SCSI header files
Date: Thu, 5 Mar 2015 15:26:35 +0100 [thread overview]
Message-ID: <20150305142635.GA17795@lst.de> (raw)
In-Reply-To: <54ED8A71.3050701@sandisk.com>
In general this looks fine, but:
- why do you need a separate scsi_lun.h?
- I'd really prefer to only have the protocol defintion here,
not prototypes for helpers like scsi_device_type, int_to_scsilun
and scsilun_to_int. The target code should not depend on the
initiator for helpers. In the long run we should either duplicate
them, or have a library used by the initiator and target.
next prev parent reply other threads:[~2015-03-05 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 8:40 [PATCH for kernel 4.1] Split SCSI header files Bart Van Assche
2015-02-27 20:17 ` Nicholas A. Bellinger
2015-03-05 14:26 ` Christoph Hellwig [this message]
2015-03-05 14:58 ` Bart Van Assche
2015-03-08 16:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305142635.GA17795@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.