Re: [PATCH for kernel 4.1] Split SCSI header files

[Christoph Hellwig <hch@lst.de>]

On Thu, Mar 05, 2015 at 03:58:47PM +0100, Bart Van Assche wrote:
> Thanks for the review. Whether scsi_lun.h is separate or not is not
> important to me. The only reason I had proposed to create a separate
> header file for struct scsi_lun is because some other header files only
> need the definition of that structure and not any other definition that
> is present in the proposed scsi_proto.h header file.

Given how small and simple scsi_proto.h is that doesn't seem worth it to me.

> Creating a library of functions that are shared by initiator and target
> makes sense to me. Not only the LUN translation functions but also
> functions like scsi_command_size() are useful for both SCSI initiator
> and SCSI target code. If anyone has a suggestion for a good name for
> such a library that would be welcome. Unfortunately there is already a
> source file with the name scsi_lib.c in the kernel tree so using the
> name scsi_lib.h might be confusing.

scsi_common might be a good name for both the module and the header file.