From: Eduardo Habkost <ehabkost@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: zhugh.fnst@cn.fujitsu.com, qemu-devel@nongnu.org,
tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com,
Paolo Bonzini <pbonzini@redhat.com>,
anshul.makkar@profitbricks.com,
Gu Zheng <guz.fnst@cn.fujitsu.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize
Date: Thu, 5 Mar 2015 13:48:35 -0300 [thread overview]
Message-ID: <20150305164835.GF13041@thinpad.lan.raisama.net> (raw)
In-Reply-To: <54F8880A.6050908@suse.de>
On Thu, Mar 05, 2015 at 05:44:58PM +0100, Andreas Färber wrote:
> Am 05.03.2015 um 17:42 schrieb Igor Mammedov:
[...]
> >> @@ -2840,7 +2842,6 @@ static void x86_cpu_initfn(Object *obj)
> >> CPUX86State *env = &cpu->env;
> >>
> >> cs->env_ptr = env;
> >> - cpu_exec_init(env);
> > looks wrong, later in this function we do
> > env->cpuid_apic_id = x86_cpu_apic_id_from_index(cs->cpu_index);
> > and with this patch will always yield 0
>
> Being tackled in Eduardo's APIC series. ;)
Which is already queued at the x86 tree mentioned in the cover letter,
BTW:
https://github.com/ehabkost/qemu.git x86
--
Eduardo
next prev parent reply other threads:[~2015-03-05 20:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 15:38 [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init Eduardo Habkost
2015-03-05 15:38 ` [Qemu-devel] [PATCH 1/6] cpu: No need to zero-initialize numa_node Eduardo Habkost
2015-03-05 16:13 ` Igor Mammedov
2015-03-05 15:38 ` [Qemu-devel] [PATCH 2/6] cpu: Initialize breakpoint/watchpoint lists on cpu_common_initfn() Eduardo Habkost
2015-03-05 16:15 ` Igor Mammedov
2015-03-05 15:38 ` [Qemu-devel] [PATCH 3/6] cpu: Reorder cpu->as and cpu->thread_id initialization Eduardo Habkost
2015-03-05 16:22 ` Igor Mammedov
2015-03-05 15:38 ` [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init() Eduardo Habkost
2015-03-05 16:31 ` Igor Mammedov
2015-03-05 16:38 ` Eduardo Habkost
2015-03-05 15:38 ` [Qemu-devel] [PATCH 5/6] target-i386: Move TCG initialization to realize time Eduardo Habkost
2015-03-05 15:38 ` [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize Eduardo Habkost
2015-03-05 16:42 ` Igor Mammedov
2015-03-05 16:44 ` Andreas Färber
2015-03-05 16:48 ` Eduardo Habkost [this message]
2015-03-05 16:52 ` [Qemu-devel] [PATCH 0/6] target-i386: Remove side-effects from X86CPU::instance_init Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305164835.GF13041@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=anshul.makkar@profitbricks.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tangchen@cn.fujitsu.com \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.