From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Cc: "jroedel-l3A5Bk7waGM@public.gmane.org"
<jroedel-l3A5Bk7waGM@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
<Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org"
<dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/2] iommu: move pgsize_bitmap from struct iommu_ops to struct iommu_domain
Date: Fri, 6 Mar 2015 11:59:10 +0000 [thread overview]
Message-ID: <20150306115909.GJ22377@arm.com> (raw)
In-Reply-To: <3242222.7VyhtFfsx7@avalon>
On Fri, Mar 06, 2015 at 11:56:08AM +0000, Laurent Pinchart wrote:
> Hi Will,
Hi Laurent,
Cheers for taking a look.
> On Friday 06 March 2015 11:34:47 Will Deacon wrote:
> > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> > index 10186cac7716..cd867b255b99 100644
> > --- a/drivers/iommu/ipmmu-vmsa.c
> > +++ b/drivers/iommu/ipmmu-vmsa.c
> > @@ -469,6 +469,7 @@ static int ipmmu_domain_init(struct iommu_domain
> > *io_domain)
> >
> > io_domain->priv = domain;
> > domain->io_domain = io_domain;
> > + domain->pgsize_bitmap = SZ_2M | SZ_64K | SZ_4K;
>
> You're changing the bitmap, was it intended ?
Yikes, no, sorry about that. It looks like this is due to a bad rebase (I
build tested everything, but don't have an ipmmu-vmsa to run on). You
changed the bitmap in f20ed39f531 when you moved to the generic allocator
and I didn't pick up the change here. Will fix.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] iommu: move pgsize_bitmap from struct iommu_ops to struct iommu_domain
Date: Fri, 6 Mar 2015 11:59:10 +0000 [thread overview]
Message-ID: <20150306115909.GJ22377@arm.com> (raw)
In-Reply-To: <3242222.7VyhtFfsx7@avalon>
On Fri, Mar 06, 2015 at 11:56:08AM +0000, Laurent Pinchart wrote:
> Hi Will,
Hi Laurent,
Cheers for taking a look.
> On Friday 06 March 2015 11:34:47 Will Deacon wrote:
> > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> > index 10186cac7716..cd867b255b99 100644
> > --- a/drivers/iommu/ipmmu-vmsa.c
> > +++ b/drivers/iommu/ipmmu-vmsa.c
> > @@ -469,6 +469,7 @@ static int ipmmu_domain_init(struct iommu_domain
> > *io_domain)
> >
> > io_domain->priv = domain;
> > domain->io_domain = io_domain;
> > + domain->pgsize_bitmap = SZ_2M | SZ_64K | SZ_4K;
>
> You're changing the bitmap, was it intended ?
Yikes, no, sorry about that. It looks like this is due to a bad rebase (I
build tested everything, but don't have an ipmmu-vmsa to run on). You
changed the bitmap in f20ed39f531 when you moved to the generic allocator
and I didn't pick up the change here. Will fix.
Will
next prev parent reply other threads:[~2015-03-06 11:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 11:34 [PATCH 0/2] Kill off pgsize_bitmap field from struct iommu_ops Will Deacon
2015-03-06 11:34 ` Will Deacon
[not found] ` <1425641688-26438-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2015-03-06 11:34 ` [PATCH 1/2] iommu: move pgsize_bitmap from struct iommu_ops to struct iommu_domain Will Deacon
2015-03-06 11:34 ` Will Deacon
[not found] ` <1425641688-26438-2-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2015-03-06 11:56 ` Laurent Pinchart
2015-03-06 11:56 ` Laurent Pinchart
2015-03-06 11:59 ` Will Deacon [this message]
2015-03-06 11:59 ` Will Deacon
2015-03-06 11:57 ` Laurent Pinchart
2015-03-06 11:57 ` Laurent Pinchart
2015-03-06 12:34 ` Will Deacon
2015-03-06 12:34 ` Will Deacon
2015-03-06 12:24 ` Marek Szyprowski
2015-03-06 12:24 ` Marek Szyprowski
2015-03-07 16:17 ` Daniel Kurtz
2015-03-11 8:38 ` Thierry Reding
2015-03-11 8:38 ` Thierry Reding
2015-03-06 11:34 ` [PATCH 2/2] iommu: of: enforce const-ness of struct iommu_ops Will Deacon
2015-03-06 11:34 ` Will Deacon
[not found] ` <1425641688-26438-3-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2015-03-11 8:43 ` Thierry Reding
2015-03-11 8:43 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306115909.GJ22377@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.