Re: [PATCH] bitbake: fetch2: Revalidate checksums, YOCTO #5571

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On Fri, Mar 06, 2015 at 12:43:28PM +0100, Clemens Lang wrote:
> Hello,
> 
> On Fri, Feb 27, 2015 at 01:00:26PM +0100, Clemens Lang wrote:
> > Here's the patch, please review and consider applying:
> 
> Any feedback on this? Anything I can do to get this reviewed?

FWIW: I like this, we were hit by this issue when the archive is
modified in premirror and builders are happily using it, because there
is .done file next to it.

This will at least fix the case when the file is intentionally modified
and checksums are updated in recipe to prevent re-using stalled file
from some premirror.

Using pickle is much better than counting the checksums on every
do_fetch.. we have GBs of sources and we don't want to spend extra
minutes on the build to re-check them if they are identical. Maybe add
the file time stamp as well, if the file was modified then .done could
be invalidated and checksums re-verified.

Regards,
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]