Re: [PATCH] bitbake: fetch2: Revalidate checksums, YOCTO #5571

[Alejandro Hernandez <alejandro.hernandez@linux.intel.com>]

Hi Clemens,

On 23/02/15 08:22, Clemens Lang wrote:

This is the problem I see, I am not sure we want to import extra 
libraries here, as you state the use of pickle might be ok since it 
avoids the overhead of calculating the checksums each time, but I don't 
know if it is actually worth it, since checksums are calculated fairly 
quick anyway, this is my personal opinion, you may still submit it for 
review.
>   
> +try:
> +    import cPickle as pickle
> +except ImportError:
> +    import pickle
> +    logger.info("Importing cPickle failed. "
> +                "Falling back to a very slow implementation.")
> +
>
On 26/02/15 08:42, Clemens Lang wrote:
> Hi,
>
> On Mon, Feb 23, 2015 at 03:22:43PM +0100, Clemens Lang wrote:
>> [YOCTO #5571] -- https://bugzilla.yoctoproject.org/show_bug.cgi?id=5571
> Can somebody review this? Is there anything I need to do to get this
> considered for merging?
And perhaps the reason it hasn't been reviewed is that I believe this 
patch should go to bitbake-devel@lists.openembedded.org instead.

I also had this WIP branch on contrib, its from a couple of months back 
its "dirty" but in case you'd like to look around.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=hsalejandro/5571&id=2f59e26e534dc6b6d4c5bb8d78c574042e0fe7a7