All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: "Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"Paul Walmsley" <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>,
	"Herbert Xu"
	<herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Pavel Machek" <pavel-+ZI9xUNit7I@public.gmane.org>,
	"Nishanth Menon" <nm-l0cyMroinI0@public.gmane.org>,
	"Ivaylo Dimitrov"
	<ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Aaro Koskinen" <aaro.koskinen-X3B1VOXEql0@public.gmane.org>,
	"Sebastian Reichel" <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 00/10] omap3 crypto fixes
Date: Fri, 6 Mar 2015 20:16:05 +0100	[thread overview]
Message-ID: <201503062016.05608@pali> (raw)
In-Reply-To: <20150306183631.GA13520-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

[-- Attachment #1: Type: Text/Plain, Size: 2220 bytes --]

On Friday 06 March 2015 19:36:32 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [150226 05:54]:
> > This patch series fix crypto support for omap3 devices which
> > use DT.
> > 
> > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is
> > still disabled for N900.
> > 
> > Pali Rohár (10):
> >   ARM: OMAP2+: Return correct error values from device and
> >   hwmod ARM: OMAP3: Fix crypto support for HS devices
> >   crypto: omap-sham: Add support for omap3 devices
> >   crypto: omap-sham: Check for return value from
> >   pm_runtime_get_sync ARM: dts: omap3 hs: Remove timer12
> >   ARM: dts: omap3: Add missing dmas for crypto
> >   ARM: dts: n9/n950: Enable omap crypto support
> >   ARM: dts: n900: Enable omap sham and include directly
> >   omap34xx.dtsi ARM: dts: omap3-tao3530: Include directly
> >   omap34xx.dtsi ARM: dts: Remove files omap34xx-hs.dtsi and
> >   omap36xx-hs.dtsi
> >  
> >  arch/arm/boot/dts/omap3-n900.dts           |   16 +++++-
> >  arch/arm/boot/dts/omap3-n950-n9.dtsi       |    2 +-
> >  arch/arm/boot/dts/omap3-tao3530.dtsi       |   11 +++-
> >  arch/arm/boot/dts/omap3.dtsi               |    4 ++
> >  arch/arm/boot/dts/omap34xx-hs.dtsi         |   16 ------
> >  arch/arm/boot/dts/omap36xx-hs.dtsi         |   16 ------
> >  arch/arm/mach-omap2/omap_device.c          |   30
> >  ++++++----- arch/arm/mach-omap2/omap_hwmod.c           |  
> >  10 ++-- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   79
> >  +++++++++++++++++++++++----- drivers/crypto/omap-sham.c   
> >               |   13 ++++- 10 files changed, 131
> >  insertions(+), 66 deletions(-) delete mode 100644
> >  arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100644
> >  arch/arm/boot/dts/omap36xx-hs.dtsi
> 
> Are there any fixes in this series that should go into
> v4.0-rc series, or can it all wait for v4.1?
> 
> Regards,
> 
> Tony

I do not know which patches are you sending to 4.0-rc series, but 
omap crypto is totally broken in linus tree for both GP & HS 
omap3 devices when DT booting is used. This patch series fix that 
problem.

-- 
Pali Rohár
pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Paul Walmsley" <paul@pwsan.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	"Pavel Machek" <pavel@ucw.cz>, "Nishanth Menon" <nm@ti.com>,
	"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Sebastian Reichel" <sre@kernel.org>
Subject: Re: [PATCH 00/10] omap3 crypto fixes
Date: Fri, 6 Mar 2015 20:16:05 +0100	[thread overview]
Message-ID: <201503062016.05608@pali> (raw)
In-Reply-To: <20150306183631.GA13520@atomide.com>

[-- Attachment #1: Type: Text/Plain, Size: 2160 bytes --]

On Friday 06 March 2015 19:36:32 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [150226 05:54]:
> > This patch series fix crypto support for omap3 devices which
> > use DT.
> > 
> > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is
> > still disabled for N900.
> > 
> > Pali Rohár (10):
> >   ARM: OMAP2+: Return correct error values from device and
> >   hwmod ARM: OMAP3: Fix crypto support for HS devices
> >   crypto: omap-sham: Add support for omap3 devices
> >   crypto: omap-sham: Check for return value from
> >   pm_runtime_get_sync ARM: dts: omap3 hs: Remove timer12
> >   ARM: dts: omap3: Add missing dmas for crypto
> >   ARM: dts: n9/n950: Enable omap crypto support
> >   ARM: dts: n900: Enable omap sham and include directly
> >   omap34xx.dtsi ARM: dts: omap3-tao3530: Include directly
> >   omap34xx.dtsi ARM: dts: Remove files omap34xx-hs.dtsi and
> >   omap36xx-hs.dtsi
> >  
> >  arch/arm/boot/dts/omap3-n900.dts           |   16 +++++-
> >  arch/arm/boot/dts/omap3-n950-n9.dtsi       |    2 +-
> >  arch/arm/boot/dts/omap3-tao3530.dtsi       |   11 +++-
> >  arch/arm/boot/dts/omap3.dtsi               |    4 ++
> >  arch/arm/boot/dts/omap34xx-hs.dtsi         |   16 ------
> >  arch/arm/boot/dts/omap36xx-hs.dtsi         |   16 ------
> >  arch/arm/mach-omap2/omap_device.c          |   30
> >  ++++++----- arch/arm/mach-omap2/omap_hwmod.c           |  
> >  10 ++-- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |   79
> >  +++++++++++++++++++++++----- drivers/crypto/omap-sham.c   
> >               |   13 ++++- 10 files changed, 131
> >  insertions(+), 66 deletions(-) delete mode 100644
> >  arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100644
> >  arch/arm/boot/dts/omap36xx-hs.dtsi
> 
> Are there any fixes in this series that should go into
> v4.0-rc series, or can it all wait for v4.1?
> 
> Regards,
> 
> Tony

I do not know which patches are you sending to 4.0-rc series, but 
omap crypto is totally broken in linus tree for both GP & HS 
omap3 devices when DT booting is used. This patch series fix that 
problem.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2015-03-06 19:16 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 13:49 [PATCH 00/10] omap3 crypto fixes Pali Rohár
2015-02-26 13:49 ` [PATCH 01/10] ARM: OMAP2+: Return correct error values from device and hwmod Pali Rohár
2015-05-21 11:44   ` Pali Rohár
2015-02-26 13:49 ` [PATCH 02/10] ARM: OMAP3: Fix crypto support for HS devices Pali Rohár
2015-02-28 16:24   ` Pavel Machek
2015-05-26 10:54     ` Pali Rohár
2015-05-26 10:54       ` Pali Rohár
2015-06-02 18:36       ` Paul Walmsley
2015-02-26 13:49 ` [PATCH 03/10] crypto: omap-sham: Add support for omap3 devices Pali Rohár
     [not found]   ` <1424958600-18881-4-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-28 16:25     ` Pavel Machek
2015-02-28 16:25       ` Pavel Machek
2015-05-15  9:19       ` Pali Rohár
2015-05-15  9:19         ` Pali Rohár
2015-05-18  4:30         ` Herbert Xu
2015-05-18  4:30           ` Herbert Xu
2015-02-26 13:49 ` [PATCH 04/10] crypto: omap-sham: Check for return value from pm_runtime_get_sync Pali Rohár
2015-02-28 16:39   ` Pavel Machek
2015-03-08 10:01   ` [PATCH v2] " Pali Rohár
2015-03-09 20:52     ` Pavel Machek
2015-05-14 21:40     ` Pali Rohár
2015-05-15  0:15       ` Herbert Xu
2015-05-15  7:02       ` Herbert Xu
2015-05-15  9:20         ` Pali Rohár
2015-02-26 13:49 ` [PATCH 05/10] ARM: dts: omap3 hs: Remove timer12 Pali Rohár
2015-02-28 16:54   ` Pavel Machek
2015-02-26 13:49 ` [PATCH 06/10] ARM: dts: omap3: Add missing dmas for crypto Pali Rohár
     [not found]   ` <1424958600-18881-7-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-28 16:46     ` Pavel Machek
2015-02-28 16:46       ` Pavel Machek
2015-03-16 21:44       ` Tony Lindgren
2015-02-26 13:49 ` [PATCH 07/10] ARM: dts: n9/n950: Enable omap crypto support Pali Rohár
2015-02-26 13:49   ` Pali Rohár
2015-02-27 15:43   ` Tony Lindgren
2015-02-27 16:01     ` Pali Rohár
2015-02-27 16:10       ` Tony Lindgren
2015-02-27 16:10         ` Tony Lindgren
2015-02-28 16:41   ` Pavel Machek
2015-03-19 16:43     ` Tony Lindgren
2015-03-19 16:43       ` Tony Lindgren
2015-02-26 13:49 ` [PATCH 08/10] ARM: dts: n900: Enable omap sham and include directly omap34xx.dtsi Pali Rohár
2015-02-28 16:44   ` Pavel Machek
2015-02-26 13:49 ` [PATCH 09/10] ARM: dts: omap3-tao3530: Include " Pali Rohár
2015-02-28 16:44   ` Pavel Machek
2015-02-26 13:50 ` [PATCH 10/10] ARM: dts: Remove files omap34xx-hs.dtsi and omap36xx-hs.dtsi Pali Rohár
     [not found]   ` <1424958600-18881-11-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-28 16:45     ` Pavel Machek
2015-02-28 16:45       ` Pavel Machek
2015-02-26 22:46 ` [PATCH 00/10] omap3 crypto fixes Aaro Koskinen
2015-02-27 12:40   ` Pali Rohár
2015-03-07 23:19     ` Aaro Koskinen
2015-03-07 23:19       ` Aaro Koskinen
2015-03-06 18:36 ` Tony Lindgren
2015-03-06 18:36   ` Tony Lindgren
     [not found]   ` <20150306183631.GA13520-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-03-06 19:16     ` Pali Rohár [this message]
2015-03-06 19:16       ` Pali Rohár
2015-03-06 19:18       ` Tony Lindgren
2015-03-06 22:23   ` Aaro Koskinen
     [not found]     ` <20150306222306.GB587-+UqvGBo8NkiJ/SmVcN9c7yH8jP4CeeTLqBW4ids5wwA@public.gmane.org>
2015-03-08 10:01       ` Pali Rohár
2015-03-08 10:01         ` Pali Rohár
2015-03-08 16:35         ` Paul Walmsley
2015-03-08 16:35           ` Paul Walmsley
2015-03-15  9:59           ` Pali Rohár
2015-05-14 21:17     ` Pali Rohár
2015-05-14 21:34       ` Tony Lindgren
     [not found]         ` <20150514213418.GP15563-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-05-14 21:39           ` Pali Rohár
2015-05-14 21:39             ` Pali Rohár
2015-05-14 22:03             ` Tony Lindgren
2015-05-14 22:03               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201503062016.05608@pali \
    --to=pali.rohar-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
    --cc=ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nm-l0cyMroinI0@public.gmane.org \
    --cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
    --cc=pavel-+ZI9xUNit7I@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.