Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: pr_warn instead printk

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Mar 05, 2015 at 08:01:20PM +0200, Hatice ERT�RK wrote:
> This patch fixes the following warning using checkpatch.pl
> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
> dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index ff6b212..ecd8542 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -197,7 +197,7 @@ int ieee80211_encrypt_fragment(
>  			struct ieee80211_hdr_3addrqos *header;
>  
>  			header = (struct ieee80211_hdr_3addrqos *)frag->data;
> -			pr_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "
> +			dev_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "

This obviously will not even build.

Please test all of your patches, to not do so can cause a lot of time
being wasted by others.

thanks,

greg k-h