* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: pr_warn instead printk
2015-03-05 17:34 Hatice ERTÜRK
@ 2015-03-05 17:45 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2015-03-05 17:45 UTC (permalink / raw)
To: Hatice ERTÜRK; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 3850 bytes --]
On Thu, 5 Mar 2015, Hatice ERTÜRK wrote:
> This patch fixes the following warning using checkpatch.pl
> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
> dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
This is a network driver. In at least most of the cases it should be
possible to use the netdev functions.
julia
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index 96ab304..ff6b212 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -197,7 +197,7 @@ int ieee80211_encrypt_fragment(
> struct ieee80211_hdr_3addrqos *header;
>
> header = (struct ieee80211_hdr_3addrqos *)frag->data;
> - printk(KERN_DEBUG "%s: TKIP countermeasures: dropped "
> + pr_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "
> "TX packet to %pM\n",
> ieee->dev->name, header->addr1);
> }
> @@ -219,7 +219,7 @@ int ieee80211_encrypt_fragment(
>
> atomic_dec(&crypt->refcnt);
> if (res < 0) {
> - printk(KERN_INFO "%s: Encryption failed: len=%d.\n",
> + pr_info(KERN_INFO "%s: Encryption failed: len=%d.\n",
> ieee->dev->name, frag->len);
> ieee->ieee_stats.tx_discards++;
> return -1;
> @@ -623,7 +623,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
> * creating it... */
> if ((!ieee->hard_start_xmit && !(ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE))||
> ((!ieee->softmac_data_hard_start_xmit && (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> - printk(KERN_WARNING "%s: No xmit handler.\n",
> + pr_warn(KERN_WARNING "%s: No xmit handler.\n",
> ieee->dev->name);
> goto success;
> }
> @@ -631,7 +631,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
>
> if(likely(ieee->raw_tx == 0)){
> if (unlikely(skb->len < SNAP_SIZE + sizeof(u16))) {
> - printk(KERN_WARNING "%s: skb too small (%d).\n",
> + pr_warn(KERN_WARNING "%s: skb too small (%d).\n",
> ieee->dev->name, skb->len);
> goto success;
> }
> @@ -747,7 +747,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
> * postfix, header, FCS, etc.) */
> txb = ieee80211_alloc_txb(nr_frags, frag_size + ieee->tx_headroom, GFP_ATOMIC);
> if (unlikely(!txb)) {
> - printk(KERN_WARNING "%s: Could not allocate TXB\n",
> + pr_warn(KERN_WARNING "%s: Could not allocate TXB\n",
> ieee->dev->name);
> goto failed;
> }
> @@ -846,14 +846,14 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
> }
> }else{
> if (unlikely(skb->len < sizeof(struct ieee80211_hdr_3addr))) {
> - printk(KERN_WARNING "%s: skb too small (%d).\n",
> + pr_warn(KERN_WARNING "%s: skb too small (%d).\n",
> ieee->dev->name, skb->len);
> goto success;
> }
>
> txb = ieee80211_alloc_txb(1, skb->len, GFP_ATOMIC);
> if(!txb){
> - printk(KERN_WARNING "%s: Could not allocate TXB\n",
> + pr_warn(KERN_WARNING "%s: Could not allocate TXB\n",
> ieee->dev->name);
> goto failed;
> }
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425576898-6611-1-git-send-email-haticeerturk27%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Staging: rtl8192u: ieee80211: pr_warn instead printk
@ 2015-03-05 18:01 Hatice ERTÜRK
2015-03-06 23:51 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Hatice ERTÜRK @ 2015-03-05 18:01 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Hatice ERTURK
This patch fixes the following warning using checkpatch.pl
WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
index ff6b212..ecd8542 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
@@ -197,7 +197,7 @@ int ieee80211_encrypt_fragment(
struct ieee80211_hdr_3addrqos *header;
header = (struct ieee80211_hdr_3addrqos *)frag->data;
- pr_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "
+ dev_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "
"TX packet to %pM\n",
ieee->dev->name, header->addr1);
}
@@ -219,7 +219,7 @@ int ieee80211_encrypt_fragment(
atomic_dec(&crypt->refcnt);
if (res < 0) {
- pr_info(KERN_INFO "%s: Encryption failed: len=%d.\n",
+ dev_info(KERN_INFO "%s: Encryption failed: len=%d.\n",
ieee->dev->name, frag->len);
ieee->ieee_stats.tx_discards++;
return -1;
@@ -623,7 +623,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
* creating it... */
if ((!ieee->hard_start_xmit && !(ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE))||
((!ieee->softmac_data_hard_start_xmit && (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
- pr_warn(KERN_WARNING "%s: No xmit handler.\n",
+ dev_warn(KERN_WARNING "%s: No xmit handler.\n",
ieee->dev->name);
goto success;
}
@@ -631,7 +631,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
if(likely(ieee->raw_tx == 0)){
if (unlikely(skb->len < SNAP_SIZE + sizeof(u16))) {
- pr_warn(KERN_WARNING "%s: skb too small (%d).\n",
+ dev_warn(KERN_WARNING "%s: skb too small (%d).\n",
ieee->dev->name, skb->len);
goto success;
}
@@ -747,7 +747,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
* postfix, header, FCS, etc.) */
txb = ieee80211_alloc_txb(nr_frags, frag_size + ieee->tx_headroom, GFP_ATOMIC);
if (unlikely(!txb)) {
- pr_warn(KERN_WARNING "%s: Could not allocate TXB\n",
+ dev_warn(KERN_WARNING "%s: Could not allocate TXB\n",
ieee->dev->name);
goto failed;
}
@@ -846,14 +846,14 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev)
}
}else{
if (unlikely(skb->len < sizeof(struct ieee80211_hdr_3addr))) {
- pr_warn(KERN_WARNING "%s: skb too small (%d).\n",
+ dev_warn(KERN_WARNING "%s: skb too small (%d).\n",
ieee->dev->name, skb->len);
goto success;
}
txb = ieee80211_alloc_txb(1, skb->len, GFP_ATOMIC);
if(!txb){
- pr_warn(KERN_WARNING "%s: Could not allocate TXB\n",
+ dev_warn(KERN_WARNING "%s: Could not allocate TXB\n",
ieee->dev->name);
goto failed;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: pr_warn instead printk
2015-03-05 18:01 [PATCH] Staging: rtl8192u: ieee80211: pr_warn instead printk Hatice ERTÜRK
@ 2015-03-06 23:51 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-03-06 23:51 UTC (permalink / raw)
To: Hatice ERTÜRK; +Cc: outreachy-kernel
On Thu, Mar 05, 2015 at 08:01:20PM +0200, Hatice ERT�RK wrote:
> This patch fixes the following warning using checkpatch.pl
> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
> dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
>
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index ff6b212..ecd8542 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -197,7 +197,7 @@ int ieee80211_encrypt_fragment(
> struct ieee80211_hdr_3addrqos *header;
>
> header = (struct ieee80211_hdr_3addrqos *)frag->data;
> - pr_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "
> + dev_debug(KERN_DEBUG "%s: TKIP countermeasures: dropped "
This obviously will not even build.
Please test all of your patches, to not do so can cause a lot of time
being wasted by others.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-07 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-05 18:01 [PATCH] Staging: rtl8192u: ieee80211: pr_warn instead printk Hatice ERTÜRK
2015-03-06 23:51 ` [Outreachy kernel] " Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-03-05 17:34 Hatice ERTÜRK
2015-03-05 17:45 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.