* [PATCH] staging: dgnc: Use setup_timer
@ 2015-02-08 7:14 Vaishali Thakkar
2015-03-07 0:12 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Vaishali Thakkar @ 2015-02-08 7:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Lidza Louina, Mark Hounschell, Daeseok Youn, linux-kernel
This patch introduces the use of function setup_timer.
This is done using Coccinelle and semantic patch used is
as follows:
@@
expression x,y,z;
@@
- init_timer (&x);
+ setup_timer (&x, y, z);
- x.function = y;
- x.data = z;
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index f610ae1..95f47f7 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -285,9 +285,7 @@ static int dgnc_start(void)
/* Start the poller */
spin_lock_irqsave(&dgnc_poll_lock, flags);
- init_timer(&dgnc_poll_timer);
- dgnc_poll_timer.function = dgnc_poll_handler;
- dgnc_poll_timer.data = 0;
+ setup_timer(&dgnc_poll_timer, dgnc_poll_handler, 0);
dgnc_poll_time = jiffies + dgnc_jiffies_from_ms(dgnc_poll_tick);
dgnc_poll_timer.expires = dgnc_poll_time;
spin_unlock_irqrestore(&dgnc_poll_lock, flags);
@@ -731,9 +729,7 @@ static void dgnc_poll_handler(ulong dummy)
if ((ulong) new_time >= 2 * dgnc_poll_tick)
dgnc_poll_time = jiffies + dgnc_jiffies_from_ms(dgnc_poll_tick);
- init_timer(&dgnc_poll_timer);
- dgnc_poll_timer.function = dgnc_poll_handler;
- dgnc_poll_timer.data = 0;
+ setup_timer(&dgnc_poll_timer, dgnc_poll_handler, 0);
dgnc_poll_timer.expires = dgnc_poll_time;
spin_unlock_irqrestore(&dgnc_poll_lock, flags);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: dgnc: Use setup_timer
2015-02-08 7:14 [PATCH] staging: dgnc: Use setup_timer Vaishali Thakkar
@ 2015-03-07 0:12 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2015-03-07 0:12 UTC (permalink / raw)
To: Vaishali Thakkar
Cc: Lidza Louina, Mark Hounschell, Daeseok Youn, linux-kernel
On Sun, Feb 08, 2015 at 12:44:40PM +0530, Vaishali Thakkar wrote:
> This patch introduces the use of function setup_timer.
>
> This is done using Coccinelle and semantic patch used is
> as follows:
>
> @@
> expression x,y,z;
> @@
>
> - init_timer (&x);
> + setup_timer (&x, y, z);
> - x.function = y;
> - x.data = z;
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
This is already in my tree :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-07 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 7:14 [PATCH] staging: dgnc: Use setup_timer Vaishali Thakkar
2015-03-07 0:12 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.