All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include
@ 2015-02-21  2:14 Tolga Ceylan
  2015-02-21  2:14 ` [PATCH 2/3] Staging: rtl8192u: ieee80211: dot11d: added parenthesis to RESET_CIE_WATCHDOG macro Tolga Ceylan
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Tolga Ceylan @ 2015-02-21  2:14 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, linux-kernel, tolga.ceylan

Removed a commented out header include

Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 5533221..b41aec1 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -11,7 +11,6 @@
  *
  */
 
-//#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
-- 
2.3.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] Staging: rtl8192u: ieee80211: dot11d: added parenthesis to RESET_CIE_WATCHDOG macro
  2015-02-21  2:14 [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include Tolga Ceylan
@ 2015-02-21  2:14 ` Tolga Ceylan
  2015-02-21  2:14 ` [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89 Tolga Ceylan
  2015-03-07  0:58 ` [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include Greg Kroah-Hartman
  2 siblings, 0 replies; 5+ messages in thread
From: Tolga Ceylan @ 2015-02-21  2:14 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, linux-kernel, tolga.ceylan

Added parenthesis to RESET_CIE_WATCHDOG macro to resolve checkpatch
error.

Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index bd75e29..8ae673b 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.h
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.h
@@ -53,7 +53,7 @@ typedef struct _RT_DOT11D_INFO {
 
 #define CIE_WATCHDOG_TH 1
 #define GET_CIE_WATCHDOG(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->CountryIeWatchdog)
-#define RESET_CIE_WATCHDOG(__pIeeeDev) GET_CIE_WATCHDOG(__pIeeeDev) = 0
+#define RESET_CIE_WATCHDOG(__pIeeeDev) (GET_CIE_WATCHDOG(__pIeeeDev) = 0)
 #define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev))
 
 #define IS_DOT11D_STATE_DONE(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->State == DOT11D_STATE_DONE)
-- 
2.3.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89
  2015-02-21  2:14 [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include Tolga Ceylan
  2015-02-21  2:14 ` [PATCH 2/3] Staging: rtl8192u: ieee80211: dot11d: added parenthesis to RESET_CIE_WATCHDOG macro Tolga Ceylan
@ 2015-02-21  2:14 ` Tolga Ceylan
  2015-03-07  0:59   ` Greg Kroah-Hartman
  2015-03-07  0:58 ` [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include Greg Kroah-Hartman
  2 siblings, 1 reply; 5+ messages in thread
From: Tolga Ceylan @ 2015-02-21  2:14 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, linux-kernel, tolga.ceylan

Replaced C99 comments with C89 while maintaining less than 80 char lines.
Removed commented out struct member: DLRecord.

Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
index 7ed7243..811e6e3 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
@@ -1,14 +1,14 @@
 #ifndef _TSTYPE_H_
 #define _TSTYPE_H_
 #include "rtl819x_Qos.h"
-#define TS_SETUP_TIMEOUT	60  // In millisecond
+#define TS_SETUP_TIMEOUT	60  /* In millisecond */
 #define TS_INACT_TIMEOUT	60
 #define TS_ADDBA_DELAY		60
 
 #define TOTAL_TS_NUM		16
 #define TCLAS_NUM		4
 
-// This define the Tx/Rx directions
+/* This define the Tx/Rx directions */
 typedef enum _TR_SELECT {
 	TX_DIR = 0,
 	RX_DIR = 1,
@@ -28,9 +28,10 @@ typedef struct _TS_COMMON_INFO{
 typedef struct _TX_TS_RECORD{
 	TS_COMMON_INFO		TsCommonInfo;
 	u16				TxCurSeq;
-	BA_RECORD			TxPendingBARecord;	// For BA Originator
-	BA_RECORD			TxAdmittedBARecord;	// For BA Originator
-//	QOS_DL_RECORD		DLRecord;
+	/* For BA Originator */
+	BA_RECORD			TxPendingBARecord;
+	/* For BA Originator */
+	BA_RECORD			TxAdmittedBARecord;
 	u8				bAddBaReqInProgress;
 	u8				bAddBaReqDelayed;
 	u8				bUsingBa;
@@ -44,11 +45,11 @@ typedef struct _RX_TS_RECORD {
 	u16				RxTimeoutIndicateSeq;
 	struct list_head		RxPendingPktList;
 	struct timer_list		RxPktPendingTimer;
-	BA_RECORD			RxAdmittedBARecord;	 // For BA Recipient
+	/* For BA Recipient */
+	BA_RECORD			RxAdmittedBARecord;
 	u16				RxLastSeqNum;
 	u8				RxLastFragNum;
 	u8				num;
-//	QOS_DL_RECORD		DLRecord;
 } RX_TS_RECORD, *PRX_TS_RECORD;
 
 
-- 
2.3.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include
  2015-02-21  2:14 [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include Tolga Ceylan
  2015-02-21  2:14 ` [PATCH 2/3] Staging: rtl8192u: ieee80211: dot11d: added parenthesis to RESET_CIE_WATCHDOG macro Tolga Ceylan
  2015-02-21  2:14 ` [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89 Tolga Ceylan
@ 2015-03-07  0:58 ` Greg Kroah-Hartman
  2 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-03-07  0:58 UTC (permalink / raw)
  To: Tolga Ceylan; +Cc: devel, linux-kernel

On Fri, Feb 20, 2015 at 06:14:23PM -0800, Tolga Ceylan wrote:
> Removed a commented out header include
> 
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 1 -
>  1 file changed, 1 deletion(-)

Doesn't apply to my tree :(

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89
  2015-02-21  2:14 ` [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89 Tolga Ceylan
@ 2015-03-07  0:59   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-03-07  0:59 UTC (permalink / raw)
  To: Tolga Ceylan; +Cc: devel, linux-kernel

On Fri, Feb 20, 2015 at 06:14:25PM -0800, Tolga Ceylan wrote:
> Replaced C99 comments with C89 while maintaining less than 80 char lines.
> Removed commented out struct member: DLRecord.
> 
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)

Also doesn't apply :(

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-03-07 11:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-21  2:14 [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include Tolga Ceylan
2015-02-21  2:14 ` [PATCH 2/3] Staging: rtl8192u: ieee80211: dot11d: added parenthesis to RESET_CIE_WATCHDOG macro Tolga Ceylan
2015-02-21  2:14 ` [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89 Tolga Ceylan
2015-03-07  0:59   ` Greg Kroah-Hartman
2015-03-07  0:58 ` [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.