All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang Haoyu" <zhanghy@sangfor.com.cn>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	vsementsov <vsementsov@parallels.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, jsnow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to trackdirty sector
Date: Tue, 10 Mar 2015 09:30:53 +0800	[thread overview]
Message-ID: <201503100930531293894@sangfor.com.cn> (raw)
In-Reply-To: 201503091614373394821@sangfor.com.cn


On 2015-03-10 08:29:19, Fam Zheng wrote:
> On Mon, 03/09 16:14, Zhang Haoyu wrote:
> > Hi John, Vladimir 
> > We can using active block commit to implement incremental backup without guest disruption,
> > e.g., 
> > origin <= A <= B <= C <= current BDS,
> > a new external snapshot will be produced before every time backup,
> > we can migrate A, B, C, ... to destination, 
> > then commit_active_start() the unneeded snapshot in source or destination end.
> > 
> > So, comparing with above mechanism,
> > what's the advantages of the incremental backup implemented by John and Vladimir?
> 
> We can't migrate A, B, C because they are buried in the backing chain under
> "current BDS". 
I think we can backup the incremental image(e.g., A, B, C) to destination in top mode,
although I haven't read the code in detail, it can work theoretically, I think.

> Even if we do that, there will be severe IO amplification
> compared to the dirty bitmap way.
> 
Yes, block-commit will produce extra IO.
But regarding incremental backup, when guest IO is performed, 
will the corresponding dirty bit be synchronized to qcow2 image simultaneously?
If yes, it will impact on IO throughput in two sides, I think,
1) extro IO  2) randomize the IO,
if no, if source VM is shut-down in non-normal way, like killed by force or by mistake or server poweroff suddenly,
some dirty bits maybe lost, then full copy is needed.

> For the same reason we have drive-backup (write intercept) instead of a
> "snapshot + drive-mirror" analogue.
> 
drive-backup is not incremental backup, full copy is needed in every time backup,
so it dosen't meet our requirements.

Zhang Haoyu
> Fam

  parent reply	other threads:[~2015-03-10  1:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03  6:52 [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to track dirty sector Zhang Haoyu
2015-03-03  9:59 ` Paolo Bonzini
2015-03-09  7:03   ` Zhang Haoyu
2015-03-09  7:38     ` Paolo Bonzini
2015-03-09  8:14     ` Zhang Haoyu
2015-03-10  0:28       ` Fam Zheng
2015-03-10  1:30       ` Zhang Haoyu [this message]
2015-03-10  1:54         ` [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to trackdirty sector Fam Zheng
2015-03-10  2:12         ` [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to trackdirtysector Zhang Haoyu
2015-03-10  2:58           ` Fam Zheng
2015-03-10  3:12           ` [Qemu-devel] [RFC] introduce bitmap to bdrv_commit totrackdirtysector Zhang Haoyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201503100930531293894@sangfor.com.cn \
    --to=zhanghy@sangfor.com.cn \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.