From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750
Date: Tue, 10 Mar 2015 11:40:30 +0000 [thread overview]
Message-ID: <20150310114030.GP10964@mwanda> (raw)
In-Reply-To: <1425981426-20680-1-git-send-email-lstoakes@gmail.com>
On Tue, Mar 10, 2015 at 09:57:06AM +0000, Lorenzo Stoakes wrote:
> This patch assigns the more appropriate void* type to the mmio750 variable
> eliminating an unnecessary volatile qualifier in the process. Additionally it
> updates parameter types as necessary where those parameters interact with
> mmio750 and removes unnecessary casts.
>
> As a consequence, this patch fixes the following sparse warning:-
>
> drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
Looks good. Thanks for doing this.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750
Date: Tue, 10 Mar 2015 14:40:30 +0300 [thread overview]
Message-ID: <20150310114030.GP10964@mwanda> (raw)
In-Reply-To: <1425981426-20680-1-git-send-email-lstoakes@gmail.com>
On Tue, Mar 10, 2015 at 09:57:06AM +0000, Lorenzo Stoakes wrote:
> This patch assigns the more appropriate void* type to the mmio750 variable
> eliminating an unnecessary volatile qualifier in the process. Additionally it
> updates parameter types as necessary where those parameters interact with
> mmio750 and removes unnecessary casts.
>
> As a consequence, this patch fixes the following sparse warning:-
>
> drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
Looks good. Thanks for doing this.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-10 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 9:57 [PATCH] staging: sm750fb: Cleanup the type of mmio750 Lorenzo Stoakes
2015-03-10 11:40 ` Dan Carpenter [this message]
2015-03-10 11:40 ` Dan Carpenter
2015-03-10 12:36 ` Sudip Mukherjee
2015-03-10 12:48 ` Sudip Mukherjee
2015-03-10 12:47 ` Lorenzo Stoakes
2015-03-10 13:06 ` Dan Carpenter
2015-03-10 13:06 ` Dan Carpenter
2015-03-10 13:22 ` Lorenzo Stoakes
2015-03-10 15:04 ` Greg KH
2015-03-10 15:04 ` Greg KH
2015-03-10 15:08 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310114030.GP10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.