From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Tapasweni Pathak
<tapaswenipathak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] efi: Disable interrupts around EFI calls, not in the epilog/prolog calls
Date: Tue, 10 Mar 2015 13:36:18 +0000 [thread overview]
Message-ID: <20150310133618.GB17573@codeblueprint.co.uk> (raw)
In-Reply-To: <20150303063433.GA30468-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, 03 Mar, at 07:34:33AM, Ingo Molnar wrote:
>
> So why are interrupts disabled around page table operations to begin
> with? It's not like any of this can execute on two CPUs at once, nor
> can this be executed from interrupt context.
>
> So, shouldn't we only protect the EFI calls themselves? If we did that
> we could save the efi_flags global variable ugliness as well.
>
> I.e. something like the attached patch. (not tested and all that)
Looks good to me Ingo. I'll run it through the test farm. Thanks!
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ingo Molnar <mingo@kernel.org>
Cc: Tapasweni Pathak <tapaswenipathak@gmail.com>,
matt.fleming@intel.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: Disable interrupts around EFI calls, not in the epilog/prolog calls
Date: Tue, 10 Mar 2015 13:36:18 +0000 [thread overview]
Message-ID: <20150310133618.GB17573@codeblueprint.co.uk> (raw)
In-Reply-To: <20150303063433.GA30468@gmail.com>
On Tue, 03 Mar, at 07:34:33AM, Ingo Molnar wrote:
>
> So why are interrupts disabled around page table operations to begin
> with? It's not like any of this can execute on two CPUs at once, nor
> can this be executed from interrupt context.
>
> So, shouldn't we only protect the EFI calls themselves? If we did that
> we could save the efi_flags global variable ugliness as well.
>
> I.e. something like the attached patch. (not tested and all that)
Looks good to me Ingo. I'll run it through the test farm. Thanks!
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-03-10 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 2:58 [PATCH] arch: x86: platform: efi: Disabling interrupt around kmalloc Tapasweni Pathak
2015-03-03 6:34 ` [PATCH] efi: Disable interrupts around EFI calls, not in the epilog/prolog calls Ingo Molnar
2015-03-03 6:34 ` Ingo Molnar
[not found] ` <20150303063433.GA30468-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-03 6:48 ` [PATCH] efi: Clean up the efi_call_phys_[prolog|epilog]() save/restore interaction Ingo Molnar
2015-03-03 6:48 ` Ingo Molnar
[not found] ` <20150303064850.GA30036-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-10 13:36 ` Matt Fleming
2015-03-10 13:36 ` Matt Fleming
2015-03-10 13:36 ` Matt Fleming [this message]
2015-03-10 13:36 ` [PATCH] efi: Disable interrupts around EFI calls, not in the epilog/prolog calls Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310133618.GB17573@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tapaswenipathak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.