All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: add symlink for hwmon device
Date: Tue, 10 Mar 2015 22:12:26 +0530	[thread overview]
Message-ID: <20150310164223.GA11700@qca.qualcomm.com> (raw)
In-Reply-To: <87pp8gyi7x.fsf@kamboji.qca.qualcomm.com>

On Tue, Mar 10, 2015 at 05:39:46PM +0200, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> 
> > Add symbloic link "thermal_sensors" for hwmon devices for better
> > readability.
> >
> > /sys/class/ieee80211/phyX/device/thermal_sensors ->
> > sys/class/ieee80211/phyX/device/hwmon/hwmonY
> 
> I don't get it, how does that improve readability? Also I don't see any
> other driver doing this, so isn't this just some private hack and not a
> proper generic interface?
>
The patch is providing same level access to monitoring device similar to
cooling device.

cooling_device -> ../../../../../virtual/thermal/cooling_deviceX
thermal_sensors -> hwmon/hwmonX

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] ath10k: add symlink for hwmon device
Date: Tue, 10 Mar 2015 22:12:26 +0530	[thread overview]
Message-ID: <20150310164223.GA11700@qca.qualcomm.com> (raw)
In-Reply-To: <87pp8gyi7x.fsf@kamboji.qca.qualcomm.com>

On Tue, Mar 10, 2015 at 05:39:46PM +0200, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> 
> > Add symbloic link "thermal_sensors" for hwmon devices for better
> > readability.
> >
> > /sys/class/ieee80211/phyX/device/thermal_sensors ->
> > sys/class/ieee80211/phyX/device/hwmon/hwmonY
> 
> I don't get it, how does that improve readability? Also I don't see any
> other driver doing this, so isn't this just some private hack and not a
> proper generic interface?
>
The patch is providing same level access to monitoring device similar to
cooling device.

cooling_device -> ../../../../../virtual/thermal/cooling_deviceX
thermal_sensors -> hwmon/hwmonX

-Rajkumar

  reply	other threads:[~2015-03-10 16:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 13:04 [PATCH 1/3] ath10k: add sysfs entry to configure quiet period Rajkumar Manoharan
2015-02-20 13:04 ` Rajkumar Manoharan
2015-02-20 13:04 ` [PATCH 2/3] ath10k: fix wrong symlink name on error path Rajkumar Manoharan
2015-02-20 13:04   ` Rajkumar Manoharan
2015-03-12 13:00   ` Kalle Valo
2015-03-12 13:00     ` Kalle Valo
2015-03-15  8:24     ` Rajkumar Manoharan
2015-03-15  8:24       ` Rajkumar Manoharan
2015-02-20 13:04 ` [PATCH 3/3] ath10k: add symlink for hwmon device Rajkumar Manoharan
2015-02-20 13:04   ` Rajkumar Manoharan
2015-03-10 15:39   ` Kalle Valo
2015-03-10 15:39     ` Kalle Valo
2015-03-10 16:42     ` Rajkumar Manoharan [this message]
2015-03-10 16:42       ` Rajkumar Manoharan
2015-03-12 13:20       ` Kalle Valo
2015-03-12 13:20         ` Kalle Valo
2015-03-12 13:46         ` Rajkumar Manoharan
2015-03-12 13:46           ` Rajkumar Manoharan
2015-03-10 15:43 ` [PATCH 1/3] ath10k: add sysfs entry to configure quiet period Kalle Valo
2015-03-10 15:43   ` Kalle Valo
2015-03-10 16:53   ` Rajkumar Manoharan
2015-03-10 16:53     ` Rajkumar Manoharan
2015-03-12 13:21     ` Kalle Valo
2015-03-12 13:21       ` Kalle Valo
2015-03-12 13:50       ` Rajkumar Manoharan
2015-03-12 13:50         ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310164223.GA11700@qca.qualcomm.com \
    --to=rmanohar@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.