From: willy@wil.cx (Matthew Wilcox)
Subject: [PATCH] NVMe: Fix error handling of class_create("nvme")
Date: Tue, 10 Mar 2015 15:46:29 -0400 [thread overview]
Message-ID: <20150310194629.GQ2780@wil.cx> (raw)
In-Reply-To: <1426015102.18746.10.camel@jpfreyen-mobl5.amr.corp.intel.com>
On Tue, Mar 10, 2015@12:18:22PM -0700, J Freyensee wrote:
> Looking at IS_ERR(), it uses IS_ERR_VALUE() which uses unlikely(), which
> from what I understand is a compiler hint that means "this error is
> unlikely to happen".
>
> Well, is this error unlikely to happen? Looks like the error could be
Yes. All errors are, by definition, unlikely to happen.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@wil.cx>
To: J Freyensee <james_p_freyensee@linux.intel.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Matthew Wilcox <willy@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
ldv-project@linuxtesting.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NVMe: Fix error handling of class_create("nvme")
Date: Tue, 10 Mar 2015 15:46:29 -0400 [thread overview]
Message-ID: <20150310194629.GQ2780@wil.cx> (raw)
In-Reply-To: <1426015102.18746.10.camel@jpfreyen-mobl5.amr.corp.intel.com>
On Tue, Mar 10, 2015 at 12:18:22PM -0700, J Freyensee wrote:
> Looking at IS_ERR(), it uses IS_ERR_VALUE() which uses unlikely(), which
> from what I understand is a compiler hint that means "this error is
> unlikely to happen".
>
> Well, is this error unlikely to happen? Looks like the error could be
Yes. All errors are, by definition, unlikely to happen.
next prev parent reply other threads:[~2015-03-10 19:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 22:43 [PATCH] NVMe: Fix error handling of class_create("nvme") Alexey Khoroshilov
2015-03-06 22:43 ` Alexey Khoroshilov
2015-03-10 19:18 ` J Freyensee
2015-03-10 19:18 ` J Freyensee
2015-03-10 19:46 ` Matthew Wilcox [this message]
2015-03-10 19:46 ` Matthew Wilcox
2015-03-16 17:22 ` Keith Busch
2015-03-16 17:22 ` Keith Busch
2015-04-07 23:03 ` Keith Busch
2015-04-08 1:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310194629.GQ2780@wil.cx \
--to=willy@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.