Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Mar 10, 2015 at 06:04:20PM +0000, Peter Maydell wrote:
> On 10 March 2015 at 17:53, Andreas Färber <afaerber@suse.de> wrote:
> > Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin:
> >> On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas Färber wrote:
> >>> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin:
> >>>> Make it safe to include hw/boards.h in exec.c
> >>>> for linux-user configurations.
> >>>> We don't need any of its contents though.
> >>>>
> >>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >>>> ---
> >>>>
> >>>> Already on my tree as Marcel's patches needed this.
> >>>
> >>> Why? Which patches?
> >>>
> >>> Andreas
> >>
> >> This one:
> >>     machine: query dump-guest-core machine property rather than qemu opts
> >
> > Let's please find a better way to fix that. hw/boards.h shouldn't be
> > used outside softmmu code.
> 
> Agreed.
> 
> -- PMM


What is prefered?

#ifndef USER
#include "hw/boards.h"
#endif

?