All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user
Date: Tue, 10 Mar 2015 18:34:44 +0100	[thread overview]
Message-ID: <54FF2B34.3050106@suse.de> (raw)
In-Reply-To: <20150310183316-mutt-send-email-mst@redhat.com>

Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin:
> Make it safe to include hw/boards.h in exec.c
> for linux-user configurations.
> We don't need any of its contents though.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Already on my tree as Marcel's patches needed this.

Why? Which patches?

Andreas

> 
>  include/hw/boards.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 1f21bdf..0bf00f7 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -3,6 +3,8 @@
>  #ifndef HW_BOARDS_H
>  #define HW_BOARDS_H
>  
> +#if !defined(CONFIG_USER_ONLY)
> +
>  #include "qemu/typedefs.h"
>  #include "sysemu/blockdev.h"
>  #include "sysemu/accel.h"
> @@ -154,3 +156,5 @@ struct MachineState {
>  };
>  
>  #endif
> +
> +#endif
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

  reply	other threads:[~2015-03-10 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 17:33 [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user Michael S. Tsirkin
2015-03-10 17:34 ` Andreas Färber [this message]
2015-03-10 17:41   ` Michael S. Tsirkin
2015-03-10 17:53     ` Andreas Färber
2015-03-10 18:04       ` Peter Maydell
2015-03-10 21:22         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FF2B34.3050106@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.