All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Disable PWMs in imx6ql.dtsi
@ 2015-03-09 16:40 ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

PWMs are only useful if they have an output pin connected. Since
most boards don't have all of the PWM output pins assigned, let's
disable the PWMs by default in imx6qdl.dtsi and have each board
device tree explicitly enable just the PWMs they need.
Most device trees do this already - add the missing ones and
change the default status to "disabled" in the dtsi.

regards
Philipp

Philipp Zabel (3):
  ARM: dts: imx6dl-aristainetos: enable backlight PWM explicitly
  ARM: dts: hummingboard/cubox-i: enable front LED PWM explicitly
  ARM: dts: imx6qdl: disable PWMs by default

 arch/arm/boot/dts/imx6dl-aristainetos_4.dts | 4 ++++
 arch/arm/boot/dts/imx6dl-aristainetos_7.dts | 4 ++++
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi      | 4 ++++
 arch/arm/boot/dts/imx6qdl.dtsi              | 4 ++++
 4 files changed, 16 insertions(+)

-- 
2.1.4

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 0/3] Disable PWMs in imx6ql.dtsi
@ 2015-03-09 16:40 ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Heiko Schocher, Fabio Estevam, Anssi Hannula,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	Philipp Zabel

Hi,

PWMs are only useful if they have an output pin connected. Since
most boards don't have all of the PWM output pins assigned, let's
disable the PWMs by default in imx6qdl.dtsi and have each board
device tree explicitly enable just the PWMs they need.
Most device trees do this already - add the missing ones and
change the default status to "disabled" in the dtsi.

regards
Philipp

Philipp Zabel (3):
  ARM: dts: imx6dl-aristainetos: enable backlight PWM explicitly
  ARM: dts: hummingboard/cubox-i: enable front LED PWM explicitly
  ARM: dts: imx6qdl: disable PWMs by default

 arch/arm/boot/dts/imx6dl-aristainetos_4.dts | 4 ++++
 arch/arm/boot/dts/imx6dl-aristainetos_7.dts | 4 ++++
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi      | 4 ++++
 arch/arm/boot/dts/imx6qdl.dtsi              | 4 ++++
 4 files changed, 16 insertions(+)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: imx6dl-aristainetos: enable backlight PWM explicitly
@ 2015-03-09 16:40   ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: linux-arm-kernel

All PWM users should explicitly enable the used PWMs in their device tree
so they can be disabled by default in imx6qdl.dtsi.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 arch/arm/boot/dts/imx6dl-aristainetos_4.dts | 4 ++++
 arch/arm/boot/dts/imx6dl-aristainetos_7.dts | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6dl-aristainetos_4.dts b/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
index 9cd06e5..d4c4a22 100644
--- a/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
+++ b/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
@@ -83,3 +83,7 @@
 &ipu1_di0_disp0 {
 	remote-endpoint = <&display0_in>;
 };
+
+&pwm1 {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/imx6dl-aristainetos_7.dts b/arch/arm/boot/dts/imx6dl-aristainetos_7.dts
index b413e24..15203f0 100644
--- a/arch/arm/boot/dts/imx6dl-aristainetos_7.dts
+++ b/arch/arm/boot/dts/imx6dl-aristainetos_7.dts
@@ -72,3 +72,7 @@
 &ipu1_di0_disp0 {
 	remote-endpoint = <&display0_in>;
 };
+
+&pwm3 {
+	status = "okay";
+};
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/3] ARM: dts: imx6dl-aristainetos: enable backlight PWM explicitly
@ 2015-03-09 16:40   ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Heiko Schocher, Fabio Estevam, Anssi Hannula,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	Philipp Zabel

All PWM users should explicitly enable the used PWMs in their device tree
so they can be disabled by default in imx6qdl.dtsi.

Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
 arch/arm/boot/dts/imx6dl-aristainetos_4.dts | 4 ++++
 arch/arm/boot/dts/imx6dl-aristainetos_7.dts | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6dl-aristainetos_4.dts b/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
index 9cd06e5..d4c4a22 100644
--- a/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
+++ b/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
@@ -83,3 +83,7 @@
 &ipu1_di0_disp0 {
 	remote-endpoint = <&display0_in>;
 };
+
+&pwm1 {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/imx6dl-aristainetos_7.dts b/arch/arm/boot/dts/imx6dl-aristainetos_7.dts
index b413e24..15203f0 100644
--- a/arch/arm/boot/dts/imx6dl-aristainetos_7.dts
+++ b/arch/arm/boot/dts/imx6dl-aristainetos_7.dts
@@ -72,3 +72,7 @@
 &ipu1_di0_disp0 {
 	remote-endpoint = <&display0_in>;
 };
+
+&pwm3 {
+	status = "okay";
+};
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/3] ARM: dts: hummingboard/cubox-i: enable front LED PWM explicitly
@ 2015-03-09 16:40   ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: linux-arm-kernel

All PWM users should explicitly enable the used PWMs in their device tree
so they can be disabled by default in imx6qdl.dtsi.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index 6a524ca..6c9f5e9 100644
--- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -173,6 +173,10 @@
 	};
 };
 
+&pwm1 {
+	status = "okay";
+};
+
 &spdif {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_cubox_i_spdif>;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/3] ARM: dts: hummingboard/cubox-i: enable front LED PWM explicitly
@ 2015-03-09 16:40   ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Heiko Schocher, Fabio Estevam, Anssi Hannula,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	Philipp Zabel

All PWM users should explicitly enable the used PWMs in their device tree
so they can be disabled by default in imx6qdl.dtsi.

Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index 6a524ca..6c9f5e9 100644
--- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -173,6 +173,10 @@
 	};
 };
 
+&pwm1 {
+	status = "okay";
+};
+
 &spdif {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_cubox_i_spdif>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 3/3] ARM: dts: imx6qdl: disable PWMs by default
@ 2015-03-09 16:40   ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: linux-arm-kernel

Since PWMs are only useful if they are actually connected to an output pin,
let users enable them explicitly in their device trees where they should
also set up the pin configuration.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index ce37bbf1..9cc30a4 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -380,6 +380,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM1>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			pwm2: pwm at 02084000 {
@@ -390,6 +391,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM2>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			pwm3: pwm at 02088000 {
@@ -400,6 +402,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM3>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			pwm4: pwm at 0208c000 {
@@ -410,6 +413,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM4>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			can1: flexcan at 02090000 {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 3/3] ARM: dts: imx6qdl: disable PWMs by default
@ 2015-03-09 16:40   ` Philipp Zabel
  0 siblings, 0 replies; 10+ messages in thread
From: Philipp Zabel @ 2015-03-09 16:40 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Heiko Schocher, Fabio Estevam, Anssi Hannula,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	Philipp Zabel

Since PWMs are only useful if they are actually connected to an output pin,
let users enable them explicitly in their device trees where they should
also set up the pin configuration.

Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index ce37bbf1..9cc30a4 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -380,6 +380,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM1>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			pwm2: pwm@02084000 {
@@ -390,6 +391,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM2>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			pwm3: pwm@02088000 {
@@ -400,6 +402,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM3>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			pwm4: pwm@0208c000 {
@@ -410,6 +413,7 @@
 				clocks = <&clks IMX6QDL_CLK_IPG>,
 					 <&clks IMX6QDL_CLK_PWM4>;
 				clock-names = "ipg", "per";
+				status = "disabled";
 			};
 
 			can1: flexcan@02090000 {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 0/3] Disable PWMs in imx6ql.dtsi
@ 2015-03-11  1:53   ` Shawn Guo
  0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2015-03-11  1:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Mar 09, 2015 at 05:40:33PM +0100, Philipp Zabel wrote:
> Philipp Zabel (3):
>   ARM: dts: imx6dl-aristainetos: enable backlight PWM explicitly
>   ARM: dts: hummingboard/cubox-i: enable front LED PWM explicitly
>   ARM: dts: imx6qdl: disable PWMs by default

Applied all, thanks.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Disable PWMs in imx6ql.dtsi
@ 2015-03-11  1:53   ` Shawn Guo
  0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2015-03-11  1:53 UTC (permalink / raw)
  To: Philipp Zabel
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Heiko Schocher, Fabio Estevam, Anssi Hannula,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, kernel-bIcnvbaLZ9MEGnE8C9+IrQ

On Mon, Mar 09, 2015 at 05:40:33PM +0100, Philipp Zabel wrote:
> Philipp Zabel (3):
>   ARM: dts: imx6dl-aristainetos: enable backlight PWM explicitly
>   ARM: dts: hummingboard/cubox-i: enable front LED PWM explicitly
>   ARM: dts: imx6qdl: disable PWMs by default

Applied all, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-03-11  1:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 16:40 [PATCH 0/3] Disable PWMs in imx6ql.dtsi Philipp Zabel
2015-03-09 16:40 ` Philipp Zabel
2015-03-09 16:40 ` [PATCH 1/3] ARM: dts: imx6dl-aristainetos: enable backlight PWM explicitly Philipp Zabel
2015-03-09 16:40   ` Philipp Zabel
2015-03-09 16:40 ` [PATCH 2/3] ARM: dts: hummingboard/cubox-i: enable front LED " Philipp Zabel
2015-03-09 16:40   ` Philipp Zabel
2015-03-09 16:40 ` [PATCH 3/3] ARM: dts: imx6qdl: disable PWMs by default Philipp Zabel
2015-03-09 16:40   ` Philipp Zabel
2015-03-11  1:53 ` [PATCH 0/3] Disable PWMs in imx6ql.dtsi Shawn Guo
2015-03-11  1:53   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.