From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: sm750fb: correct integer comparison
Date: Wed, 11 Mar 2015 07:57:43 +0000 [thread overview]
Message-ID: <20150311075743.GS10964@mwanda> (raw)
In-Reply-To: <1426007817-1884-7-git-send-email-sudipm.mukherjee@gmail.com>
On Tue, Mar 10, 2015 at 10:46:57PM +0530, Sudip Mukherjee wrote:
> fixed the build warning about comparison of pointer and integer.
> end of string was being compared to NULL.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 021b863..5532a28 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -1000,7 +1000,7 @@ static void sm750fb_setup(struct lynx_share * share,char * src)
> goto NO_PARAM;
> }
>
> - while((opt = strsep(&src,":")) != NULL && *opt != NULL){
> + while((opt = strsep(&src,":")) != NULL && *opt != 0){
Use '\0' for the NUL char.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: sm750fb: correct integer comparison
Date: Wed, 11 Mar 2015 10:57:43 +0300 [thread overview]
Message-ID: <20150311075743.GS10964@mwanda> (raw)
In-Reply-To: <1426007817-1884-7-git-send-email-sudipm.mukherjee@gmail.com>
On Tue, Mar 10, 2015 at 10:46:57PM +0530, Sudip Mukherjee wrote:
> fixed the build warning about comparison of pointer and integer.
> end of string was being compared to NULL.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 021b863..5532a28 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -1000,7 +1000,7 @@ static void sm750fb_setup(struct lynx_share * share,char * src)
> goto NO_PARAM;
> }
>
> - while((opt = strsep(&src,":")) != NULL && *opt != NULL){
> + while((opt = strsep(&src,":")) != NULL && *opt != 0){
Use '\0' for the NUL char.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-11 7:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 17:16 [PATCH 0/6] staging: sm750fb: fixed all build warnings Sudip Mukherjee
2015-03-10 17:28 ` Sudip Mukherjee
2015-03-10 17:16 ` [PATCH 1/6] staging: sm750fb: remove unused functions Sudip Mukherjee
2015-03-10 17:28 ` Sudip Mukherjee
2015-03-10 17:16 ` [PATCH 2/6] staging: sm750fb: remove unused variables Sudip Mukherjee
2015-03-10 17:28 ` Sudip Mukherjee
2015-03-10 17:16 ` [PATCH 3/6] staging: sm750fb: correct function return Sudip Mukherjee
2015-03-10 17:28 ` Sudip Mukherjee
2015-03-10 17:16 ` [PATCH 4/6] staging: sm750fb: correct incompatible pointer type Sudip Mukherjee
2015-03-10 17:28 ` Sudip Mukherjee
2015-03-10 20:11 ` Greg Kroah-Hartman
2015-03-10 20:11 ` Greg Kroah-Hartman
2015-03-10 20:17 ` Greg Kroah-Hartman
2015-03-10 20:17 ` Greg Kroah-Hartman
2015-03-11 7:28 ` Sudip Mukherjee
2015-03-11 7:40 ` Sudip Mukherjee
2015-03-11 7:43 ` Greg Kroah-Hartman
2015-03-11 7:43 ` Greg Kroah-Hartman
2015-03-10 17:16 ` [PATCH 5/6] staging: sm750fb: fix mixed declarations Sudip Mukherjee
2015-03-10 17:28 ` Sudip Mukherjee
2015-03-10 17:16 ` [PATCH 6/6] staging: sm750fb: correct integer comparison Sudip Mukherjee
2015-03-10 17:28 ` Sudip Mukherjee
2015-03-11 7:57 ` Dan Carpenter [this message]
2015-03-11 7:57 ` Dan Carpenter
2015-03-11 8:55 ` Sudip Mukherjee
2015-03-11 8:56 ` Sudip Mukherjee
2015-03-10 20:13 ` [PATCH 0/6] staging: sm750fb: fixed all build warnings Greg Kroah-Hartman
2015-03-10 20:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311075743.GS10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.