From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally
Date: Wed, 11 Mar 2015 08:56:04 +0000 [thread overview]
Message-ID: <20150311085604.GV10964@mwanda> (raw)
In-Reply-To: <1426037325-8392-4-git-send-email-lstoakes@gmail.com>
On Wed, Mar 11, 2015 at 01:28:43AM +0000, Lorenzo Stoakes wrote:
> This patch adds a reference to hw712_fillrect which is not used elsewhere in the driver,
> but appears to be an alternative to the hw_fillrect method. This patch fixes the following sparse warning:-
>
> drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static?
>
Just delete it.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally
Date: Wed, 11 Mar 2015 11:56:04 +0300 [thread overview]
Message-ID: <20150311085604.GV10964@mwanda> (raw)
In-Reply-To: <1426037325-8392-4-git-send-email-lstoakes@gmail.com>
On Wed, Mar 11, 2015 at 01:28:43AM +0000, Lorenzo Stoakes wrote:
> This patch adds a reference to hw712_fillrect which is not used elsewhere in the driver,
> but appears to be an alternative to the hw_fillrect method. This patch fixes the following sparse warning:-
>
> drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static?
>
Just delete it.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-11 8:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 1:28 [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset Lorenzo Stoakes
2015-03-11 1:28 ` [PATCH 2/6] staging: sm750fb: Fix non-ANSI function declarations Lorenzo Stoakes
2015-03-11 1:28 ` Lorenzo Stoakes
2015-03-11 1:28 ` [PATCH 3/6] staging: sm750fb: Make internal functions static Lorenzo Stoakes
2015-03-11 9:30 ` Sudip Mukherjee
2015-03-11 9:42 ` Sudip Mukherjee
2015-03-11 9:38 ` Lorenzo Stoakes
2015-03-11 1:28 ` [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally Lorenzo Stoakes
2015-03-11 8:56 ` Dan Carpenter [this message]
2015-03-11 8:56 ` Dan Carpenter
2015-03-11 9:37 ` Sudip Mukherjee
2015-03-11 9:49 ` Sudip Mukherjee
2015-03-11 9:39 ` Lorenzo Stoakes
2015-03-11 1:28 ` [PATCH 5/6] staging: sm750fb: Fix __iomem pointer types Lorenzo Stoakes
2015-03-11 1:28 ` [PATCH 6/6] staging: sm750fb: Spinlock and unlock in the same block Lorenzo Stoakes
2015-03-11 1:28 ` Lorenzo Stoakes
2015-03-11 9:09 ` Dan Carpenter
2015-03-11 9:09 ` Dan Carpenter
2015-03-11 8:54 ` [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset Dan Carpenter
2015-03-11 8:54 ` Dan Carpenter
2015-03-11 9:11 ` Lorenzo Stoakes
2015-03-11 9:23 ` Dan Carpenter
2015-03-11 9:23 ` Dan Carpenter
2015-03-11 9:48 ` Sudip Mukherjee
2015-03-11 9:48 ` Sudip Mukherjee
2015-03-11 10:35 ` Sudip Mukherjee
2015-03-11 10:47 ` Sudip Mukherjee
2015-03-11 10:41 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311085604.GV10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.