From: Baruch Siach <baruch@tkos.co.il>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Peng Tao <tao.peng@primarydata.com>,
Tom Haynes <Thomas.Haynes@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] nfs: do not export discarded symbols
Date: Wed, 11 Mar 2015 16:52:49 +0200 [thread overview]
Message-ID: <20150311145249.GH2177@tarshish> (raw)
In-Reply-To: <3173686.FPJdK9jLbA@wuerfel>
Hi Arnd,
On Wed, Mar 11, 2015 at 02:37:25PM +0100, Arnd Bergmann wrote:
> The function nfs4_pnfs_v3_ds_connect_unload is exported so it can be
> used by other modules, but is also marked '__exit' and will be
> discarded when built into the kernel, as pointed out by this
> linker error:
>
> `nfs4_pnfs_v3_ds_connect_unload' referenced in section `___ksymtab_gpl+nfs4_pnfs_v3_ds_connect_unload' of fs/built-in.o: defined in discarded section `.exit.text' of fs/built-in.o
>
> This removes the __exit annotation to make it safe to call this function.
Should be "do not discard exported symbols" in subject then?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] nfs: do not export discarded symbols
Date: Wed, 11 Mar 2015 16:52:49 +0200 [thread overview]
Message-ID: <20150311145249.GH2177@tarshish> (raw)
In-Reply-To: <3173686.FPJdK9jLbA@wuerfel>
Hi Arnd,
On Wed, Mar 11, 2015 at 02:37:25PM +0100, Arnd Bergmann wrote:
> The function nfs4_pnfs_v3_ds_connect_unload is exported so it can be
> used by other modules, but is also marked '__exit' and will be
> discarded when built into the kernel, as pointed out by this
> linker error:
>
> `nfs4_pnfs_v3_ds_connect_unload' referenced in section `___ksymtab_gpl+nfs4_pnfs_v3_ds_connect_unload' of fs/built-in.o: defined in discarded section `.exit.text' of fs/built-in.o
>
> This removes the __exit annotation to make it safe to call this function.
Should be "do not discard exported symbols" in subject then?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-03-11 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 13:37 [PATCH] nfs: do not export discarded symbols Arnd Bergmann
2015-03-11 13:37 ` Arnd Bergmann
2015-03-11 14:52 ` Baruch Siach [this message]
2015-03-11 14:52 ` Baruch Siach
2015-03-12 15:58 ` Trond Myklebust
2015-03-12 15:58 ` Trond Myklebust
2015-04-09 9:33 ` Arnd Bergmann
2015-04-09 9:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311145249.GH2177@tarshish \
--to=baruch@tkos.co.il \
--cc=Thomas.Haynes@primarydata.com \
--cc=anna.schumaker@netapp.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@primarydata.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.