From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: sx8654 - signedness bug in sx8654_irq()
Date: Wed, 11 Mar 2015 17:43:30 +0000 [thread overview]
Message-ID: <20150311174330.GC3640@dtor-ws> (raw)
In-Reply-To: <20150311093707.GC3564@mwanda>
On Wed, Mar 11, 2015 at 12:37:07PM +0300, Dan Carpenter wrote:
> "irqsrc" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied, thank you.
> diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
> index 8e531ac..aecb9ad 100644
> --- a/drivers/input/touchscreen/sx8654.c
> +++ b/drivers/input/touchscreen/sx8654.c
> @@ -79,7 +79,7 @@ struct sx8654 {
> static irqreturn_t sx8654_irq(int irq, void *handle)
> {
> struct sx8654 *sx8654 = handle;
> - u8 irqsrc;
> + int irqsrc;
> u8 data[4];
> unsigned int x, y;
> int retval;
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: sx8654 - signedness bug in sx8654_irq()
Date: Wed, 11 Mar 2015 10:43:30 -0700 [thread overview]
Message-ID: <20150311174330.GC3640@dtor-ws> (raw)
In-Reply-To: <20150311093707.GC3564@mwanda>
On Wed, Mar 11, 2015 at 12:37:07PM +0300, Dan Carpenter wrote:
> "irqsrc" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied, thank you.
> diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
> index 8e531ac..aecb9ad 100644
> --- a/drivers/input/touchscreen/sx8654.c
> +++ b/drivers/input/touchscreen/sx8654.c
> @@ -79,7 +79,7 @@ struct sx8654 {
> static irqreturn_t sx8654_irq(int irq, void *handle)
> {
> struct sx8654 *sx8654 = handle;
> - u8 irqsrc;
> + int irqsrc;
> u8 data[4];
> unsigned int x, y;
> int retval;
--
Dmitry
next prev parent reply other threads:[~2015-03-11 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 9:37 [patch] Input: sx8654 - signedness bug in sx8654_irq() Dan Carpenter
2015-03-11 9:37 ` Dan Carpenter
2015-03-11 17:43 ` Dmitry Torokhov [this message]
2015-03-11 17:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311174330.GC3640@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=sebastien.szymanski@armadeus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.