All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>,
	Marek Belisko <marek@goldelico.com>,
	Benoit Cousson <bcousson@baylibre.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-omap@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings
Date: Wed, 11 Mar 2015 12:37:36 -0700	[thread overview]
Message-ID: <20150311193736.GF5264@atomide.com> (raw)
In-Reply-To: <20150311193654.GA3126@earth>

* Sebastian Reichel <sre@kernel.org> [150311 12:37]:
> Hi,
> 
> On Wed, Mar 11, 2015 at 10:43:17AM -0700, Tony Lindgren wrote:
> > No no, "capacity-uah" is what we should use, but you need an ack from
> > the battery and device tree people that this is OK. Let's not add
> > "ti,capacity-uah” as that can obviously be a generic property.
> 
> I'm okay with capacity-uah.

OK great.
 
> > > [...]
> > 
> > Oh if they are battery spicific, then ideally we'd have generic batery
> > voltage to capacity maps property rather than a custom ti specific
> > property.
> > 
> > To avoid extra hassles later on, maybe you could submit a generic
> > binding patch only documenting it to the battery people and the device
> > tree people? That will make it easier to maintain this driver in the
> > long run.
> 
> Actually the proper way would be to differentiate between the
> battery and the measurement chip / adc and that should be
> implemented in the long run. The kernel's power supply framework
> is not yet ready for it, though.
> 
> Example DT:
> 
> battery {
>     battery-specific-data;
> };
> 
> fuel-gauge {
>     measures = <&battery>;
> };
> 
> charger {
>     charges = <&battery>;
> };
> 
> Since infrastructure for generic bindings is missing, I think its
> best to have the vendor properties for now and map this to generic
> properties, once they have been specified.

OK, sounds good to me. I'm fine with the $subject patch as it is then:

Acked-by: Tony Lindgren <tony@atomide.com>

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings
Date: Wed, 11 Mar 2015 12:37:36 -0700	[thread overview]
Message-ID: <20150311193736.GF5264@atomide.com> (raw)
In-Reply-To: <20150311193654.GA3126@earth>

* Sebastian Reichel <sre@kernel.org> [150311 12:37]:
> Hi,
> 
> On Wed, Mar 11, 2015 at 10:43:17AM -0700, Tony Lindgren wrote:
> > No no, "capacity-uah" is what we should use, but you need an ack from
> > the battery and device tree people that this is OK. Let's not add
> > "ti,capacity-uah? as that can obviously be a generic property.
> 
> I'm okay with capacity-uah.

OK great.
 
> > > [...]
> > 
> > Oh if they are battery spicific, then ideally we'd have generic batery
> > voltage to capacity maps property rather than a custom ti specific
> > property.
> > 
> > To avoid extra hassles later on, maybe you could submit a generic
> > binding patch only documenting it to the battery people and the device
> > tree people? That will make it easier to maintain this driver in the
> > long run.
> 
> Actually the proper way would be to differentiate between the
> battery and the measurement chip / adc and that should be
> implemented in the long run. The kernel's power supply framework
> is not yet ready for it, though.
> 
> Example DT:
> 
> battery {
>     battery-specific-data;
> };
> 
> fuel-gauge {
>     measures = <&battery>;
> };
> 
> charger {
>     charges = <&battery>;
> };
> 
> Since infrastructure for generic bindings is missing, I think its
> best to have the vendor properties for now and map this to generic
> properties, once they have been specified.

OK, sounds good to me. I'm fine with the $subject patch as it is then:

Acked-by: Tony Lindgren <tony@atomide.com>

Tony

  reply	other threads:[~2015-03-11 19:37 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 21:27 [PATCH v4 0/6] Convert twl4030_madc_battery to IIO consumer and add DT aupport Marek Belisko
2015-03-10 21:27 ` Marek Belisko
     [not found] ` <1426022847-30912-1-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-03-10 21:27   ` [PATCH v4 1/6] power: twl4030-madc-battery: Convert to iio consumer Marek Belisko
2015-03-10 21:27     ` Marek Belisko
2015-03-10 21:27     ` Marek Belisko
     [not found]     ` <1426022847-30912-2-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-04-06 17:39       ` Sebastian Reichel
2015-04-06 17:39         ` Sebastian Reichel
2015-04-06 17:39         ` Sebastian Reichel
2015-03-10 21:27   ` [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings Marek Belisko
2015-03-10 21:27     ` Marek Belisko
2015-03-10 21:27     ` Marek Belisko
2015-03-11 15:24     ` Tony Lindgren
2015-03-11 15:24       ` Tony Lindgren
2015-03-11 16:16       ` Dr. H. Nikolaus Schaller
2015-03-11 16:16         ` Dr. H. Nikolaus Schaller
     [not found]         ` <844740CD-C95B-4411-A2C8-4906F58DBEE8-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-03-11 16:44           ` Tony Lindgren
2015-03-11 16:44             ` Tony Lindgren
2015-03-11 16:44             ` Tony Lindgren
2015-03-11 17:13             ` Dr. H. Nikolaus Schaller
2015-03-11 17:13               ` Dr. H. Nikolaus Schaller
2015-03-11 17:43               ` Tony Lindgren
2015-03-11 17:43                 ` Tony Lindgren
2015-03-11 17:43                 ` Tony Lindgren
2015-03-11 19:36                 ` Sebastian Reichel
2015-03-11 19:36                   ` Sebastian Reichel
2015-03-11 19:37                   ` Tony Lindgren [this message]
2015-03-11 19:37                     ` Tony Lindgren
     [not found]             ` <20150311164442.GA5264-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-03-31  7:26               ` Pavel Machek
2015-03-31  7:26                 ` Pavel Machek
2015-03-31  7:26                 ` Pavel Machek
2015-04-01  8:18                 ` Dr. H. Nikolaus Schaller
2015-04-01  8:18                   ` Dr. H. Nikolaus Schaller
2015-04-01 20:16                   ` Pavel Machek
2015-04-01 20:16                     ` Pavel Machek
2015-04-01 20:16                     ` Pavel Machek
2015-04-01 20:39                     ` Dr. H. Nikolaus Schaller
2015-04-01 20:39                       ` Dr. H. Nikolaus Schaller
2015-04-04  8:16                       ` Pavel Machek
2015-04-04  8:16                         ` Pavel Machek
2015-04-04  9:46                         ` Dr. H. Nikolaus Schaller
2015-04-04  9:46                           ` Dr. H. Nikolaus Schaller
2015-04-04  9:46                           ` Dr. H. Nikolaus Schaller
2015-04-01 16:30     ` Rob Herring
2015-04-01 16:30       ` Rob Herring
2015-04-01 16:46       ` Dr. H. Nikolaus Schaller
2015-04-01 16:46         ` Dr. H. Nikolaus Schaller
2015-03-10 21:27 ` [PATCH v4 2/6] power: twl4030_madc_battery: Add device tree support Marek Belisko
2015-03-10 21:27   ` Marek Belisko
2015-03-10 21:27   ` Marek Belisko
2015-03-10 21:27 ` [PATCH v4 4/6] ARM: dts: omap3-gta04: Add battery support Marek Belisko
2015-03-10 21:27   ` Marek Belisko
2015-03-16 20:53   ` Tony Lindgren
2015-03-16 20:53     ` Tony Lindgren
2015-03-16 21:04     ` Tony Lindgren
2015-03-16 21:04       ` Tony Lindgren
2015-03-10 21:27 ` [PATCH v4 5/6] power: twl4030_madc_battery: Add of_twl4030_madc_match to MODULE_DEVICE_TABLE Marek Belisko
2015-03-10 21:27   ` Marek Belisko
2015-03-10 21:27 ` [PATCH v4 6/6] power: twl4030_madc_battery: Add missing MODULE_ALIAS Marek Belisko
2015-03-10 21:27   ` Marek Belisko
2015-03-10 21:27   ` Marek Belisko
2015-04-06 17:45   ` Sebastian Reichel
2015-04-06 17:45     ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311193736.GF5264@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=hns@goldelico.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marek@goldelico.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.