All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kenneth Westfield <kwestfie@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Mike Turquette <mturquette@linaro.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Kenneth Westfield <kwestfie@codeaurora.org>
Subject: Re: [PATCH v2] clk: qcom: Properly change rates for ahbix clock
Date: Wed, 11 Mar 2015 20:42:34 -0700	[thread overview]
Message-ID: <20150312034234.GA22530@kwestfie-linux.qualcomm.com> (raw)
In-Reply-To: <1425685313-6005-1-git-send-email-sboyd@codeaurora.org>

On Fri, Mar 06, 2015 at 03:41:53PM -0800, Stephen Boyd wrote:
> The ahbix clock can never be turned off in practice. To change the
> rates we need to switch the mux off the M/N counter to an always on
> source (XO), reprogram the M/N counter to get the rate we want and
> finally switch back to the M/N counter. Add a new ops structure
> for this type of clock so that we can set the rate properly.
> 
> Fixes: c99e515a92e9 "clk: qcom: Add IPQ806X LPASS clock controller (LCC) driver"
> Cc: Kenneth Westfield <kwestfie@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> Changes from v1:
>  * Handle the case where clock feeding M/N counter is off
> 
>  drivers/clk/qcom/clk-rcg.c     | 62 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/clk/qcom/clk-rcg.h     |  1 +
>  drivers/clk/qcom/lcc-ipq806x.c |  5 ++--
>  3 files changed, 65 insertions(+), 3 deletions(-)

Verified I2S audio functionality on the Storm board; with and without
firmware audio enabled.

Tested-by: Kenneth Westfield <kwestfie@codeaurora.org>

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: kwestfie@codeaurora.org (Kenneth Westfield)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: qcom: Properly change rates for ahbix clock
Date: Wed, 11 Mar 2015 20:42:34 -0700	[thread overview]
Message-ID: <20150312034234.GA22530@kwestfie-linux.qualcomm.com> (raw)
In-Reply-To: <1425685313-6005-1-git-send-email-sboyd@codeaurora.org>

On Fri, Mar 06, 2015 at 03:41:53PM -0800, Stephen Boyd wrote:
> The ahbix clock can never be turned off in practice. To change the
> rates we need to switch the mux off the M/N counter to an always on
> source (XO), reprogram the M/N counter to get the rate we want and
> finally switch back to the M/N counter. Add a new ops structure
> for this type of clock so that we can set the rate properly.
> 
> Fixes: c99e515a92e9 "clk: qcom: Add IPQ806X LPASS clock controller (LCC) driver"
> Cc: Kenneth Westfield <kwestfie@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> Changes from v1:
>  * Handle the case where clock feeding M/N counter is off
> 
>  drivers/clk/qcom/clk-rcg.c     | 62 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/clk/qcom/clk-rcg.h     |  1 +
>  drivers/clk/qcom/lcc-ipq806x.c |  5 ++--
>  3 files changed, 65 insertions(+), 3 deletions(-)

Verified I2S audio functionality on the Storm board; with and without
firmware audio enabled.

Tested-by: Kenneth Westfield <kwestfie@codeaurora.org>

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2015-03-12  3:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 23:41 [PATCH v2] clk: qcom: Properly change rates for ahbix clock Stephen Boyd
2015-03-06 23:41 ` Stephen Boyd
2015-03-12  0:43 ` Stephen Boyd
2015-03-12  0:43   ` Stephen Boyd
2015-03-12  3:42 ` Kenneth Westfield [this message]
2015-03-12  3:42   ` Kenneth Westfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312034234.GA22530@kwestfie-linux.qualcomm.com \
    --to=kwestfie@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.