From: Ingo Molnar <mingo@kernel.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: akpm@linux-foundation.org, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, arnd@arndb.de, linux-mm@kvack.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
dave.hansen@intel.com, Elliott@hp.com, pebolle@tiscali.nl
Subject: Re: [PATCH 3/3] mtrr, mm, x86: Enhance MTRR checks for KVA huge page mapping
Date: Thu, 12 Mar 2015 12:03:33 +0100 [thread overview]
Message-ID: <20150312110333.GA6898@gmail.com> (raw)
In-Reply-To: <1426092728.17007.380.camel@misato.fc.hp.com>
* Toshi Kani <toshi.kani@hp.com> wrote:
> > Did it perhaps want to be the other way around:
> >
> > if (mtrr_state.have_fixed && (start < 0x1000000)) {
> > ...
> > } else if (start < 0x100000) {
> > ...
> >
> > or did it simply mess up the condition?
>
> I think it was just paranoid to test the same condition twice...
Read the code again, it's _not_ the same condition ...
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: akpm@linux-foundation.org, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, arnd@arndb.de, linux-mm@kvack.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
dave.hansen@intel.com, Elliott@hp.com, pebolle@tiscali.nl
Subject: Re: [PATCH 3/3] mtrr, mm, x86: Enhance MTRR checks for KVA huge page mapping
Date: Thu, 12 Mar 2015 12:03:33 +0100 [thread overview]
Message-ID: <20150312110333.GA6898@gmail.com> (raw)
In-Reply-To: <1426092728.17007.380.camel@misato.fc.hp.com>
* Toshi Kani <toshi.kani@hp.com> wrote:
> > Did it perhaps want to be the other way around:
> >
> > if (mtrr_state.have_fixed && (start < 0x1000000)) {
> > ...
> > } else if (start < 0x100000) {
> > ...
> >
> > or did it simply mess up the condition?
>
> I think it was just paranoid to test the same condition twice...
Read the code again, it's _not_ the same condition ...
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-12 11:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 20:23 [PATCH 0/3] mtrr, mm, x86: Enhance MTRR checks for huge I/O mapping Toshi Kani
2015-03-10 20:23 ` Toshi Kani
2015-03-10 20:23 ` [PATCH 1/3] mm, x86: Document return values of mapping funcs Toshi Kani
2015-03-10 20:23 ` Toshi Kani
2015-03-11 6:30 ` Ingo Molnar
2015-03-11 6:30 ` Ingo Molnar
2015-03-11 15:25 ` Toshi Kani
2015-03-11 15:25 ` Toshi Kani
2015-03-10 20:23 ` [PATCH 2/3] mtrr, x86: Fix MTRR lookup to handle inclusive entry Toshi Kani
2015-03-10 20:23 ` Toshi Kani
2015-03-11 6:32 ` Ingo Molnar
2015-03-11 6:32 ` Ingo Molnar
2015-03-11 15:27 ` Toshi Kani
2015-03-11 15:27 ` Toshi Kani
2015-03-10 20:23 ` [PATCH 3/3] mtrr, mm, x86: Enhance MTRR checks for KVA huge page mapping Toshi Kani
2015-03-10 20:23 ` Toshi Kani
2015-03-11 7:02 ` Ingo Molnar
2015-03-11 7:02 ` Ingo Molnar
2015-03-11 16:52 ` Toshi Kani
2015-03-11 16:52 ` Toshi Kani
2015-03-12 11:03 ` Ingo Molnar [this message]
2015-03-12 11:03 ` Ingo Molnar
2015-03-12 13:58 ` Toshi Kani
2015-03-12 13:58 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312110333.GA6898@gmail.com \
--to=mingo@kernel.org \
--cc=Elliott@hp.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pebolle@tiscali.nl \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.