Re: [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default.

From: Denys Dmytriyenko <denys@ti.com>
To: "Cooper Jr., Franklin" <fcooper@ti.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default.
Date: Thu, 12 Mar 2015 10:00:14 -0400	[thread overview]
Message-ID: <20150312140014.GD24885@edge> (raw)
In-Reply-To: <A2A3AF03-C549-41C8-B3A8-21E46E7BA19C@ti.com>

Actually, it may be a good idea to adopt "screen" MACHINE_FEATURE globally for 
all things graphics (qt, sgx, wayland, etc.) - as currently we do it on 
per-machine/soc basis...

On Thu, Mar 12, 2015 at 01:20:14PM +0000, Cooper Jr., Franklin wrote:
> Honestly there is nothing technically wrong with depending on the screen but 
> I feel that it should be removed from this patchset.
> 
> As of now the machines that doesn't have the screen machine feature set 
> already avoids all the packagegroups that would end up Wayland and Weston.
> 
> If we want to universally pull in graphical packages based on the screen 
> machine feature then I think it would make sense to do it then when it is 
> actually going to do something.
> 
> 
> 
> 
> > On Mar 12, 2015, at 7:56 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> > 
> > * This is done conditional depending if 'screen' is a MACHINE_FEATURE.
> > 
> > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > ---
> > meta-arago-distro/conf/distro/arago.conf |    2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> > index 338d41b..1c14e6f 100644
> > --- a/meta-arago-distro/conf/distro/arago.conf
> > +++ b/meta-arago-distro/conf/distro/arago.conf
> > @@ -22,7 +22,7 @@ NO32LIBS = "0"
> > DISTRO_FEATURES = "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g ipv4 ipv6 pulseaudio ${DISTRO_FEATURES_LIBC}"
> > 
> > # Set additional distro features
> > -DISTRO_FEATURES += "pam"
> > +DISTRO_FEATURES += "pam ${@base_contains('MACHINE_FEATURES', 'screen', 'wayland', '', d)}"
> > 
> > # Set preferred Qt version
> > QT_PROVIDER ?= "qt5"
> > -- 
> > 1.7.9.5
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago