* [PATCH 1/4] packagegroup-*: Include wayland/weston if specified in DISTRO_FEATURES.
2015-03-12 12:55 [PATCH 0/4] Implment the wayland DISTRO_FEATURE Jacob Stiffler
@ 2015-03-12 12:55 ` Jacob Stiffler
2015-03-12 12:55 ` [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa Jacob Stiffler
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Jacob Stiffler @ 2015-03-12 12:55 UTC (permalink / raw)
To: meta-arago
Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
.../packagegroups/packagegroup-arago-qte.bb | 4 ++--
.../packagegroup-arago-tisdk-graphics.bb | 4 ++--
.../packagegroups/packagegroup-arago-tisdk-qte.bb | 4 ++--
.../packagegroups/packagegroup-linaro-tc-test.bb | 5 +++--
4 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-qte.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-qte.bb
index 9618de5..149dfac 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-qte.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-qte.bb
@@ -1,6 +1,6 @@
DESCRIPTION = "Task to add Qt embedded related packages"
LICENSE = "MIT"
-PR = "r8"
+PR = "r9"
inherit packagegroup
@@ -34,7 +34,7 @@ QT5_ESSENTIALS = "\
qtlocation-qmlplugins \
qtmultimedia-plugins \
qtmultimedia-qmlplugins \
- qtwayland-plugins \
+ ${@base_contains('DISTRO_FEATURES', 'wayland', 'qtwayland-plugins', '', d)} \
qt3d-qmlplugins \
qtwebkit-qmlplugins \
qtquick1-plugins \
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
index 74b8417..327a11b 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
@@ -1,6 +1,6 @@
DESCRIPTION = "Task to install graphics binaries"
LICENSE = "MIT"
-PR = "r7"
+PR = "r8"
inherit packagegroup
@@ -43,6 +43,6 @@ GRAPHICS_RDEPENDS_omap-a15 = "\
# omapdrm-pvr
RDEPENDS_${PN} = "\
- ${@base_conditional('QT_PROVIDER', 'qt4e', "", "${GRAPHICS_WESTON}", d)} \
+ ${@base_contains('DISTRO_FEATURES', 'wayland', "${GRAPHICS_WESTON}", '', d)} \
${GRAPHICS_RDEPENDS} \
"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb
index eeb32fb..ac84008 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-qte.bb
@@ -1,6 +1,6 @@
DESCRIPTION = "Task to add Qt embedded related packages"
LICENSE = "MIT"
-PR = "r11"
+PR = "r12"
inherit packagegroup
@@ -22,7 +22,7 @@ QT5_DEMOS = "\
qtlocation-examples \
qtmultimedia-examples \
qtscript-examples \
- qtwayland-examples \
+ ${@base_contains('DISTRO_FEATURES', 'wayland', 'qtwayland-examples', '', d)} \
qtwebkit-examples-examples \
qtquick1-examples \
"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-linaro-tc-test.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-linaro-tc-test.bb
index 8fd863e..68e7ab0 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-linaro-tc-test.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-linaro-tc-test.bb
@@ -1,6 +1,8 @@
DESCRIPTION = "Group of packages to build with Linaro toolchain for testing"
LICENSE = "MIT"
+PR = "r1"
+
inherit packagegroup
RDEPENDS_${PN} = "\
@@ -10,8 +12,7 @@ RDEPENDS_${PN} = "\
bash \
coreutils \
apache \
- wayland \
- weston \
+ ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland weston', '', d)} \
gstreamer \
openssl \
openssh \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa.
2015-03-12 12:55 [PATCH 0/4] Implment the wayland DISTRO_FEATURE Jacob Stiffler
2015-03-12 12:55 ` [PATCH 1/4] packagegroup-*: Include wayland/weston if specified in DISTRO_FEATURES Jacob Stiffler
@ 2015-03-12 12:55 ` Jacob Stiffler
2015-03-12 13:55 ` Denys Dmytriyenko
2015-03-12 12:55 ` [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default Jacob Stiffler
2015-03-12 12:55 ` [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand Jacob Stiffler
3 siblings, 1 reply; 18+ messages in thread
From: Jacob Stiffler @ 2015-03-12 12:55 UTC (permalink / raw)
To: meta-arago
* If wayland is in DISTRO_FEATURES, then configure '-qpa wayland'
* Otherwise configure '-qpa eglfs'
Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh | 1 -
.../recipes-qt/qt5/qtbase_5.4.1.bbappend | 9 ++++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
index 1e8c196..f888d50 100644
--- a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
+++ b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
@@ -2,4 +2,3 @@
### QT Environment Variables ###
export QT_QPA_GENERIC_PLUGINS=Auto
-export QT_QPA_PLATFORM=wayland
diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
index a466581..5a00800 100644
--- a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
+++ b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
@@ -1,13 +1,16 @@
FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
GLES_EXTRA_DEPS = ""
-GLES_EXTRA_DEPS_omap-a15 = "libdrm wayland"
+GLES_EXTRA_DEPS_omap-a15 = " \
+ libdrm \
+ ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
+"
PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}"
-PR_append = "-arago3"
+PR_append = "-arago4"
-QT_CONFIG_FLAGS += "-qpa wayland"
+QT_CONFIG_FLAGS += "-qpa ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}"
SRC_URI += "file://qt_env.sh"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa.
2015-03-12 12:55 ` [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa Jacob Stiffler
@ 2015-03-12 13:55 ` Denys Dmytriyenko
2015-03-12 13:58 ` Stiffler, Jacob
0 siblings, 1 reply; 18+ messages in thread
From: Denys Dmytriyenko @ 2015-03-12 13:55 UTC (permalink / raw)
To: Jacob Stiffler; +Cc: meta-arago
On Thu, Mar 12, 2015 at 08:55:55AM -0400, Jacob Stiffler wrote:
> * If wayland is in DISTRO_FEATURES, then configure '-qpa wayland'
> * Otherwise configure '-qpa eglfs'
>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh | 1 -
> .../recipes-qt/qt5/qtbase_5.4.1.bbappend | 9 ++++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> index 1e8c196..f888d50 100644
> --- a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> +++ b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> @@ -2,4 +2,3 @@
>
> ### QT Environment Variables ###
> export QT_QPA_GENERIC_PLUGINS=Auto
> -export QT_QPA_PLATFORM=wayland
> diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> index a466581..5a00800 100644
> --- a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> +++ b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> @@ -1,13 +1,16 @@
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> GLES_EXTRA_DEPS = ""
> -GLES_EXTRA_DEPS_omap-a15 = "libdrm wayland"
> +GLES_EXTRA_DEPS_omap-a15 = " \
> + libdrm \
> + ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
> +"
I meant to comment to the previous revision about this part above ^^^
I don't think it will work (not that it will be tested) - the way OMAP5 GFX is
built, it has hardcoded dependency on wayland libs, hence it's added above...
That said, I'm not sure you can get eglfs on OMAP5 platforms working cleanly
w/o any wayland libs. But aren't you only doing it for AM3/4 anyway?
> PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}"
>
> -PR_append = "-arago3"
> +PR_append = "-arago4"
>
> -QT_CONFIG_FLAGS += "-qpa wayland"
> +QT_CONFIG_FLAGS += "-qpa ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}"
>
> SRC_URI += "file://qt_env.sh"
>
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa.
2015-03-12 13:55 ` Denys Dmytriyenko
@ 2015-03-12 13:58 ` Stiffler, Jacob
2015-03-12 14:13 ` Denys Dmytriyenko
0 siblings, 1 reply; 18+ messages in thread
From: Stiffler, Jacob @ 2015-03-12 13:58 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org
I'm not sure of the history, it just seemed more complete to only depend on wayland if wayland is a feature.
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, March 12, 2015 9:56 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa.
On Thu, Mar 12, 2015 at 08:55:55AM -0400, Jacob Stiffler wrote:
> * If wayland is in DISTRO_FEATURES, then configure '-qpa wayland'
> * Otherwise configure '-qpa eglfs'
>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh | 1 -
> .../recipes-qt/qt5/qtbase_5.4.1.bbappend | 9 ++++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> index 1e8c196..f888d50 100644
> --- a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> +++ b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> @@ -2,4 +2,3 @@
>
> ### QT Environment Variables ###
> export QT_QPA_GENERIC_PLUGINS=Auto
> -export QT_QPA_PLATFORM=wayland
> diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> index a466581..5a00800 100644
> --- a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> +++ b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> @@ -1,13 +1,16 @@
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> GLES_EXTRA_DEPS = ""
> -GLES_EXTRA_DEPS_omap-a15 = "libdrm wayland"
> +GLES_EXTRA_DEPS_omap-a15 = " \
> + libdrm \
> + ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)}
> +\ "
I meant to comment to the previous revision about this part above ^^^ I don't think it will work (not that it will be tested) - the way OMAP5 GFX is built, it has hardcoded dependency on wayland libs, hence it's added above...
That said, I'm not sure you can get eglfs on OMAP5 platforms working cleanly w/o any wayland libs. But aren't you only doing it for AM3/4 anyway?
> PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}"
>
> -PR_append = "-arago3"
> +PR_append = "-arago4"
>
> -QT_CONFIG_FLAGS += "-qpa wayland"
> +QT_CONFIG_FLAGS += "-qpa ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}"
>
> SRC_URI += "file://qt_env.sh"
>
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa.
2015-03-12 13:58 ` Stiffler, Jacob
@ 2015-03-12 14:13 ` Denys Dmytriyenko
0 siblings, 0 replies; 18+ messages in thread
From: Denys Dmytriyenko @ 2015-03-12 14:13 UTC (permalink / raw)
To: Stiffler, Jacob; +Cc: meta-arago@arago-project.org
On Thu, Mar 12, 2015 at 09:58:38AM -0400, Stiffler, Jacob wrote:
> I'm not sure of the history, it just seemed more complete to only depend on
> wayland if wayland is a feature.
Yeah, it makes sense logically, but unfortunately the way GFX SDK is built it
will break w/o wayland libs, I'm afraid.
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, March 12, 2015 9:56 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa.
>
> On Thu, Mar 12, 2015 at 08:55:55AM -0400, Jacob Stiffler wrote:
> > * If wayland is in DISTRO_FEATURES, then configure '-qpa wayland'
> > * Otherwise configure '-qpa eglfs'
> >
> > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > ---
> > meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh | 1 -
> > .../recipes-qt/qt5/qtbase_5.4.1.bbappend | 9 ++++++---
> > 2 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> > b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> > index 1e8c196..f888d50 100644
> > --- a/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> > +++ b/meta-arago-distro/recipes-qt/qt5/qtbase/qt_env.sh
> > @@ -2,4 +2,3 @@
> >
> > ### QT Environment Variables ###
> > export QT_QPA_GENERIC_PLUGINS=Auto
> > -export QT_QPA_PLATFORM=wayland
> > diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> > b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> > index a466581..5a00800 100644
> > --- a/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> > +++ b/meta-arago-distro/recipes-qt/qt5/qtbase_5.4.1.bbappend
> > @@ -1,13 +1,16 @@
> > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> > GLES_EXTRA_DEPS = ""
> > -GLES_EXTRA_DEPS_omap-a15 = "libdrm wayland"
> > +GLES_EXTRA_DEPS_omap-a15 = " \
> > + libdrm \
> > + ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)}
> > +\ "
>
> I meant to comment to the previous revision about this part above ^^^ I don't think it will work (not that it will be tested) - the way OMAP5 GFX is built, it has hardcoded dependency on wayland libs, hence it's added above...
> That said, I'm not sure you can get eglfs on OMAP5 platforms working cleanly w/o any wayland libs. But aren't you only doing it for AM3/4 anyway?
>
>
> > PACKAGECONFIG[gles2] = "-opengl es2 -eglfs,,virtual/libgles2 virtual/egl ${GLES_EXTRA_DEPS}"
> >
> > -PR_append = "-arago3"
> > +PR_append = "-arago4"
> >
> > -QT_CONFIG_FLAGS += "-qpa wayland"
> > +QT_CONFIG_FLAGS += "-qpa ${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', 'eglfs', d)}"
> >
> > SRC_URI += "file://qt_env.sh"
> >
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default.
2015-03-12 12:55 [PATCH 0/4] Implment the wayland DISTRO_FEATURE Jacob Stiffler
2015-03-12 12:55 ` [PATCH 1/4] packagegroup-*: Include wayland/weston if specified in DISTRO_FEATURES Jacob Stiffler
2015-03-12 12:55 ` [PATCH 2/4] qtbase: Use DISTRO_FEATURES to set appropriate qpa Jacob Stiffler
@ 2015-03-12 12:55 ` Jacob Stiffler
2015-03-12 13:20 ` Cooper Jr., Franklin
2015-03-12 12:55 ` [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand Jacob Stiffler
3 siblings, 1 reply; 18+ messages in thread
From: Jacob Stiffler @ 2015-03-12 12:55 UTC (permalink / raw)
To: meta-arago
* This is done conditional depending if 'screen' is a MACHINE_FEATURE.
Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
meta-arago-distro/conf/distro/arago.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
index 338d41b..1c14e6f 100644
--- a/meta-arago-distro/conf/distro/arago.conf
+++ b/meta-arago-distro/conf/distro/arago.conf
@@ -22,7 +22,7 @@ NO32LIBS = "0"
DISTRO_FEATURES = "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g ipv4 ipv6 pulseaudio ${DISTRO_FEATURES_LIBC}"
# Set additional distro features
-DISTRO_FEATURES += "pam"
+DISTRO_FEATURES += "pam ${@base_contains('MACHINE_FEATURES', 'screen', 'wayland', '', d)}"
# Set preferred Qt version
QT_PROVIDER ?= "qt5"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default.
2015-03-12 12:55 ` [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default Jacob Stiffler
@ 2015-03-12 13:20 ` Cooper Jr., Franklin
2015-03-12 13:24 ` Cooper Jr., Franklin
2015-03-12 14:00 ` Denys Dmytriyenko
0 siblings, 2 replies; 18+ messages in thread
From: Cooper Jr., Franklin @ 2015-03-12 13:20 UTC (permalink / raw)
To: Stiffler, Jacob; +Cc: meta-arago@arago-project.org
Honestly there is nothing technically wrong with depending on the screen but I feel that it should be removed from this patchset.
As of now the machines that doesn't have the screen machine feature set already avoids all the packagegroups that would end up Wayland and Weston.
If we want to universally pull in graphical packages based on the screen machine feature then I think it would make sense to do it then when it is actually going to do something.
> On Mar 12, 2015, at 7:56 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>
> * This is done conditional depending if 'screen' is a MACHINE_FEATURE.
>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> meta-arago-distro/conf/distro/arago.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> index 338d41b..1c14e6f 100644
> --- a/meta-arago-distro/conf/distro/arago.conf
> +++ b/meta-arago-distro/conf/distro/arago.conf
> @@ -22,7 +22,7 @@ NO32LIBS = "0"
> DISTRO_FEATURES = "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g ipv4 ipv6 pulseaudio ${DISTRO_FEATURES_LIBC}"
>
> # Set additional distro features
> -DISTRO_FEATURES += "pam"
> +DISTRO_FEATURES += "pam ${@base_contains('MACHINE_FEATURES', 'screen', 'wayland', '', d)}"
>
> # Set preferred Qt version
> QT_PROVIDER ?= "qt5"
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default.
2015-03-12 13:20 ` Cooper Jr., Franklin
@ 2015-03-12 13:24 ` Cooper Jr., Franklin
2015-03-12 14:00 ` Denys Dmytriyenko
1 sibling, 0 replies; 18+ messages in thread
From: Cooper Jr., Franklin @ 2015-03-12 13:24 UTC (permalink / raw)
To: Stiffler, Jacob; +Cc: meta-arago@arago-project.org
Also this patch really should have been the first one in your patchset. Since based on the patch order your temporarily preventing any machine from including Wayland and Weston. This patch fixes it but you generally want to avoid the issue at all.
> On Mar 12, 2015, at 8:20 AM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
>
> Honestly there is nothing technically wrong with depending on the screen but I feel that it should be removed from this patchset.
>
> As of now the machines that doesn't have the screen machine feature set already avoids all the packagegroups that would end up Wayland and Weston.
>
> If we want to universally pull in graphical packages based on the screen machine feature then I think it would make sense to do it then when it is actually going to do something.
>
>
>
>
>> On Mar 12, 2015, at 7:56 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>>
>> * This is done conditional depending if 'screen' is a MACHINE_FEATURE.
>>
>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>> ---
>> meta-arago-distro/conf/distro/arago.conf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
>> index 338d41b..1c14e6f 100644
>> --- a/meta-arago-distro/conf/distro/arago.conf
>> +++ b/meta-arago-distro/conf/distro/arago.conf
>> @@ -22,7 +22,7 @@ NO32LIBS = "0"
>> DISTRO_FEATURES = "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g ipv4 ipv6 pulseaudio ${DISTRO_FEATURES_LIBC}"
>>
>> # Set additional distro features
>> -DISTRO_FEATURES += "pam"
>> +DISTRO_FEATURES += "pam ${@base_contains('MACHINE_FEATURES', 'screen', 'wayland', '', d)}"
>>
>> # Set preferred Qt version
>> QT_PROVIDER ?= "qt5"
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default.
2015-03-12 13:20 ` Cooper Jr., Franklin
2015-03-12 13:24 ` Cooper Jr., Franklin
@ 2015-03-12 14:00 ` Denys Dmytriyenko
1 sibling, 0 replies; 18+ messages in thread
From: Denys Dmytriyenko @ 2015-03-12 14:00 UTC (permalink / raw)
To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org
Actually, it may be a good idea to adopt "screen" MACHINE_FEATURE globally for
all things graphics (qt, sgx, wayland, etc.) - as currently we do it on
per-machine/soc basis...
On Thu, Mar 12, 2015 at 01:20:14PM +0000, Cooper Jr., Franklin wrote:
> Honestly there is nothing technically wrong with depending on the screen but
> I feel that it should be removed from this patchset.
>
> As of now the machines that doesn't have the screen machine feature set
> already avoids all the packagegroups that would end up Wayland and Weston.
>
> If we want to universally pull in graphical packages based on the screen
> machine feature then I think it would make sense to do it then when it is
> actually going to do something.
>
>
>
>
> > On Mar 12, 2015, at 7:56 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> >
> > * This is done conditional depending if 'screen' is a MACHINE_FEATURE.
> >
> > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > ---
> > meta-arago-distro/conf/distro/arago.conf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> > index 338d41b..1c14e6f 100644
> > --- a/meta-arago-distro/conf/distro/arago.conf
> > +++ b/meta-arago-distro/conf/distro/arago.conf
> > @@ -22,7 +22,7 @@ NO32LIBS = "0"
> > DISTRO_FEATURES = "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g ipv4 ipv6 pulseaudio ${DISTRO_FEATURES_LIBC}"
> >
> > # Set additional distro features
> > -DISTRO_FEATURES += "pam"
> > +DISTRO_FEATURES += "pam ${@base_contains('MACHINE_FEATURES', 'screen', 'wayland', '', d)}"
> >
> > # Set preferred Qt version
> > QT_PROVIDER ?= "qt5"
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 12:55 [PATCH 0/4] Implment the wayland DISTRO_FEATURE Jacob Stiffler
` (2 preceding siblings ...)
2015-03-12 12:55 ` [PATCH 3/4] arago.conf: Include wayland in DISTRO_FEATURES by default Jacob Stiffler
@ 2015-03-12 12:55 ` Jacob Stiffler
2015-03-12 13:56 ` Denys Dmytriyenko
3 siblings, 1 reply; 18+ messages in thread
From: Jacob Stiffler @ 2015-03-12 12:55 UTC (permalink / raw)
To: meta-arago
* Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
* For now, use sitara-linux-ti-staging
* and remove wayland feature for ti33x and ti43x soc families.
Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
.../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
diff --git a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
new file mode 100644
index 0000000..5eab952
--- /dev/null
+++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
@@ -0,0 +1,35 @@
+ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
+
+# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
+DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
+DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
+
+PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
+PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
+PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
+
+# To create newlines in the message \n is used and the slash must be escaped
+# to function properly
+
+SRCIPK_GIT_COMMIT_MESSAGE = "\
+Create local branch\\n\
+\\n\
+The below commit is used for this local branch and is the one used by\\n\
+this sdk:\\n\
+${SRCREV}."
+
+SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE ="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
+To reduce the size of the SDK installer only a portion of the git commit\\n\
+history has been preserved. Also links to remote branches and tags do\\n\
+not exist in this copy of the repository.\\n\
+To fix this please run the unshallow-repositories.sh\\n\
+script located in the sdk\'s bin directory\\n\
+\\n\
+The script may take several minutes but you will then have a full copy of\\n\
+the git repository including its entire git history.\\n"
+
+SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
+SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
+
+SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
+SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 12:55 ` [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand Jacob Stiffler
@ 2015-03-12 13:56 ` Denys Dmytriyenko
2015-03-12 14:00 ` Stiffler, Jacob
0 siblings, 1 reply; 18+ messages in thread
From: Denys Dmytriyenko @ 2015-03-12 13:56 UTC (permalink / raw)
To: Jacob Stiffler; +Cc: meta-arago
On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote:
> * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
> * For now, use sitara-linux-ti-staging
> * and remove wayland feature for ti33x and ti43x soc families.
>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> .../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
>
> diff --git a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> new file mode 100644
> index 0000000..5eab952
> --- /dev/null
> +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> @@ -0,0 +1,35 @@
> +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
> +
> +# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
> +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
Usually you want immediate assignment here. But I have my doubts it will work
reliably either way, when done like that...
> +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
> +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
> +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
> +
> +# To create newlines in the message \n is used and the slash must be escaped
> +# to function properly
> +
> +SRCIPK_GIT_COMMIT_MESSAGE = "\
> +Create local branch\\n\
> +\\n\
> +The below commit is used for this local branch and is the one used by\\n\
> +this sdk:\\n\
> +${SRCREV}."
> +
> +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE ="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
> +To reduce the size of the SDK installer only a portion of the git commit\\n\
> +history has been preserved. Also links to remote branches and tags do\\n\
> +not exist in this copy of the repository.\\n\
> +To fix this please run the unshallow-repositories.sh\\n\
> +script located in the sdk\'s bin directory\\n\
> +\\n\
> +The script may take several minutes but you will then have a full copy of\\n\
> +the git repository including its entire git history.\\n"
> +
> +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
> +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
> +
> +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
> +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 13:56 ` Denys Dmytriyenko
@ 2015-03-12 14:00 ` Stiffler, Jacob
2015-03-12 14:20 ` Denys Dmytriyenko
0 siblings, 1 reply; 18+ messages in thread
From: Stiffler, Jacob @ 2015-03-12 14:00 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org
What would you suggest? That wayland be controlled as a feature from each branding file? Or a new variable introduced that arago.conf can check to decide if wayland should be added to the DISTRO_FEATURES?
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, March 12, 2015 9:57 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote:
> * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
> * For now, use sitara-linux-ti-staging
> * and remove wayland feature for ti33x and ti43x soc families.
>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> .../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644
> meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
>
> diff --git
> a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> new file mode 100644
> index 0000000..5eab952
> --- /dev/null
> +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> @@ -0,0 +1,35 @@
> +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
> +
> +# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
> +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
Usually you want immediate assignment here. But I have my doubts it will work reliably either way, when done like that...
> +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
> +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
> +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
> +
> +# To create newlines in the message \n is used and the slash must be escaped
> +# to function properly
> +
> +SRCIPK_GIT_COMMIT_MESSAGE = "\
> +Create local branch\\n\
> +\\n\
> +The below commit is used for this local branch and is the one used by\\n\
> +this sdk:\\n\
> +${SRCREV}."
> +
> +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE ="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
> +To reduce the size of the SDK installer only a portion of the git commit\\n\
> +history has been preserved. Also links to remote branches and tags do\\n\
> +not exist in this copy of the repository.\\n\
> +To fix this please run the unshallow-repositories.sh\\n\
> +script located in the sdk\'s bin directory\\n\
> +\\n\
> +The script may take several minutes but you will then have a full copy of\\n\
> +the git repository including its entire git history.\\n"
> +
> +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
> +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
> +
> +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
> +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 14:00 ` Stiffler, Jacob
@ 2015-03-12 14:20 ` Denys Dmytriyenko
2015-03-12 14:25 ` Stiffler, Jacob
0 siblings, 1 reply; 18+ messages in thread
From: Denys Dmytriyenko @ 2015-03-12 14:20 UTC (permalink / raw)
To: Stiffler, Jacob; +Cc: meta-arago@arago-project.org
On Thu, Mar 12, 2015 at 10:00:35AM -0400, Stiffler, Jacob wrote:
> What would you suggest? That wayland be controlled as a feature from each
> branding file? Or a new variable introduced that arago.conf can check to
> decide if wayland should be added to the DISTRO_FEATURES?
Leave it like that for now - we'll see if we get any problems...
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, March 12, 2015 9:57 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
>
> On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote:
> > * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
> > * For now, use sitara-linux-ti-staging
> > * and remove wayland feature for ti33x and ti43x soc families.
> >
> > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > ---
> > .../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644
> > meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> >
> > diff --git
> > a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > new file mode 100644
> > index 0000000..5eab952
> > --- /dev/null
> > +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > @@ -0,0 +1,35 @@
> > +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
> > +
> > +# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
> > +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> > +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
>
> Usually you want immediate assignment here. But I have my doubts it will work reliably either way, when done like that...
>
>
> > +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
> > +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
> > +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
> > +
> > +# To create newlines in the message \n is used and the slash must be escaped
> > +# to function properly
> > +
> > +SRCIPK_GIT_COMMIT_MESSAGE = "\
> > +Create local branch\\n\
> > +\\n\
> > +The below commit is used for this local branch and is the one used by\\n\
> > +this sdk:\\n\
> > +${SRCREV}."
> > +
> > +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE ="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
> > +To reduce the size of the SDK installer only a portion of the git commit\\n\
> > +history has been preserved. Also links to remote branches and tags do\\n\
> > +not exist in this copy of the repository.\\n\
> > +To fix this please run the unshallow-repositories.sh\\n\
> > +script located in the sdk\'s bin directory\\n\
> > +\\n\
> > +The script may take several minutes but you will then have a full copy of\\n\
> > +the git repository including its entire git history.\\n"
> > +
> > +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
> > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
> > +
> > +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
> > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 14:20 ` Denys Dmytriyenko
@ 2015-03-12 14:25 ` Stiffler, Jacob
2015-03-12 14:30 ` Denys Dmytriyenko
0 siblings, 1 reply; 18+ messages in thread
From: Stiffler, Jacob @ 2015-03-12 14:25 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org
I've been testing the patches since submitting the patches (wanted to get these comments as soon as I could). It seems that this oe_filter_out method is not working as expected...
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, March 12, 2015 10:20 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
On Thu, Mar 12, 2015 at 10:00:35AM -0400, Stiffler, Jacob wrote:
> What would you suggest? That wayland be controlled as a feature from
> each branding file? Or a new variable introduced that arago.conf can
> check to decide if wayland should be added to the DISTRO_FEATURES?
Leave it like that for now - we'll see if we get any problems...
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, March 12, 2015 9:57 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
>
> On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote:
> > * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
> > * For now, use sitara-linux-ti-staging
> > * and remove wayland feature for ti33x and ti43x soc families.
> >
> > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > ---
> > .../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644
> > meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> >
> > diff --git
> > a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > new file mode 100644
> > index 0000000..5eab952
> > --- /dev/null
> > +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk.i
> > +++ nc
> > @@ -0,0 +1,35 @@
> > +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
> > +
> > +# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
> > +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> > +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
>
> Usually you want immediate assignment here. But I have my doubts it will work reliably either way, when done like that...
>
>
> > +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
> > +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
> > +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
> > +
> > +# To create newlines in the message \n is used and the slash must
> > +be escaped # to function properly
> > +
> > +SRCIPK_GIT_COMMIT_MESSAGE = "\
> > +Create local branch\\n\
> > +\\n\
> > +The below commit is used for this local branch and is the one used
> > +by\\n\ this sdk:\\n\ ${SRCREV}."
> > +
> > +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE
> > +="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
> > +To reduce the size of the SDK installer only a portion of the git
> > +commit\\n\ history has been preserved. Also links to remote
> > +branches and tags do\\n\ not exist in this copy of the
> > +repository.\\n\ To fix this please run the
> > +unshallow-repositories.sh\\n\ script located in the sdk\'s bin
> > +directory\\n\ \\n\ The script may take several minutes but you will
> > +then have a full copy of\\n\ the git repository including its
> > +entire git history.\\n"
> > +
> > +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
> > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
> > +
> > +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
> > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 14:25 ` Stiffler, Jacob
@ 2015-03-12 14:30 ` Denys Dmytriyenko
2015-03-12 17:29 ` Stiffler, Jacob
0 siblings, 1 reply; 18+ messages in thread
From: Denys Dmytriyenko @ 2015-03-12 14:30 UTC (permalink / raw)
To: Stiffler, Jacob; +Cc: meta-arago@arago-project.org
On Thu, Mar 12, 2015 at 10:25:43AM -0400, Stiffler, Jacob wrote:
> I've been testing the patches since submitting the patches (wanted to get
> these comments as soon as I could). It seems that this oe_filter_out method
> is not working as expected...
Try using := when doing filter_out()...
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, March 12, 2015 10:20 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
>
> On Thu, Mar 12, 2015 at 10:00:35AM -0400, Stiffler, Jacob wrote:
> > What would you suggest? That wayland be controlled as a feature from
> > each branding file? Or a new variable introduced that arago.conf can
> > check to decide if wayland should be added to the DISTRO_FEATURES?
>
> Leave it like that for now - we'll see if we get any problems...
>
>
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Thursday, March 12, 2015 9:57 AM
> > To: Stiffler, Jacob
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
> >
> > On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote:
> > > * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
> > > * For now, use sitara-linux-ti-staging
> > > * and remove wayland feature for ti33x and ti43x soc families.
> > >
> > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > > ---
> > > .../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
> > > 1 file changed, 35 insertions(+)
> > > create mode 100644
> > > meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > >
> > > diff --git
> > > a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > > b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > > new file mode 100644
> > > index 0000000..5eab952
> > > --- /dev/null
> > > +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk.i
> > > +++ nc
> > > @@ -0,0 +1,35 @@
> > > +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
> > > +
> > > +# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
> > > +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> > > +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> >
> > Usually you want immediate assignment here. But I have my doubts it will
> > work reliably either way, when done like that...
> >
> >
> > > +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
> > > +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
> > > +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
> > > +
> > > +# To create newlines in the message \n is used and the slash must
> > > +be escaped # to function properly
> > > +
> > > +SRCIPK_GIT_COMMIT_MESSAGE = "\
> > > +Create local branch\\n\
> > > +\\n\
> > > +The below commit is used for this local branch and is the one used
> > > +by\\n\ this sdk:\\n\ ${SRCREV}."
> > > +
> > > +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE
> > > +="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
> > > +To reduce the size of the SDK installer only a portion of the git
> > > +commit\\n\ history has been preserved. Also links to remote
> > > +branches and tags do\\n\ not exist in this copy of the
> > > +repository.\\n\ To fix this please run the
> > > +unshallow-repositories.sh\\n\ script located in the sdk\'s bin
> > > +directory\\n\ \\n\ The script may take several minutes but you will
> > > +then have a full copy of\\n\ the git repository including its
> > > +entire git history.\\n"
> > > +
> > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
> > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
> > > +
> > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
> > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
> > > --
> > > 1.7.9.5
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 14:30 ` Denys Dmytriyenko
@ 2015-03-12 17:29 ` Stiffler, Jacob
2015-03-12 17:34 ` Denys Dmytriyenko
0 siblings, 1 reply; 18+ messages in thread
From: Stiffler, Jacob @ 2015-03-12 17:29 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org
It appears that doing 'DISTRO_FEATURES_remove_ti43x = "wayland"' will work.
Do you suspect any issues with this?
Thanks,
Jake
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, March 12, 2015 10:31 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
On Thu, Mar 12, 2015 at 10:25:43AM -0400, Stiffler, Jacob wrote:
> I've been testing the patches since submitting the patches (wanted to
> get these comments as soon as I could). It seems that this
> oe_filter_out method is not working as expected...
Try using := when doing filter_out()...
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, March 12, 2015 10:20 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
>
> On Thu, Mar 12, 2015 at 10:00:35AM -0400, Stiffler, Jacob wrote:
> > What would you suggest? That wayland be controlled as a feature from
> > each branding file? Or a new variable introduced that arago.conf can
> > check to decide if wayland should be added to the DISTRO_FEATURES?
>
> Leave it like that for now - we'll see if we get any problems...
>
>
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Thursday, March 12, 2015 9:57 AM
> > To: Stiffler, Jacob
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
> >
> > On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote:
> > > * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
> > > * For now, use sitara-linux-ti-staging
> > > * and remove wayland feature for ti33x and ti43x soc families.
> > >
> > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > > ---
> > > .../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
> > > 1 file changed, 35 insertions(+)
> > > create mode 100644
> > > meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > >
> > > diff --git
> > > a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > > b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > > new file mode 100644
> > > index 0000000..5eab952
> > > --- /dev/null
> > > +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk
> > > +++ .i
> > > +++ nc
> > > @@ -0,0 +1,35 @@
> > > +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
> > > +
> > > +# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
> > > +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> > > +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> >
> > Usually you want immediate assignment here. But I have my doubts it
> > will work reliably either way, when done like that...
> >
> >
> > > +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
> > > +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
> > > +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
> > > +
> > > +# To create newlines in the message \n is used and the slash must
> > > +be escaped # to function properly
> > > +
> > > +SRCIPK_GIT_COMMIT_MESSAGE = "\
> > > +Create local branch\\n\
> > > +\\n\
> > > +The below commit is used for this local branch and is the one
> > > +used by\\n\ this sdk:\\n\ ${SRCREV}."
> > > +
> > > +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE
> > > +="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
> > > +To reduce the size of the SDK installer only a portion of the git
> > > +commit\\n\ history has been preserved. Also links to remote
> > > +branches and tags do\\n\ not exist in this copy of the
> > > +repository.\\n\ To fix this please run the
> > > +unshallow-repositories.sh\\n\ script located in the sdk\'s bin
> > > +directory\\n\ \\n\ The script may take several minutes but you
> > > +will then have a full copy of\\n\ the git repository including
> > > +its entire git history.\\n"
> > > +
> > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
> > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
> > > +
> > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
> > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
> > > --
> > > 1.7.9.5
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
2015-03-12 17:29 ` Stiffler, Jacob
@ 2015-03-12 17:34 ` Denys Dmytriyenko
0 siblings, 0 replies; 18+ messages in thread
From: Denys Dmytriyenko @ 2015-03-12 17:34 UTC (permalink / raw)
To: Stiffler, Jacob; +Cc: meta-arago@arago-project.org
That's a better approach anyway.
On Thu, Mar 12, 2015 at 01:29:06PM -0400, Stiffler, Jacob wrote:
> It appears that doing 'DISTRO_FEATURES_remove_ti43x = "wayland"' will work.
>
> Do you suspect any issues with this?
>
> Thanks,
> Jake
>
>
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, March 12, 2015 10:31 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
>
> On Thu, Mar 12, 2015 at 10:25:43AM -0400, Stiffler, Jacob wrote:
> > I've been testing the patches since submitting the patches (wanted to
> > get these comments as soon as I could). It seems that this
> > oe_filter_out method is not working as expected...
>
> Try using := when doing filter_out()...
>
>
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Thursday, March 12, 2015 10:20 AM
> > To: Stiffler, Jacob
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
> >
> > On Thu, Mar 12, 2015 at 10:00:35AM -0400, Stiffler, Jacob wrote:
> > > What would you suggest? That wayland be controlled as a feature from
> > > each branding file? Or a new variable introduced that arago.conf can
> > > check to decide if wayland should be added to the DISTRO_FEATURES?
> >
> > Leave it like that for now - we'll see if we get any problems...
> >
> >
> > > -----Original Message-----
> > > From: Dmytriyenko, Denys
> > > Sent: Thursday, March 12, 2015 9:57 AM
> > > To: Stiffler, Jacob
> > > Cc: meta-arago@arago-project.org
> > > Subject: Re: [meta-arago] [PATCH 4/4] branding-processor-sdk: Add processor-sdk brand.
> > >
> > > On Thu, Mar 12, 2015 at 08:55:57AM -0400, Jacob Stiffler wrote:
> > > > * Set ARAGO_TISDK_IMAGE to "processor-sdk-linux-image"
> > > > * For now, use sitara-linux-ti-staging
> > > > * and remove wayland feature for ti33x and ti43x soc families.
> > > >
> > > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > > > ---
> > > > .../conf/distro/include/branding-processor-sdk.inc | 35 ++++++++++++++++++++
> > > > 1 file changed, 35 insertions(+)
> > > > create mode 100644
> > > > meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > > >
> > > > diff --git
> > > > a/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > > > b/meta-arago-distro/conf/distro/include/branding-processor-sdk.inc
> > > > new file mode 100644
> > > > index 0000000..5eab952
> > > > --- /dev/null
> > > > +++ b/meta-arago-distro/conf/distro/include/branding-processor-sdk
> > > > +++ .i
> > > > +++ nc
> > > > @@ -0,0 +1,35 @@
> > > > +ARAGO_TISDK_IMAGE = "processor-sdk-linux-image"
> > > > +
> > > > +# Remove wayland from ti33x and ti43x DISTRO_FEATURES.
> > > > +DIRSTO_FEATURES_ti33x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> > > > +DIRSTO_FEATURES_ti43x = "${@oe_filter_out('DISTRO_FEATURES', 'wayland', d)}"
> > >
> > > Usually you want immediate assignment here. But I have my doubts it
> > > will work reliably either way, when done like that...
> > >
> > >
> > > > +PREFERRED_PROVIDER_virtual/kernel_am335x-evm = "sitara-linux-ti-staging"
> > > > +PREFERRED_PROVIDER_virtual/kernel_am437x-evm = "sitara-linux-ti-staging"
> > > > +PREFERRED_VERSION_sitara-linux-ti-staging = "3.14%"
> > > > +
> > > > +# To create newlines in the message \n is used and the slash must
> > > > +be escaped # to function properly
> > > > +
> > > > +SRCIPK_GIT_COMMIT_MESSAGE = "\
> > > > +Create local branch\\n\
> > > > +\\n\
> > > > +The below commit is used for this local branch and is the one
> > > > +used by\\n\ this sdk:\\n\ ${SRCREV}."
> > > > +
> > > > +SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE
> > > > +="${SRCIPK_GIT_COMMIT_MESSAGE}\\n\\n\
> > > > +To reduce the size of the SDK installer only a portion of the git
> > > > +commit\\n\ history has been preserved. Also links to remote
> > > > +branches and tags do\\n\ not exist in this copy of the
> > > > +repository.\\n\ To fix this please run the
> > > > +unshallow-repositories.sh\\n\ script located in the sdk\'s bin
> > > > +directory\\n\ \\n\ The script may take several minutes but you
> > > > +will then have a full copy of\\n\ the git repository including
> > > > +its entire git history.\\n"
> > > > +
> > > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-sitara-linux-ti-staging = "processor-sdk-1.0"
> > > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-sitara-linux-ti-staging = "${SRCIPK_SHALLOW_GIT_COMMIT_MESSAGE}"
> > > > +
> > > > +SRCIPK_CUSTOM_GIT_BRANCH_pn-u-boot-ti-staging = "processor-sdk-1.0"
> > > > +SRCIPK_CUSTOM_GIT_MESSAGE_pn-u-boot-ti-staging = "${SRCIPK_GIT_COMMIT_MESSAGE}"
> > > > --
> > > > 1.7.9.5
> > > >
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 18+ messages in thread