From: Sam Ravnborg <sam@ravnborg.org>
To: Scott Wood <scottwood@freescale.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 12/22] sparc: %pf is only for function pointers
Date: Sat, 14 Mar 2015 07:47:09 +0000 [thread overview]
Message-ID: <20150314074709.GA5376@ravnborg.org> (raw)
In-Reply-To: <1426196761-4891-1-git-send-email-scottwood@freescale.com>
On Thu, Mar 12, 2015 at 04:45:59PM -0500, Scott Wood wrote:
> Use %ps for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pf expects a function descriptor. Even on
> other architectures, refrain from setting a bad example that people
> copy.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: sparclinux@vger.kernel.org
> Cc: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> v2: Fix commit message to reflect that this patch is about %pf, not %pF.
>
> arch/sparc/kernel/ds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c
> index f87a55d..4ff835f 100644
> --- a/arch/sparc/kernel/ds.c
> +++ b/arch/sparc/kernel/ds.c
> @@ -875,7 +875,7 @@ void ldom_power_off(void)
>
> static void ds_conn_reset(struct ds_info *dp)
> {
> - printk(KERN_ERR "ds-%llu: ds_conn_reset() from %pf\n",
> + printk(KERN_ERR "ds-%llu: ds_conn_reset() from %ps\n",
> dp->id, __builtin_return_address(0));
> }
>
> --
> 2.1.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Scott Wood <scottwood@freescale.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 12/22] sparc: %pf is only for function pointers
Date: Sat, 14 Mar 2015 08:47:09 +0100 [thread overview]
Message-ID: <20150314074709.GA5376@ravnborg.org> (raw)
In-Reply-To: <1426196761-4891-1-git-send-email-scottwood@freescale.com>
On Thu, Mar 12, 2015 at 04:45:59PM -0500, Scott Wood wrote:
> Use %ps for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pf expects a function descriptor. Even on
> other architectures, refrain from setting a bad example that people
> copy.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: sparclinux@vger.kernel.org
> Cc: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> v2: Fix commit message to reflect that this patch is about %pf, not %pF.
>
> arch/sparc/kernel/ds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c
> index f87a55d..4ff835f 100644
> --- a/arch/sparc/kernel/ds.c
> +++ b/arch/sparc/kernel/ds.c
> @@ -875,7 +875,7 @@ void ldom_power_off(void)
>
> static void ds_conn_reset(struct ds_info *dp)
> {
> - printk(KERN_ERR "ds-%llu: ds_conn_reset() from %pf\n",
> + printk(KERN_ERR "ds-%llu: ds_conn_reset() from %ps\n",
> dp->id, __builtin_return_address(0));
> }
>
> --
> 2.1.0
>
next prev parent reply other threads:[~2015-03-14 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 21:45 [PATCH v2 12/22] sparc: %pf is only for function pointers Scott Wood
2015-03-12 21:45 ` Scott Wood
2015-03-12 21:46 ` [PATCH v2 14/22] parisc: " Scott Wood
2015-03-12 21:46 ` [PATCH v2 18/22] usb: gadget: serial: " Scott Wood
2015-03-12 22:02 ` Fabio Estevam
2015-03-14 7:47 ` Sam Ravnborg [this message]
2015-03-14 7:47 ` [PATCH v2 12/22] sparc: " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150314074709.GA5376@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=sparclinux@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.