All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: move driver state check before setting throttle
Date: Sun, 15 Mar 2015 13:57:36 +0530	[thread overview]
Message-ID: <20150315082734.GD18213@qca.qualcomm.com> (raw)
In-Reply-To: <873858rgh6.fsf@kamboji.qca.qualcomm.com>

On Fri, Mar 13, 2015 at 06:48:21PM +0200, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> 
> > Since thermal daemon is unaware of the device state, it might
> > try to adjust the throttle state when the device is powered down.
> > So the driver caches the value and will configure it while
> > powering up the target. The cached value will be programed later
> > once the device is brought up. In such case, returning error
> > status is confusing and misleading the user application. Hence
> > moving the driver state check before sending wmi command to target.
> >
> > Reported-by: Matthias Kaehlcke <mka@google.com>
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> 
> What tree do you use as the baseline? Three-way merge doesn't work as
> sha1 ids are not found:
> 
Will send rebased version.

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: move driver state check before setting throttle
Date: Sun, 15 Mar 2015 13:57:36 +0530	[thread overview]
Message-ID: <20150315082734.GD18213@qca.qualcomm.com> (raw)
In-Reply-To: <873858rgh6.fsf@kamboji.qca.qualcomm.com>

On Fri, Mar 13, 2015 at 06:48:21PM +0200, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> 
> > Since thermal daemon is unaware of the device state, it might
> > try to adjust the throttle state when the device is powered down.
> > So the driver caches the value and will configure it while
> > powering up the target. The cached value will be programed later
> > once the device is brought up. In such case, returning error
> > status is confusing and misleading the user application. Hence
> > moving the driver state check before sending wmi command to target.
> >
> > Reported-by: Matthias Kaehlcke <mka@google.com>
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> 
> What tree do you use as the baseline? Three-way merge doesn't work as
> sha1 ids are not found:
> 
Will send rebased version.

-Rajkumar

  reply	other threads:[~2015-03-15  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 18:04 [PATCH] ath10k: move driver state check before setting throttle Rajkumar Manoharan
2015-03-11 18:04 ` Rajkumar Manoharan
2015-03-13 16:48 ` Kalle Valo
2015-03-13 16:48   ` Kalle Valo
2015-03-15  8:27   ` Rajkumar Manoharan [this message]
2015-03-15  8:27     ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150315082734.GD18213@qca.qualcomm.com \
    --to=rmanohar@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.