From: Nicholas Mc Guire <der.herr@hofr.at>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
Kalle Valo <kvalo@qca.qualcomm.com>,
Michal Kazior <michal.kazior@tieto.com>,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: Re: [PATCH 2/2] ath10k: core: harmonize error case handling in ath10k_core_start
Date: Sun, 15 Mar 2015 11:17:58 +0100 [thread overview]
Message-ID: <20150315101758.GA28477@opentech.at> (raw)
In-Reply-To: <550497A0.5040508@cogentembedded.com>
On Sat, 14 Mar 2015, Sergei Shtylyov wrote:
> Hello.
>
> On 03/14/2015 11:55 AM, Nicholas Mc Guire wrote:
>
>> All of the bringup/init functions called in ath10k_core_start return 0 on
>> success and != 0 on failure - ath10k_wmi_wait_for_service_ready and
>> ath10k_wmi_wait_for_unified_ready were adjusted to fit this model and the
>> call sites here fixed up accordingly.
>
> If you've changed the sense of these function's results, you need to
> adjust the call sites in the same patch, because otherwise one wouldn't
> be able to bisect this...
>
yup both patches would mess up if individually applied or reverted.
sorry my ignorance - did not think of that problem - will fix it
up as a single patch and repost.
thx!
hofrat
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Mc Guire <der.herr@hofr.at>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Michal Kazior <michal.kazior@tieto.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: core: harmonize error case handling in ath10k_core_start
Date: Sun, 15 Mar 2015 11:17:58 +0100 [thread overview]
Message-ID: <20150315101758.GA28477@opentech.at> (raw)
In-Reply-To: <550497A0.5040508@cogentembedded.com>
On Sat, 14 Mar 2015, Sergei Shtylyov wrote:
> Hello.
>
> On 03/14/2015 11:55 AM, Nicholas Mc Guire wrote:
>
>> All of the bringup/init functions called in ath10k_core_start return 0 on
>> success and != 0 on failure - ath10k_wmi_wait_for_service_ready and
>> ath10k_wmi_wait_for_unified_ready were adjusted to fit this model and the
>> call sites here fixed up accordingly.
>
> If you've changed the sense of these function's results, you need to
> adjust the call sites in the same patch, because otherwise one wouldn't
> be able to bisect this...
>
yup both patches would mess up if individually applied or reverted.
sorry my ignorance - did not think of that problem - will fix it
up as a single patch and repost.
thx!
hofrat
next prev parent reply other threads:[~2015-03-15 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 8:55 [PATCH 2/2] ath10k: core: harmonize error case handling in ath10k_core_start Nicholas Mc Guire
2015-03-14 8:55 ` Nicholas Mc Guire
2015-03-14 8:55 ` Nicholas Mc Guire
2015-03-14 20:18 ` Sergei Shtylyov
2015-03-14 20:18 ` Sergei Shtylyov
2015-03-15 10:17 ` Nicholas Mc Guire [this message]
2015-03-15 10:17 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150315101758.GA28477@opentech.at \
--to=der.herr@hofr.at \
--cc=ath10k@lists.infradead.org \
--cc=hofrat@osadl.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.