All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: eliad@wizery.com, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Subject: Re: wl18xx: show rx_frames_per_rates as an array as it really is
Date: Mon, 16 Mar 2015 16:07:33 +0000 (UTC)	[thread overview]
Message-ID: <20150316160734.00F6113FC52@smtp.codeaurora.org> (raw)
In-Reply-To: <1426231034-20163-1-git-send-email-nicolas.iooss_linux@m4x.org>


> In struct wl18xx_acx_rx_rate_stat, rx_frames_per_rates field is an
> array, not a number.  This means WL18XX_DEBUGFS_FWSTATS_FILE can't be
> used to display this field in debugfs (it would display a pointer, not
> the actual data).  Use WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY instead.
> 
> This bug has been found by adding a __printf attribute to
> wl1271_format_buffer.  gcc complained about "format '%u' expects
> argument of type 'unsigned int', but argument 5 has type 'u32 *'".
> 
> Fixes: c5d94169e818 ("wl18xx: use new fw stats structures")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Nicolas Iooss <nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>
Cc: eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Nicolas Iooss <nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>
Subject: Re: wl18xx: show rx_frames_per_rates as an array as it really is
Date: Mon, 16 Mar 2015 16:07:33 +0000 (UTC)	[thread overview]
Message-ID: <20150316160734.00F6113FC52@smtp.codeaurora.org> (raw)
In-Reply-To: <1426231034-20163-1-git-send-email-nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>


> In struct wl18xx_acx_rx_rate_stat, rx_frames_per_rates field is an
> array, not a number.  This means WL18XX_DEBUGFS_FWSTATS_FILE can't be
> used to display this field in debugfs (it would display a pointer, not
> the actual data).  Use WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY instead.
> 
> This bug has been found by adding a __printf attribute to
> wl1271_format_buffer.  gcc complained about "format '%u' expects
> argument of type 'unsigned int', but argument 5 has type 'u32 *'".
> 
> Fixes: c5d94169e818 ("wl18xx: use new fw stats structures")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-03-16 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 12:39 wl18xx: Bad format for rx_frames_per_rates in debugfs? Nicolas Iooss
2015-03-12 12:39 ` Nicolas Iooss
2015-03-12 13:16 ` Eliad Peller
2015-03-13  7:17 ` [PATCH] wl18xx: show rx_frames_per_rates as an array as it really is Nicolas Iooss
2015-03-16 16:07   ` Kalle Valo [this message]
2015-03-16 16:07     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316160734.00F6113FC52@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=eliad@wizery.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.iooss_linux@m4x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.