* [PATCH 1/2] ASoC: rt286: Drop unnecessary dapm bias_level initialization
@ 2015-03-16 15:39 Lars-Peter Clausen
2015-03-16 15:39 ` [PATCH 2/2] ASoC: wm2200: " Lars-Peter Clausen
2015-03-17 12:09 ` [PATCH 1/2] ASoC: rt286: " Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2015-03-16 15:39 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Oder Chiou, alsa-devel, Lars-Peter Clausen, patches, Bard Liao,
Charles Keepax
The default value for the bias_level is SND_SOC_BIAS_OFF when probe is being
called, there is no need to initialize it explicitly.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/codecs/rt286.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index fb3f5d3..7bbe714 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -1048,7 +1048,6 @@ static int rt286_probe(struct snd_soc_codec *codec)
struct rt286_priv *rt286 = snd_soc_codec_get_drvdata(codec);
rt286->codec = codec;
- codec->dapm.bias_level = SND_SOC_BIAS_OFF;
if (rt286->i2c->irq) {
regmap_update_bits(rt286->regmap,
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] ASoC: wm2200: Drop unnecessary dapm bias_level initialization
2015-03-16 15:39 [PATCH 1/2] ASoC: rt286: Drop unnecessary dapm bias_level initialization Lars-Peter Clausen
@ 2015-03-16 15:39 ` Lars-Peter Clausen
2015-03-16 16:36 ` Charles Keepax
2015-03-17 12:09 ` Mark Brown
2015-03-17 12:09 ` [PATCH 1/2] ASoC: rt286: " Mark Brown
1 sibling, 2 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2015-03-16 15:39 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Oder Chiou, alsa-devel, Lars-Peter Clausen, patches, Bard Liao,
Charles Keepax
The default value for the bias_level is SND_SOC_BIAS_OFF when probe is being
called, there is no need to initialize it explicitly.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/codecs/wm2200.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/wm2200.c b/sound/soc/codecs/wm2200.c
index b48694a..5a9da28 100644
--- a/sound/soc/codecs/wm2200.c
+++ b/sound/soc/codecs/wm2200.c
@@ -1554,7 +1554,6 @@ static int wm2200_probe(struct snd_soc_codec *codec)
int ret;
wm2200->codec = codec;
- codec->dapm.bias_level = SND_SOC_BIAS_OFF;
ret = snd_soc_add_codec_controls(codec, wm_adsp1_fw_controls, 2);
if (ret != 0)
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ASoC: wm2200: Drop unnecessary dapm bias_level initialization
2015-03-16 15:39 ` [PATCH 2/2] ASoC: wm2200: " Lars-Peter Clausen
@ 2015-03-16 16:36 ` Charles Keepax
2015-03-17 12:09 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2015-03-16 16:36 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Oder Chiou, alsa-devel, patches, Liam Girdwood, Mark Brown,
Bard Liao
On Mon, Mar 16, 2015 at 04:39:57PM +0100, Lars-Peter Clausen wrote:
> The default value for the bias_level is SND_SOC_BIAS_OFF when probe is being
> called, there is no need to initialize it explicitly.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ASoC: wm2200: Drop unnecessary dapm bias_level initialization
2015-03-16 15:39 ` [PATCH 2/2] ASoC: wm2200: " Lars-Peter Clausen
2015-03-16 16:36 ` Charles Keepax
@ 2015-03-17 12:09 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2015-03-17 12:09 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Oder Chiou, alsa-devel, patches, Liam Girdwood, Bard Liao,
Charles Keepax
[-- Attachment #1.1: Type: text/plain, Size: 221 bytes --]
On Mon, Mar 16, 2015 at 04:39:57PM +0100, Lars-Peter Clausen wrote:
> The default value for the bias_level is SND_SOC_BIAS_OFF when probe is being
> called, there is no need to initialize it explicitly.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ASoC: rt286: Drop unnecessary dapm bias_level initialization
2015-03-16 15:39 [PATCH 1/2] ASoC: rt286: Drop unnecessary dapm bias_level initialization Lars-Peter Clausen
2015-03-16 15:39 ` [PATCH 2/2] ASoC: wm2200: " Lars-Peter Clausen
@ 2015-03-17 12:09 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2015-03-17 12:09 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Oder Chiou, alsa-devel, patches, Liam Girdwood, Bard Liao,
Charles Keepax
[-- Attachment #1.1: Type: text/plain, Size: 221 bytes --]
On Mon, Mar 16, 2015 at 04:39:56PM +0100, Lars-Peter Clausen wrote:
> The default value for the bias_level is SND_SOC_BIAS_OFF when probe is being
> called, there is no need to initialize it explicitly.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-17 12:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-16 15:39 [PATCH 1/2] ASoC: rt286: Drop unnecessary dapm bias_level initialization Lars-Peter Clausen
2015-03-16 15:39 ` [PATCH 2/2] ASoC: wm2200: " Lars-Peter Clausen
2015-03-16 16:36 ` Charles Keepax
2015-03-17 12:09 ` Mark Brown
2015-03-17 12:09 ` [PATCH 1/2] ASoC: rt286: " Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.