From: Sami Tolvanen <samitolvanen@google.com>
To: Andy Polyakov <appro@openssl.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] arm: crypto: Add NEON optimized SHA-256
Date: Tue, 17 Mar 2015 15:21:20 +0000 [thread overview]
Message-ID: <20150317152120.GA31053@google.com> (raw)
In-Reply-To: <550843B4.8080903@openssl.org>
On Tue, Mar 17, 2015 at 04:09:40PM +0100, Andy Polyakov wrote:
> I have no problems with reusing assembly modules in kernel context.
Awesome, thank you for clarifying this.
> I'd prefer if it can be arranged in way similar to bsaes-armv7 module,
> i.e. we work together on shared copy of module that generates assembly
> that can be then compiled for OpenSSL or kernel. Is it sensible?
Sure, that sounds good to me.
> BTW, why stop at SHA256? There is SHA512 and NEON SHA1...
The kernel already has NEON SHA-1 and SHA-512, but for some reason is
lacking SHA-256. I have not tested how they compare to yours though.
Sami
WARNING: multiple messages have this Message-ID (diff)
From: samitolvanen@google.com (Sami Tolvanen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: crypto: Add NEON optimized SHA-256
Date: Tue, 17 Mar 2015 15:21:20 +0000 [thread overview]
Message-ID: <20150317152120.GA31053@google.com> (raw)
In-Reply-To: <550843B4.8080903@openssl.org>
On Tue, Mar 17, 2015 at 04:09:40PM +0100, Andy Polyakov wrote:
> I have no problems with reusing assembly modules in kernel context.
Awesome, thank you for clarifying this.
> I'd prefer if it can be arranged in way similar to bsaes-armv7 module,
> i.e. we work together on shared copy of module that generates assembly
> that can be then compiled for OpenSSL or kernel. Is it sensible?
Sure, that sounds good to me.
> BTW, why stop at SHA256? There is SHA512 and NEON SHA1...
The kernel already has NEON SHA-1 and SHA-512, but for some reason is
lacking SHA-256. I have not tested how they compare to yours though.
Sami
next prev parent reply other threads:[~2015-03-17 15:21 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:48 [PATCH] arm: crypto: Add NEON optimized SHA-256 Sami Tolvanen
2015-03-16 15:48 ` Sami Tolvanen
2015-03-16 16:08 ` Ard Biesheuvel
2015-03-16 16:08 ` Ard Biesheuvel
2015-03-16 16:23 ` Sami Tolvanen
2015-03-16 16:23 ` Sami Tolvanen
2015-03-17 6:56 ` Ard Biesheuvel
2015-03-17 6:56 ` Ard Biesheuvel
2015-03-17 15:09 ` Andy Polyakov
2015-03-17 15:09 ` Andy Polyakov
2015-03-17 15:21 ` Sami Tolvanen [this message]
2015-03-17 15:21 ` Sami Tolvanen
2015-03-17 15:51 ` Ard Biesheuvel
2015-03-17 15:51 ` Ard Biesheuvel
2015-03-23 13:50 ` [PATCHv2] arm: crypto: Add optimized SHA-256/224 Sami Tolvanen
2015-03-23 13:50 ` Sami Tolvanen
2015-03-23 18:26 ` Ard Biesheuvel
2015-03-23 18:26 ` Ard Biesheuvel
2015-03-24 11:35 ` Herbert Xu
2015-03-24 11:35 ` Herbert Xu
2015-03-24 11:40 ` Ard Biesheuvel
2015-03-24 11:40 ` Ard Biesheuvel
2015-03-24 11:46 ` Herbert Xu
2015-03-24 11:46 ` Herbert Xu
2015-03-24 11:57 ` Ard Biesheuvel
2015-03-24 11:57 ` Ard Biesheuvel
2015-03-24 11:32 ` Herbert Xu
2015-03-24 11:32 ` Herbert Xu
2015-03-24 11:33 ` Ard Biesheuvel
2015-03-24 11:33 ` Ard Biesheuvel
2015-03-24 12:27 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 12:27 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 12:42 ` Ard Biesheuvel
2015-03-24 12:42 ` Ard Biesheuvel
2015-03-24 13:05 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 13:05 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 13:06 ` Ard Biesheuvel
2015-03-24 13:06 ` Ard Biesheuvel
2015-03-24 14:46 ` Ard Biesheuvel
2015-03-24 14:46 ` Ard Biesheuvel
2015-03-24 17:05 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 17:05 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-24 17:40 ` Ard Biesheuvel
2015-03-24 17:40 ` Ard Biesheuvel
2015-03-24 18:17 ` Sami Tolvanen
2015-03-24 18:17 ` Sami Tolvanen
2015-03-25 6:49 ` Ard Biesheuvel
2015-03-25 6:49 ` Ard Biesheuvel
2015-03-27 10:42 ` Andy Polyakov
2015-03-27 10:42 ` Andy Polyakov
2015-03-27 10:44 ` Ard Biesheuvel
2015-03-27 10:44 ` Ard Biesheuvel
2015-03-27 18:07 ` Ard Biesheuvel
2015-03-27 18:07 ` Ard Biesheuvel
2015-03-29 13:27 ` Andy Polyakov
2015-03-29 13:27 ` Andy Polyakov
2015-03-30 8:37 ` [PATCHv3] " Sami Tolvanen
2015-03-30 8:37 ` Sami Tolvanen
2015-04-01 12:43 ` Herbert Xu
2015-04-01 12:43 ` Herbert Xu
2015-04-01 13:19 ` Sami Tolvanen
2015-04-01 13:19 ` Sami Tolvanen
2015-04-03 10:04 ` Herbert Xu
2015-04-03 10:04 ` Herbert Xu
2015-03-25 20:00 ` [PATCH] arm: crypto: Add NEON optimized SHA-256 Jean-Christophe PLAGNIOL-VILLARD
2015-03-25 20:00 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317152120.GA31053@google.com \
--to=samitolvanen@google.com \
--cc=appro@openssl.org \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.