Re: [Outreachy kernel] [PATCH 0/5] Replace memcpy with ether_addr_copy and fix checkpatch warning

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 17, 2015 at 12:48:10AM +0530, Darshana Padmadas wrote:
> This patch set replaces memcpy with ether_addr_copy if the 
> addresses of the structures are aligned. Structure layout is 
> shown by using the Pahole tool.
> 
> This patch set fixes the following warning reported by checkpatch:
> WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
> 
> Darshana Padmadas (5):
>   Staging: rtl8192e: Replace memcpy with ether_addr_copy
>   Staging: rtl8192e: Use ether_addr_copy instead of memcpy
>   Staging: rtl8192e: Use ether_addr_copy replacing memcpy
>   Staging: rtl8192e: Use ether_addr_copy for aligned addresses
>   Staging: rtl8192e: replace memcpy with ether_addr_copy for aligned
>     structures
> 
>  drivers/staging/rtl8192e/rtl819x_BAProc.c    |  4 ++--
>  drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 10 ++++----
>  drivers/staging/rtl8192e/rtllib_rx.c         | 34 ++++++++++++++--------------
>  drivers/staging/rtl8192e/rtllib_softmac.c    | 12 +++++-----
>  drivers/staging/rtl8192e/rtllib_tx.c         |  6 ++---
>  5 files changed, 33 insertions(+), 33 deletions(-)

You did not test build these patches, they break the build horribly :(

ALWAYS test-build your patches before sending them out, it's rude to
have to have other people find problems with them.

thanks,

greg k-h