All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: Darshana Padmadas <darshanapadmadas@gmail.com>,
	 outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 0/5] Replace memcpy with ether_addr_copy and fix checkpatch warning
Date: Tue, 17 Mar 2015 11:33:01 -0400	[thread overview]
Message-ID: <5508492D.9010805@gmail.com> (raw)
In-Reply-To: <cover.1426533157.git.darshanapadmadas@gmail.com>

On 03/16/15 15:18, Darshana Padmadas wrote:
> This patch set replaces memcpy with ether_addr_copy if the 
> addresses of the structures are aligned. Structure layout is 
> shown by using the Pahole tool.
> 
> This patch set fixes the following warning reported by checkpatch:
> WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
> 
> Darshana Padmadas (5):
>   Staging: rtl8192e: Replace memcpy with ether_addr_copy
>   Staging: rtl8192e: Use ether_addr_copy instead of memcpy
>   Staging: rtl8192e: Use ether_addr_copy replacing memcpy
>   Staging: rtl8192e: Use ether_addr_copy for aligned addresses
>   Staging: rtl8192e: replace memcpy with ether_addr_copy for aligned
>     structures
> 
>  drivers/staging/rtl8192e/rtl819x_BAProc.c    |  4 ++--
>  drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 10 ++++----
>  drivers/staging/rtl8192e/rtllib_rx.c         | 34 ++++++++++++++--------------
>  drivers/staging/rtl8192e/rtllib_softmac.c    | 12 +++++-----
>  drivers/staging/rtl8192e/rtllib_tx.c         |  6 ++---
>  5 files changed, 33 insertions(+), 33 deletions(-)
> 

This set looks good to me!

Jes



  parent reply	other threads:[~2015-03-17 15:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 19:18 [PATCH 0/5] Replace memcpy with ether_addr_copy and fix checkpatch warning Darshana Padmadas
2015-03-16 19:18 ` [PATCH 1/5] Staging: rtl8192e: Replace memcpy with ether_addr_copy Darshana Padmadas
     [not found]   ` <cover.1426681038.git.darshanapadmadas@gmail.com>
2015-03-18 12:34     ` [PATCH v2 " Darshana Padmadas
2015-03-18 12:36       ` [Outreachy kernel] " Julia Lawall
2015-03-18 12:35     ` [PATCH v2 2/5] Staging: rtl8192e: Use ether_addr_copy instead of memcpy Darshana Padmadas
2015-03-18 13:01       ` [PATCH v3 " Darshana Padmadas
2015-03-16 19:18 ` [PATCH " Darshana Padmadas
2015-03-16 19:18 ` [PATCH 3/5] Staging: rtl8192e: Use ether_addr_copy replacing memcpy Darshana Padmadas
2015-03-16 19:18 ` [PATCH 4/5] Staging: rtl8192e: Use ether_addr_copy for aligned addresses Darshana Padmadas
2015-03-16 19:18 ` [PATCH 5/5] Staging: rtl8192e: replace memcpy with ether_addr_copy for aligned structures Darshana Padmadas
2015-03-17 15:33 ` Jes Sorensen [this message]
2015-03-18 10:19 ` [Outreachy kernel] [PATCH 0/5] Replace memcpy with ether_addr_copy and fix checkpatch warning Greg KH
2015-03-18 13:05   ` Darshana Padmadas
2015-03-18 13:37     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5508492D.9010805@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=darshanapadmadas@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.