From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dave@stgolabs.net>,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH V2 4/4] hugetlbfs: document min_size mount option
Date: Wed, 18 Mar 2015 19:23:24 -0700 [thread overview]
Message-ID: <20150318192324.e0386907.akpm@linux-foundation.org> (raw)
In-Reply-To: <550A2B9A.3060905@oracle.com>
On Wed, 18 Mar 2015 18:51:22 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> > Nowhere here is the reader told the units of "size". We should at
> > least describe that, and maybe even rename the thing to min_bytes.
> >
>
> Ok, I will add that the size is in unit of bytes. My choice of
> 'min_size' as a name for the new mount option was influenced by
> the existing 'size' mount option. I'm open to any suggestions
> for the name of this new mount option.
Yes, due to the preexisting "size" I think we're stuck with "min_size".
We could use min_size_bytes I guess, but the operator needs to go look
up the units of "size" anyway.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dave@stgolabs.net>,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH V2 4/4] hugetlbfs: document min_size mount option
Date: Wed, 18 Mar 2015 19:23:24 -0700 [thread overview]
Message-ID: <20150318192324.e0386907.akpm@linux-foundation.org> (raw)
In-Reply-To: <550A2B9A.3060905@oracle.com>
On Wed, 18 Mar 2015 18:51:22 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> > Nowhere here is the reader told the units of "size". We should at
> > least describe that, and maybe even rename the thing to min_bytes.
> >
>
> Ok, I will add that the size is in unit of bytes. My choice of
> 'min_size' as a name for the new mount option was influenced by
> the existing 'size' mount option. I'm open to any suggestions
> for the name of this new mount option.
Yes, due to the preexisting "size" I think we're stuck with "min_size".
We could use min_size_bytes I guess, but the operator needs to go look
up the units of "size" anyway.
next prev parent reply other threads:[~2015-03-19 2:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 23:53 [PATCH V2 0/4] hugetlbfs: add min_size filesystem mount option Mike Kravetz
2015-03-16 23:53 ` Mike Kravetz
2015-03-16 23:53 ` [PATCH V2 1/4] hugetlbfs: add minimum size tracking fields to subpool structure Mike Kravetz
2015-03-16 23:53 ` Mike Kravetz
2015-03-18 21:25 ` Andrew Morton
2015-03-18 21:25 ` Andrew Morton
2015-03-16 23:53 ` [PATCH V2 2/4] hugetlbfs: add minimum size accounting to subpools Mike Kravetz
2015-03-16 23:53 ` Mike Kravetz
2015-03-18 21:43 ` Andrew Morton
2015-03-18 21:43 ` Andrew Morton
2015-03-16 23:53 ` [PATCH V2 3/4] hugetlbfs: accept subpool min_size mount option and setup accordingly Mike Kravetz
2015-03-16 23:53 ` Mike Kravetz
2015-03-18 21:40 ` Andrew Morton
2015-03-18 21:40 ` Andrew Morton
2015-03-19 1:34 ` Mike Kravetz
2015-03-19 1:34 ` Mike Kravetz
2015-03-16 23:53 ` [PATCH V2 4/4] hugetlbfs: document min_size mount option Mike Kravetz
2015-03-16 23:53 ` Mike Kravetz
2015-03-18 21:41 ` Andrew Morton
2015-03-18 21:41 ` Andrew Morton
2015-03-19 1:51 ` Mike Kravetz
2015-03-19 1:51 ` Mike Kravetz
2015-03-19 2:23 ` Andrew Morton [this message]
2015-03-19 2:23 ` Andrew Morton
2015-03-20 16:24 ` Mike Kravetz
2015-03-20 16:24 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318192324.e0386907.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dave@stgolabs.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.