From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
Cc: "Sekhar Nori" <nsekhar-l0cyMroinI0@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Kevin Hilman"
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>,
"Santosh Shilimkar"
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Murali Karicheri" <m-karicheri2-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure
Date: Wed, 18 Mar 2015 21:31:51 +0100 [thread overview]
Message-ID: <20150318203151.GA12072@katana> (raw)
In-Reply-To: <1417448047-15236-5-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
Hi,
so, the bus recovery patches look fine to me in general.
It is only this one question left which I always had with bus recovery.
Maybe you guys can join me thinking about it.
> @@ -376,8 +366,7 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop)
> dev->adapter.timeout);
> if (r == 0) {
> dev_err(dev->dev, "controller timed out\n");
> - davinci_i2c_recover_bus(dev);
> - i2c_davinci_init(dev);
> + i2c_recover_bus(adap);
> dev->buf_len = 0;
> return -ETIMEDOUT;
The I2C specs say in 3.1.16 that the recovery procedure should be used
when SDA is stuck low. So, I do wonder if we should apply the recovery
after a timeout. Stuck SDA might be one reason for timeout, but there
may be others...
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure
Date: Wed, 18 Mar 2015 21:31:51 +0100 [thread overview]
Message-ID: <20150318203151.GA12072@katana> (raw)
In-Reply-To: <1417448047-15236-5-git-send-email-grygorii.strashko@ti.com>
Hi,
so, the bus recovery patches look fine to me in general.
It is only this one question left which I always had with bus recovery.
Maybe you guys can join me thinking about it.
> @@ -376,8 +366,7 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop)
> dev->adapter.timeout);
> if (r == 0) {
> dev_err(dev->dev, "controller timed out\n");
> - davinci_i2c_recover_bus(dev);
> - i2c_davinci_init(dev);
> + i2c_recover_bus(adap);
> dev->buf_len = 0;
> return -ETIMEDOUT;
The I2C specs say in 3.1.16 that the recovery procedure should be used
when SDA is stuck low. So, I do wonder if we should apply the recovery
after a timeout. Stuck SDA might be one reason for timeout, but there
may be others...
Thanks,
Wolfram
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150318/fe06be70/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Sekhar Nori" <nsekhar@ti.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Kevin Hilman" <khilman@deeprootsystems.com>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Murali Karicheri" <m-karicheri2@ti.com>
Subject: Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure
Date: Wed, 18 Mar 2015 21:31:51 +0100 [thread overview]
Message-ID: <20150318203151.GA12072@katana> (raw)
In-Reply-To: <1417448047-15236-5-git-send-email-grygorii.strashko@ti.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
Hi,
so, the bus recovery patches look fine to me in general.
It is only this one question left which I always had with bus recovery.
Maybe you guys can join me thinking about it.
> @@ -376,8 +366,7 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop)
> dev->adapter.timeout);
> if (r == 0) {
> dev_err(dev->dev, "controller timed out\n");
> - davinci_i2c_recover_bus(dev);
> - i2c_davinci_init(dev);
> + i2c_recover_bus(adap);
> dev->buf_len = 0;
> return -ETIMEDOUT;
The I2C specs say in 3.1.16 that the recovery procedure should be used
when SDA is stuck low. So, I do wonder if we should apply the recovery
after a timeout. Stuck SDA might be one reason for timeout, but there
may be others...
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-18 20:31 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 15:34 [PATCH v3 0/5] i2c: davinci improvements and fixes Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
[not found] ` <1417448047-15236-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-12-01 15:34 ` [PATCH v3 1/5] i2c: i2c-davinci: switch to use platform_get_irq Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
[not found] ` <1417448047-15236-2-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-12-04 18:28 ` Wolfram Sang
2014-12-04 18:28 ` Wolfram Sang
2014-12-04 18:28 ` Wolfram Sang
2014-12-01 15:34 ` [PATCH v3 2/5] i2c: davinci: generate STP always when NACK is received Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2014-12-04 18:28 ` Wolfram Sang
2014-12-04 18:28 ` Wolfram Sang
2014-12-01 15:34 ` [PATCH v3 3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
[not found] ` <1417448047-15236-4-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-12-04 18:29 ` Wolfram Sang
2014-12-04 18:29 ` Wolfram Sang
2014-12-04 18:29 ` Wolfram Sang
2015-03-05 18:41 ` Grygorii Strashko
2015-03-05 18:41 ` Grygorii Strashko
2015-03-05 18:41 ` Grygorii Strashko
2015-03-12 11:32 ` Alexander Sverdlin
2015-03-12 11:32 ` Alexander Sverdlin
2015-03-12 11:32 ` Alexander Sverdlin
[not found] ` <55017943.6040603-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-03-13 10:15 ` Grygorii.Strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
2015-03-13 10:15 ` Grygorii.Strashko@linaro.org
2015-03-13 10:15 ` Grygorii.Strashko@linaro.org
[not found] ` <5502B8DA.70504-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-03-13 15:45 ` Felipe Balbi
2015-03-13 15:45 ` Felipe Balbi
2015-03-13 15:45 ` Felipe Balbi
2014-12-01 15:34 ` [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2015-03-12 11:45 ` Alexander Sverdlin
2015-03-12 11:45 ` Alexander Sverdlin
[not found] ` <1417448047-15236-5-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2015-03-18 20:31 ` Wolfram Sang [this message]
2015-03-18 20:31 ` Wolfram Sang
2015-03-18 20:31 ` Wolfram Sang
2015-03-20 18:32 ` Grygorii.Strashko@linaro.org
2015-03-20 18:32 ` Grygorii.Strashko@linaro.org
[not found] ` <550C67D6.3080909-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-04-03 20:18 ` Wolfram Sang
2015-04-03 20:18 ` Wolfram Sang
2015-04-03 20:18 ` Wolfram Sang
2015-04-06 13:11 ` Grygorii.Strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
2015-04-06 13:11 ` Grygorii.Strashko@linaro.org
2015-04-06 13:11 ` Grygorii.Strashko@linaro.org
[not found] ` <55228613.2060607-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-04-06 16:09 ` Wolfram Sang
2015-04-06 16:09 ` Wolfram Sang
2015-04-06 16:09 ` Wolfram Sang
2015-04-06 16:28 ` Grygorii.Strashko-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
2015-04-06 16:28 ` Grygorii.Strashko@linaro.org
2015-04-06 16:28 ` Grygorii.Strashko@linaro.org
2014-12-01 15:34 ` [PATCH 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko
[not found] ` <1417448047-15236-6-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2015-04-01 14:38 ` Alexander Sverdlin
2015-04-01 14:38 ` Alexander Sverdlin
2015-04-01 14:38 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318203151.GA12072@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.