From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: gregkh@linuxfoundation.org, geert@glider.be,
laurent.pinchart@ideasonboard.com, linux-serial@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
jslaby@suse.cz
Subject: [PATCH v2 02/05] serial: sh-sci: Fix default RTS handling
Date: Thu, 19 Mar 2015 01:49:53 +0000 [thread overview]
Message-ID: <20150319014953.14235.86134.sendpatchset@little-apple> (raw)
In-Reply-To: <20150319014933.14235.44835.sendpatchset@little-apple>
From: Magnus Damm <damm+renesas@opensource.se>
Fix the default SCIF handling in case CTS/RTS is available
on the target board but disabled by user space. Without
this patch the RTS output value is not set.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Changes since V1:
- When modem control is disabled, set RTS to zero to keep it asserted.
drivers/tty/serial/sh-sci.c | 7 +++++--
include/linux/serial_sci.h | 1 +
2 files changed, 6 insertions(+), 2 deletions(-)
--- 0002/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c 2015-03-19 09:13:03.186797991 +0900
@@ -522,10 +522,13 @@ static void sci_init_ctsrts_default(stru
if (!reg->size || hwflow_enabled)
return;
+ /* Setup CTS/RTS in the case hardware flow is disabled by user space.
+ * The CTS signal is setup as input and RTS as output with value 0.
+ */
status = serial_port_in(port, SCSPTR);
- status &= ~SCSPTR_CTSIO;
+ status &= ~(SCSPTR_CTSIO | SCSPTR_RTSDT);
status |= SCSPTR_RTSIO;
- serial_port_out(port, SCSPTR, status); /* Set RTS = 1 */
+ serial_port_out(port, SCSPTR, status); /* Set RTS = 0 */
}
static void sci_init_pins(struct uart_port *port, unsigned int cflag)
--- 0001/include/linux/serial_sci.h
+++ work/include/linux/serial_sci.h 2015-03-19 09:11:14.936798380 +0900
@@ -57,6 +57,7 @@
/* SCSPTR (Serial Port Register), optional */
#define SCSPTR_RTSIO (1 << 7) /* Serial Port RTS Pin Input/Output */
+#define SCSPTR_RTSDT (1 << 6) /* Serial Port RTS Pin Data */
#define SCSPTR_CTSIO (1 << 5) /* Serial Port CTS Pin Input/Output */
#define SCSPTR_SPB2IO (1 << 1) /* Serial Port Break Input/Output */
#define SCSPTR_SPB2DT (1 << 0) /* Serial Port Break Data */
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: gregkh@linuxfoundation.org, geert@glider.be,
laurent.pinchart@ideasonboard.com, linux-serial@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
jslaby@suse.cz
Subject: [PATCH v2 02/05] serial: sh-sci: Fix default RTS handling
Date: Thu, 19 Mar 2015 10:49:53 +0900 [thread overview]
Message-ID: <20150319014953.14235.86134.sendpatchset@little-apple> (raw)
In-Reply-To: <20150319014933.14235.44835.sendpatchset@little-apple>
From: Magnus Damm <damm+renesas@opensource.se>
Fix the default SCIF handling in case CTS/RTS is available
on the target board but disabled by user space. Without
this patch the RTS output value is not set.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Changes since V1:
- When modem control is disabled, set RTS to zero to keep it asserted.
drivers/tty/serial/sh-sci.c | 7 +++++--
include/linux/serial_sci.h | 1 +
2 files changed, 6 insertions(+), 2 deletions(-)
--- 0002/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c 2015-03-19 09:13:03.186797991 +0900
@@ -522,10 +522,13 @@ static void sci_init_ctsrts_default(stru
if (!reg->size || hwflow_enabled)
return;
+ /* Setup CTS/RTS in the case hardware flow is disabled by user space.
+ * The CTS signal is setup as input and RTS as output with value 0.
+ */
status = serial_port_in(port, SCSPTR);
- status &= ~SCSPTR_CTSIO;
+ status &= ~(SCSPTR_CTSIO | SCSPTR_RTSDT);
status |= SCSPTR_RTSIO;
- serial_port_out(port, SCSPTR, status); /* Set RTS = 1 */
+ serial_port_out(port, SCSPTR, status); /* Set RTS = 0 */
}
static void sci_init_pins(struct uart_port *port, unsigned int cflag)
--- 0001/include/linux/serial_sci.h
+++ work/include/linux/serial_sci.h 2015-03-19 09:11:14.936798380 +0900
@@ -57,6 +57,7 @@
/* SCSPTR (Serial Port Register), optional */
#define SCSPTR_RTSIO (1 << 7) /* Serial Port RTS Pin Input/Output */
+#define SCSPTR_RTSDT (1 << 6) /* Serial Port RTS Pin Data */
#define SCSPTR_CTSIO (1 << 5) /* Serial Port CTS Pin Input/Output */
#define SCSPTR_SPB2IO (1 << 1) /* Serial Port Break Input/Output */
#define SCSPTR_SPB2DT (1 << 0) /* Serial Port Break Data */
next prev parent reply other threads:[~2015-03-19 1:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 1:49 [PATCH v2 00/05] serial: sh-sci: Hardware flow control update V2 Magnus Damm
2015-03-19 1:49 ` Magnus Damm
2015-03-19 1:49 ` [PATCH v2 01/05] serial: sh-sci: Break out default CTS/RTS pin setup Magnus Damm
2015-03-19 1:49 ` Magnus Damm
2015-03-19 1:49 ` Magnus Damm [this message]
2015-03-19 1:49 ` [PATCH v2 02/05] serial: sh-sci: Fix default RTS handling Magnus Damm
2015-03-19 1:50 ` [PATCH v2 03/05] serial: sh-sci: Expose default CTS pin Magnus Damm
2015-03-19 1:50 ` Magnus Damm
2015-03-19 1:50 ` [PATCH v2 04/05] serial: sh-sci: Add SCIFA/SCIFB CTS/RTS pin setup Magnus Damm
2015-03-19 1:50 ` Magnus Damm
2015-03-19 1:50 ` [PATCH v2 05/05] serial: sh-sci: Expose SCIFA/SCIFB CTS pin Magnus Damm
2015-03-19 1:50 ` Magnus Damm
2015-03-19 15:57 ` [PATCH v2 00/05] serial: sh-sci: Hardware flow control update V2 Peter Hurley
2015-03-19 15:57 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319014953.14235.86134.sendpatchset@little-apple \
--to=magnus.damm@gmail.com \
--cc=geert@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.