* [patch 1/2] crypto: img-hash - fix some compile warnings
@ 2015-03-20 14:21 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-03-20 14:21 UTC (permalink / raw)
To: Herbert Xu, James Hartley; +Cc: David S. Miller, linux-crypto, kernel-janitors
GCC complains about that %u is the wrong format string for size_t and
also that "ret" is unused.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index fec61fc..601ab35 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -192,7 +192,7 @@ static int img_hash_xmit_cpu(struct img_hash_dev *hdev, const u8 *buf,
u32 count, len32;
const u32 *buffer = (const u32 *)buf;
- dev_dbg(hdev->dev, "xmit_cpu: length: %u bytes\n", length);
+ dev_dbg(hdev->dev, "xmit_cpu: length: %zu bytes\n", length);
if (final)
hdev->flags |= DRIVER_FLAGS_FINAL;
@@ -459,7 +459,6 @@ static int img_hash_hw_init(struct img_hash_dev *hdev)
{
unsigned long long nbits;
u32 u, l;
- int ret;
img_hash_write(hdev, CR_RESET, CR_RESET_SET);
img_hash_write(hdev, CR_RESET, CR_RESET_UNSET);
^ permalink raw reply related [flat|nested] 3+ messages in thread* [patch 1/2] crypto: img-hash - fix some compile warnings
@ 2015-03-20 14:21 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-03-20 14:21 UTC (permalink / raw)
To: Herbert Xu, James Hartley; +Cc: David S. Miller, linux-crypto, kernel-janitors
GCC complains about that %u is the wrong format string for size_t and
also that "ret" is unused.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index fec61fc..601ab35 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -192,7 +192,7 @@ static int img_hash_xmit_cpu(struct img_hash_dev *hdev, const u8 *buf,
u32 count, len32;
const u32 *buffer = (const u32 *)buf;
- dev_dbg(hdev->dev, "xmit_cpu: length: %u bytes\n", length);
+ dev_dbg(hdev->dev, "xmit_cpu: length: %zu bytes\n", length);
if (final)
hdev->flags |= DRIVER_FLAGS_FINAL;
@@ -459,7 +459,6 @@ static int img_hash_hw_init(struct img_hash_dev *hdev)
{
unsigned long long nbits;
u32 u, l;
- int ret;
img_hash_write(hdev, CR_RESET, CR_RESET_SET);
img_hash_write(hdev, CR_RESET, CR_RESET_UNSET);
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [patch 1/2] crypto: img-hash - fix some compile warnings
2015-03-20 14:21 ` Dan Carpenter
(?)
@ 2015-03-20 18:55 ` James Hartley
-1 siblings, 0 replies; 3+ messages in thread
From: James Hartley @ 2015-03-20 18:55 UTC (permalink / raw)
To: Dan Carpenter, Herbert Xu
Cc: David S. Miller, linux-crypto@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Dan,
Thanks for the patch.
James.
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: 20 March 2015 14:21
> To: Herbert Xu; James Hartley
> Cc: David S. Miller; linux-crypto@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [patch 1/2] crypto: img-hash - fix some compile warnings
>
> GCC complains about that %u is the wrong format string for size_t and also that
> "ret" is unused.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c index
> fec61fc..601ab35 100644
> --- a/drivers/crypto/img-hash.c
> +++ b/drivers/crypto/img-hash.c
> @@ -192,7 +192,7 @@ static int img_hash_xmit_cpu(struct img_hash_dev
> *hdev, const u8 *buf,
> u32 count, len32;
> const u32 *buffer = (const u32 *)buf;
>
> - dev_dbg(hdev->dev, "xmit_cpu: length: %u bytes\n", length);
> + dev_dbg(hdev->dev, "xmit_cpu: length: %zu bytes\n", length);
>
> if (final)
> hdev->flags |= DRIVER_FLAGS_FINAL;
> @@ -459,7 +459,6 @@ static int img_hash_hw_init(struct img_hash_dev
> *hdev) {
> unsigned long long nbits;
> u32 u, l;
> - int ret;
>
> img_hash_write(hdev, CR_RESET, CR_RESET_SET);
> img_hash_write(hdev, CR_RESET, CR_RESET_UNSET);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-20 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-20 14:21 [patch 1/2] crypto: img-hash - fix some compile warnings Dan Carpenter
2015-03-20 14:21 ` Dan Carpenter
2015-03-20 18:55 ` James Hartley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.